Re: [OpenJDK 2D-Dev] [11] Upgrade to Marlin renderer 0.9.1

Hi, Here is the updated webrev: http://cr.openjdk.java.net/~lbourges/marlin/marlin-091.1/ Changes in MarlinProperties only: - getTileSize_Log2() & getTileWidth_Log2(); 32x32 tiles ie default = 5 (log2) I hope it is good for now as tile settings are the same as in jdk9/10. Regards, Laurent

Re: [OpenJDK 2D-Dev] [11] Upgrade to Marlin renderer 0.9.1

Sergey, Le mer. 14 mars 2018 à 17:14, Sergey Bylokhov a écrit : > On 13/03/2018 17:04, Sergey Bylokhov wrote: > >> I have started to look to this review, will run some closed tests and >> send a feedback soon. >> > > No issues found so far, +1. Thanks for your

Re: [OpenJDK 2D-Dev] RFR: Bug Pending: Build fails to compile jchuff.c

Hi Phil! thanks for pointing out the history, I was not aware of that. I looked at that huffman coding and tried to determine whether the underflow may happen in real life scenarios. I could at least not exclude that possibility. I looked thru the mailing list threads - did someone analyse and

Re: [OpenJDK 2D-Dev] RFR: JDK-8071469 Cleanup include and exclude of sound native libraries after source code restructure

Hi Magnus, > I have tested the following: > * On my linux machine, failure to load libjsound.so was not fatal. In Platform.java: 54 loadLibraries(); 55 readProperties(); and readProperties calls native nIsBigEndian if libjsound loading fails I'd expect nIsBigEndian fails

Re: [OpenJDK 2D-Dev] RFR: Bug Pending: Build fails to compile jchuff.c

I prefer the makefile fix, since we don't by policy, make changes to the imported libraries. On Jan 23rd [1] I expressed such a tool-chain specific makefile fix would be fine by me. Toolchain specific means ideally it would look like what Magnus wrote [2] Although you said GC 5.4.0 would

[OpenJDK 2D-Dev] RFR(xxxs): 8200052: libjavajpeg: Fix compile warning in jchuff.c

Hi all, may I please have another review for this really trivial change. It fixes a gcc warning on s390 and ppc. Also, it is probably a good idea to fix this. bug: https://bugs.openjdk.java.net/browse/JDK-8200052 webrev:

Re: [OpenJDK 2D-Dev] RFR: Bug Pending: Build fails to compile jchuff.c

:) > Hi Adam, > > no problem. I'll open a bug and if necessary find a second reviewer. Thanks for fixing, maybe I can stop building with warnings disabled on our s390 machines now. > > ..Thomas > > > On Wed, Mar 21, 2018 at 5:10 PM, Andrew Leonard wrote: > > Hi

Re: [OpenJDK 2D-Dev] RFR: Bug Pending: Build fails to compile jchuff.c

Hi Adam, no problem. I'll open a bug and if necessary find a second reviewer. Thanks for fixing, maybe I can stop building with warnings disabled on our s390 machines now. ..Thomas On Wed, Mar 21, 2018 at 5:10 PM, Andrew Leonard wrote: > Hi Thomas, > I'm a

Re: [OpenJDK 2D-Dev] RFR: Bug Pending: Build fails to compile jchuff.c

Hi Thomas, I'm a "contributor", but not a "committer", so not on that list, didn't even know that list existed! I was sort of assuming since it was a trivial change, and the request was for a review, i'd chip in...! Thanks Andrew Andrew Leonard Java Runtimes Development IBM Hursley IBM United

Re: [OpenJDK 2D-Dev] RFR: Bug Pending: Build fails to compile jchuff.c

Hi, @Andrew Leonard: Sorry, I cannot find your name in http://openjdk.java.net/census#jdk. Are you a jdk contributor/reviewer, and if yes, what is your user name? @openjdk 2d folks: I also need to know: does the 2d project have any special rules about who can push or can I just push (I am jdk

Re: [OpenJDK 2D-Dev] RFR: JDK-8071469 Cleanup include and exclude of sound native libraries after source code restructure

Build changes look good. /Erik On 2018-03-21 07:09, Magnus Ihse Bursie wrote: On 2018-03-16 17:49, Alex Menkov wrote: On 03/15/2018 13:09, Magnus Ihse Bursie wrote: 15 mars 2018 kl. 20:13 skrev Phil Race : As far as I know the split was made to dynamically load

Re: [OpenJDK 2D-Dev] RFR: Bug Pending: Build fails to compile jchuff.c

cc'ing Tom directly in case this fell into a digest. > I've reviewed it. The change looks good, it's a good programming practice while loop now :-) > Cheers > Andrew > > Andrew Leonard > Java Runtimes Development > IBM Hursley > IBM United Kingdom Ltd > Phone internal: 245913, external: 01962

[OpenJDK 2D-Dev] RFR: Bug Pending: Build fails to compile jchuff.c

I've reviewed it. The change looks good, it's a good programming practice while loop now :-) Cheers Andrew Andrew Leonard Java Runtimes Development IBM Hursley IBM United Kingdom Ltd Phone internal: 245913, external: 01962 815913 internet email: andrew_m_leon...@uk.ibm.com Unless stated

Re: [OpenJDK 2D-Dev] RFR: JDK-8071469 Cleanup include and exclude of sound native libraries after source code restructure

On 2018-03-16 17:49, Alex Menkov wrote: On 03/15/2018 13:09, Magnus Ihse Bursie wrote: 15 mars 2018 kl. 20:13 skrev Phil Race : As far as I know the split was made to dynamically load ALSA/DirectSound stuff Yes, I think it is something like that for Linux ie if

Re: [OpenJDK 2D-Dev] RFR: Bug Pending: Build fails to compile jchuff.c

Hi Tom, Much obliged. :) Any volunteers to be the 2nd reviewer? Best Regards Adam Farley > Hi Adam, > > this patch looks good. I can sponsor this for you if noone else steps up, but we need a second reviewer, preferably one from the 2d project. > > Best Regards, Thomas > > On Wed, Mar 21,

Re: [OpenJDK 2D-Dev] RFR: Bug Pending: Build fails to compile jchuff.c

Hi Adam, this patch looks good. I can sponsor this for you if noone else steps up, but we need a second reviewer, preferably one from the 2d project. Best Regards, Thomas On Wed, Mar 21, 2018 at 12:41 PM, Adam Farley8 wrote: > Hi All, > > If committers really don't

[OpenJDK 2D-Dev] RFR: Bug Pending: Build fails to compile jchuff.c

Hi All, If committers really don't want this code, we could always try fixing the code that the warning is complaining about. -- Change --- diff --git a/src/java.desktop/share/native/libjavajpeg/jchuff.c

Re: [OpenJDK 2D-Dev] [11] RFR JDK-7031957: DIB header of type BITMAPV2INFOHEADER & BITMAPV3INFOHEADER is not supported in BMPImageReader

Hi Prahalad, Thank you for reviewing the change. Yes we don't have any official Microsoft documentation today for BITMAPV2INFOHEADER & BITMAPV3INFOHEADER. We have only references to these undocumented DIB header types in http://fileformats.archiveteam.org/wiki/BMP ,

Re: [OpenJDK 2D-Dev] [11] RFR JDK-7031957: DIB header of type BITMAPV2INFOHEADER & BITMAPV3INFOHEADER is not supported in BMPImageReader

Hello Jay Good day to you. I looked into the code changes and they look good. Appreciate the links that you have posted on JBS. I see that - the only reference material on Bitmap V2/V3 Info Header header exists on Adobe Forums (https://forums.adobe.com/message/3272950#3272950) I could not