Hi,
Sorry to insist but I would like to get feedback on this Marlin patch soon
before going forward on tile-size tuning in java2d accelerated pipelines.
Laurent
2018-03-21 22:56 GMT+01:00 Laurent Bourgès :
> Hi,
>
> Here is the updated webrev:
> http://cr.openjdk.java.net/~lbourges/marlin/marli
On 2018-03-23 19:01, Phil Race wrote:
http://cr.openjdk.java.net/~ihse/JDK-8200178-remove-mapfiles/webrev.01/src/java.desktop/share/native/libmlib_image/mlib_image_proto.h.udiff.html
The variable definitions here are now misaligned.
No, they are not. That's just an artifact of webrev, which
Hi, Prahalad.
A few small comments about the test:
- Is it possible to test all installed ImageWriterSpi? It seems that
the test itself is not a JPEG plugin specific?
- You will need to dispose the jpgWriter even in case of exception.
On 23/03/2018 01:10, Prahalad Kumar Narayanan wrote:
Kin
http://cr.openjdk.java.net/~ihse/JDK-8200178-remove-mapfiles/webrev.01/src/java.desktop/share/native/libmlib_image/mlib_image_proto.h.udiff.html
The variable definitions here are now misaligned.
..and added 2d-dev since many of these native changes are in 2d.
-phil.
On 03/23/2018 10:33 AM, Ph
Hi Prahalad,
Change looks fine.
Test case works properly before and after the code change.
Since we are touching getNumThumbnailsSupported() function and it is only
overridden in JPEGImageWriter we can add override annotation for the same.
Thanks,
Jay
-Original Message-
From: Prahalad
Hi Prahalad,
The changes look fine to me.
Thanks,
Krishna
-Original Message-
From: Prahalad Kumar Narayanan
Sent: Friday, March 23, 2018 1:40 PM
To: 2d-dev <2d-dev@openjdk.java.net>
Subject: [OpenJDK 2D-Dev] [11] RFR: [JDK-4954348]:
JPGWriter.getNumThumbnailsSupported does not return -
Hello Everyone
Good day to you.
Request your time to review a simple fix for the bug
Bug: JDK-4954348 (https://bugs.openjdk.java.net/browse/JDK-4954348)
Title: JPGWriter.getNumThumbnailsSupported does not return -1 when passing
null values
Root Cause:
. As per ImageWriter specificat
