Re: [OpenJDK 2D-Dev] [11] JDK-8153732: Windows remote printer changes do not reflect in lookupPrintServices()

I guess if (pollStr.equalsIgnoreCase("true")) { 70 pollServices = true; 71 } else if (pollStr.equalsIgnoreCase("false")) { 72 pollServices = false; 73 } can be written as if (pollStr.equalsIgnoreCase("false")) pollServices = false; as it is already defaulted to true. 78 * for polling PrintSer

Re: [OpenJDK 2D-Dev] [11] Review Request: 8202696 glyphs in textfield only shown when thai baht-character is added

We don't run the tests in a turkish locale, like we don't build in that locale, so it is not expected in general, so it was OK already, but this is still fine by me. -phil. On 6/21/18, 9:52 PM, Dipak Kumar wrote: Hi Naoto, Thanks for the review. I have incorporated your suggestion and please

Re: [OpenJDK 2D-Dev] [11] Review Request: 8202696 glyphs in textfield only shown when thai baht-character is added

Hi Naoto, Thanks for the review. I have incorporated your suggestion and please find the updated webrev at http://cr.openjdk.java.net/~dkumar/8202696/webrev.03/ . Request you to have a look at it again and let me know your comments. Thanks, Dipak -Original Message- From: Naoto Sato S

Re: [OpenJDK 2D-Dev] [11] JDK-8153732: Windows remote printer changes do not reflect in lookupPrintServices()

+1 from me. -phil. On 6/21/18, 9:33 PM, Shashidhara Veerabhadraiah wrote: Hi Phil, Thanks for your review. I have made your suggested changes and here is the updated webrev: http://cr.openjdk.java.net/~sveerabhadra/8153732/webrev.04/

Re: [OpenJDK 2D-Dev] [11] JDK-8153732: Windows remote printer changes do not reflect in lookupPrintServices()

Hi Phil, Thanks for your review. I have made your suggested changes and here is the updated webrev: http://cr.openjdk.java.net/~sveerabhadra/8153732/webrev.04/ Need one more review to commit this. Note: A network printer can be added via the 'Add a printer' under the 'Devices and Prin

Re: [OpenJDK 2D-Dev] [PATCH] support Mongolian and FVS(Mongolian Free Variation Selector)

Hi Phil. Thank you very much for advices. In Mongolian, particular char + char transform to another char. (similar as Arabic) Harfbuzz supports it by using Arabic shaper (including FVS). So this patch set Mongolian as complex to use Arabic shaper. I created TestMongolian.java and I posted t

Re: [OpenJDK 2D-Dev] [11] JDK-8153732: Windows remote printer changes do not reflect in lookupPrintServices()

I thought you were going to make the refresh time 4 minutes ? I don't see that it has to be the same on Windows as it was on Unix, if you say 4 minutes is a sensible value there .. and 4 mins will be less CPU wake up, so I'd back that (4 mins) ahead of 2 minutes as the default here. You still h

Re: [OpenJDK 2D-Dev] [11] JDK-8153732: Windows remote printer changes do not reflect in lookupPrintServices()

Hi Phil, Here is the new Webrev for changes you suggested. http://cr.openjdk.java.net/~sveerabhadra/8153732/webrev.03/ Thanks and regards, Shashi From: Phil Race Sent: Friday, June 22, 2018 1:02 AM To: Shashidhara Veerabhadraiah ; 2d-dev <2d-dev@openjdk.java.net> Subject: Re: [11] J

Re: [OpenJDK 2D-Dev] [11] JDK-8153732: Windows remote printer changes do not reflect in lookupPrintServices()

+ private static final long DELAY = 1000 * 60 * 4; // 4 min pooling I think we need a System Property that can control this. I suggest the name "sun.java2d.print.minRefreshTime" which is what we use on Unix. and similarly to there we should have "sun.java2d.print.polling" which is a boolean and

Re: [OpenJDK 2D-Dev] [11] JDK-8153732: Windows remote printer changes do not reflect in lookupPrintServices()

Hi Phil, Here is the new Webrev. I chose 4 mins because I think it takes around 2 mins to add a new network printer, hence I felt 4 mins is a good time. The windows *PrinterChangeNotifications* calls are a blocking function calls hence I could not add the remote printers monitor to the existing

Re: [OpenJDK 2D-Dev] [11] Review Request: 8202696 glyphs in textfield only shown when thai baht-character is added

Hi Dipak, Please use Locale.toLowerCase(Locale.ROOT) instead of no-arg toLowerCase(), as it could fail in tr locale (line 60 in the test case). Naoto On 6/18/18 12:29 AM, Dipak Kumar wrote: Hi Phil, I am able to make the test automated after incorporating your suggestion to limit the test

Re: [OpenJDK 2D-Dev] [PATCH] support Mongolian and FVS(Mongolian Free Variation Selector)

There is much discussion about the encoding of Mongolian- see https://www.unicode.org/L2/topical/mongolian/ Is this discussion taken into account? On Wed, Jun 20, 2018 at 10:28 AM Phil Race wrote: > It is not clear to me how this supports Free Variation Selectors for > Mongolian as claimed. >