Re: [OpenJDK 2D-Dev] RFR [12] Clipping problems with complex affine transforms: negative scaling factors or small scaling factors

2018-09-06 Thread Laurent Bourgès
Another reviewer, please ? Le jeu. 6 sept. 2018 à 18:59, Phil Race a écrit : > > > On 09/06/2018 12:31 AM, Laurent Bourgès wrote: > > Phil, > Thanks for your review. > > Le jeu. 6 sept. 2018 à 01:39, Philip Race a > écrit : > >> This looks good to me. >> I've run all our automated tests + done

Re: [OpenJDK 2D-Dev] RFR [12] Clipping problems with complex affine transforms: negative scaling factors or small scaling factors

2018-09-06 Thread Phil Race
On 09/06/2018 12:31 AM, Laurent Bourgès wrote: Phil, Thanks for your review. Le jeu. 6 sept. 2018 à 01:39, Philip Race > a écrit : This looks good to me. I've run all our automated tests + done some manual testing as well as building on all platform

Re: [OpenJDK 2D-Dev] RFR JDK-8209786: gcc 7.3 compiler errors on zLinux

2018-09-06 Thread Lindenmaier, Goetz
Yes, that's fine. I can sponsor it tomorrow. I'm not in the office today. Best regards, Goetz. > -Original Message- > From: Andrew Leonard > Sent: Donnerstag, 6. September 2018 12:29 > To: Magnus Ihse Bursie ; Lindenmaier, Goetz > > Cc: 2d-dev <2d-dev@openjdk.java.net>; Brian Burkha

Re: [OpenJDK 2D-Dev] RFR JDK-8209786: gcc 7.3 compiler errors on zLinux

2018-09-06 Thread Andrew Leonard
Thanks Magnus, Hi Goetz, we have agreement from both library owners, so I think we're good now? Thanks Andrew Andrew Leonard Java Runtimes Development IBM Hursley IBM United Kingdom Ltd Phone internal: 245913, external: 01962 815913 internet email: andrew_m_leon...@uk.ibm.com From: Magnus

Re: [OpenJDK 2D-Dev] RFR [12] Clipping problems with complex affine transforms: negative scaling factors or small scaling factors

2018-09-06 Thread Laurent Bourgès
Phil, Thanks for your review. Le jeu. 6 sept. 2018 à 01:39, Philip Race a écrit : > This looks good to me. > I've run all our automated tests + done some manual testing > as well as building on all platforms and reviewing the source changes. > Do you have more closed-source tests that could be