Looks fine.
On 16/11/2018 02:16, Jayathirth D V wrote:
Hi Sergey,
As discussed offline I did more analysis on whether we can use common variable to determine number
of bands. Since we have "outputSampleSize.length - 1" and "inputBands + 1" kind
of things.
Actually scale array will be used on
Looks fine.
On 15/11/2018 13:41, Phil Race wrote:
bug: http://cr.openjdk.java.net/~prr/8130264/
webrev: http://cr.openjdk.java.net/~prr/8130264/
Currently java launcher code embeds the name of the java.desktop module's
PrinterJob
implementation class for each platform in a system property whic
Looks good to me. Just some nits.
Can we split the long lines like this ? :-
#define contextAwareMetricsX(vx, vy) \
(FTFixedToFloat(context->transform.xx) * (vx) - \
FTFixedToFloat(context->transform.xy) * (vy))
and why "vx" and "vy", not just x and y ?
-phil.
On 11/10/18 8:53 AM, A
Hi,
Thanks for spotting this. But I'm not sure the conditions are right.
Don't we need to unconditionally remove FT_LOAD_RENDER if synthetic styles
are requested, regardless of the value of that flag ?
Perhaps we should not set FT_LOAD_RENDER upfront in which case we'll just call
it once
we are
Hi Phil,
Looks fine from the core-libs perspective.
Thanks, thanks for removing this cross module dependency.
Roger
On 11/15/2018 04:41 PM, Phil Race wrote:
bug: http://cr.openjdk.java.net/~prr/8130264/
webrev: http://cr.openjdk.java.net/~prr/8130264/
Currently java launcher code embeds the
Hello.
Could you review the fix ?
Issue:
Cannot use italic font style if the font has embeded bitmap.
Bug:https://bugs.openjdk.java.net/browse/JDK-8214002
Change: https://cr.openjdk.java.net/~itakiguchi/8214002/webrev.00/
It seems it's side-effect for:
8204929: Fonts with embedded bitmaps a
Whenever I have seen this before it is due to removing files from the
/tmp directory
that are still in use. That's an error on your end.
This mailing list is for developing the OpenJDK. Not support.
And the binary distribution you are using is one provided by Redhat.
-phil.
On 11/9/18 7:12 PM,
On 11/15/2018 05:06 PM, Volker Simonis wrote:
> can I please have a review for the following small change:
>
> http://cr.openjdk.java.net/~simonis/webrevs/2018/8213944/
*) I tested it on platform without libxrandr-dev installed, and configure
reported the failure
appopriately.
*) Indent looks o
Hello All,
Please review the following fix in JDK12:
Bug : https://bugs.openjdk.java.net/browse/JDK-8212875
Webrev : http://cr.openjdk.java.net/~jdv/8212875/webrev.00/
TIFF Technical Note #2 link is broken at many places in our code. I tried
finding replacement for broken link, unfo
On Thu, Nov 15, 2018 at 6:01 PM Philip Race wrote:
>
> PS I am not sure why xrandr headers would not be available for AIX.
> They are a standard part of the xdistribution.
>
I'm not an X11 guru, but as far as I understand, xrandr is an
extension and as such it doesn't have to be supported by ever
Hi Sergey,
As discussed offline I did more analysis on whether we can use common variable
to determine number of bands. Since we have "outputSampleSize.length - 1" and
"inputBands + 1" kind of things.
Actually scale array will be used on input data(ps[]), so we should use input
bands value to
On Thu, Nov 15, 2018 at 5:31 PM Aleksey Shipilev wrote:
>
> On 11/15/2018 05:06 PM, Volker Simonis wrote:
> > can I please have a review for the following small change:
> >
> > http://cr.openjdk.java.net/~simonis/webrevs/2018/8213944/
>
> *) I tested it on platform without libxrandr-dev installed,
On Thu, Nov 15, 2018 at 5:55 PM Philip Race wrote:
>
> Hmm. I don't like the ifdefs.
>
Mee too, but what else can we do, if there are no Xrandr headers
available on a platform?
Please see my answer to your other mail...
> Xrandr is a requirement for the build. If its not there at runtime
> that
13 matches
Mail list logo
