Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8212875: ftp: links for tiff/TTN2.draft.txt do not respond

2018-11-21 Thread Jayathirth D V
Hi Sergey, Thanks for the review. I was following ZLib like content in the table, but as you mentioned we can keep at least text mentioning that we need to look up stuff related to TIFF Technical Note #2. Also I have refined comment in BaselineTIFFTagSet. Please find updated webrev for

Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8212875: ftp: links for tiff/TTN2.draft.txt do not respond

2018-11-21 Thread Sergey Bylokhov
Hi, Jay. In a few places you changed the tables which contains 3 columns, and you actually drop the last column in the row. BTW why we cannot preserve some of the text like: "TIFF Technical Note 2" On 16/11/2018 03:31, Jayathirth D V wrote: Hello All, Please review the following fix in

Re: [OpenJDK 2D-Dev] Speed of drawPolyline on JDK11

2018-11-21 Thread Sergey Bylokhov
Hi, Laurent. I do not think that we should postpone it to the next version. Just send the changes when they are ready, if the review fails to take place at the right time, then the fix will be moved to the jdk13. On 20/11/2018 00:28, Laurent Bourgès wrote: As OpenJDK12 RDP1 is coming soon, I

Re: [OpenJDK 2D-Dev] RFR(XS): 8213944: Fix AIX build after the removal of Xrandr.h and add a configure check for it

2018-11-21 Thread Magnus Ihse Bursie
On 2018-11-20 19:13, Volker Simonis wrote: Thanks everybody for the reviews. If nobody raises a "Veto" (Phil?) I plan to push this fix tomorrow in its current form. I think this sounds reasonable. I've also run it through the submit repo and got an error on Windows for the test