Re: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print tests after JDK-8153732

2019-02-11 Thread Shashidhara Veerabhadraiah
Hi Phil, Here is the new Webrev fixing those comments: http://cr.openjdk.java.net/~sveerabhadra/8212202/webrev.06/ Thanks and regards, Shashi From: Philip Race Sent: Saturday, February 9, 2019 2:25 AM To: Shashidhara Veerabhadraiah Cc: Prasanta Sadhukhan ; 2d-dev@openjdk.java.net Sub

Re: [OpenJDK 2D-Dev] RFR: JDK-8218682 + JDK-8198411: [TEST_BUG] DashOffset fails in mach5 + Two java2d tests are unstable in mach5

2019-02-11 Thread Alexey Ivanov
Hi Phil, On 08/02/2019 21:02, Phil Race wrote: can you add @key headful to all these tests ? Yes, I can if you think it's required. However, I think we should keep them without @key headful so that they're run more regularly. BufferedImage can be used in headless environment. I think that

Re: [OpenJDK 2D-Dev] RFR: JDK-8218682 + JDK-8198411: [TEST_BUG] DashOffset fails in mach5 + Two java2d tests are unstable in mach5

2019-02-11 Thread Sergey Bylokhov
Hi, Alexey. On 11/02/2019 01:44, Alexey Ivanov wrote: Isn't isHeadless() used by jtreg itself? These tests seem to have failed only in Windows where there's no true headless environment. Recent versions of Windows Server allow installing the OS without support for desktop environment, it could

Re: [OpenJDK 2D-Dev] RFR: JDK-8218682 + JDK-8198411: [TEST_BUG] DashOffset fails in mach5 + Two java2d tests are unstable in mach5

2019-02-11 Thread Alexey Ivanov
Hi Sergey, On 11/02/2019 17:03, Sergey Bylokhov wrote: Hi, Alexey. On 11/02/2019 01:44, Alexey Ivanov wrote: Isn't isHeadless() used by jtreg itself? These tests seem to have failed only in Windows where there's no true headless environment. Recent versions of Windows Server allow installing

Re: [OpenJDK 2D-Dev] RFR: JDK-8218682 + JDK-8198411: [TEST_BUG] DashOffset fails in mach5 + Two java2d tests are unstable in mach5

2019-02-11 Thread Sergey Bylokhov
On 11/02/2019 09:28, Alexey Ivanov wrote: No, it does not look like it's possible directly. In the case of DashOffset, VolatileImage contains #F8F8F8 instead of #FF, #CC instead of #FF, #00CC00 instead of #00FF00. In other configurations, the colours could be different. BufferedImag

Re: [OpenJDK 2D-Dev] RFR: JDK-8218682 + JDK-8198411: [TEST_BUG] DashOffset fails in mach5 + Two java2d tests are unstable in mach5

2019-02-11 Thread Phil Race
On 2/11/19 1:44 AM, Alexey Ivanov wrote: Hi Phil, On 08/02/2019 21:02, Phil Race wrote: can you add @key headful to all these tests ? Yes, I can if you think it's required. Yes. I think it is required. However, I think we should keep them without @key headful so that they're run more

Re: [OpenJDK 2D-Dev] RFR: JDK-8218682 + JDK-8198411: [TEST_BUG] DashOffset fails in mach5 + Two java2d tests are unstable in mach5

2019-02-11 Thread Alexey Ivanov
On 11/02/2019 18:27, Sergey Bylokhov wrote: On 11/02/2019 09:28, Alexey Ivanov wrote: No, it does not look like it's possible directly. In the case of DashOffset, VolatileImage contains #F8F8F8 instead of #FF, #CC instead of #FF, #00CC00 instead of #00FF00. In other configuration

Re: [OpenJDK 2D-Dev] RFR: JDK-8218682 + JDK-8198411: [TEST_BUG] DashOffset fails in mach5 + Two java2d tests are unstable in mach5

2019-02-11 Thread Sergey Bylokhov
On 11/02/2019 10:41, Alexey Ivanov wrote: Let me experiment with this. Would it be acceptable if I submit a new CR to improve these tests? Ok, fine. -- Best regards, Sergey.