[OpenJDK 2D-Dev] RFR 8218854: FontMetrics.getMaxAdvance may be less than the maximum FontMetrics.charWidth

2019-02-12 Thread Martin Balao
Hi, I'd like to propose the following fix for "JDK-8218854: FontMetrics.getMaxAdvance may be less than the maximum FontMetrics.charWidth" [1]: * http://cr.openjdk.java.net/~mbalao/webrevs/8218854/8218854.webrev.00/ Can I have a review? Thanks, Martin.- -- [1] - https://bugs.openjdk.java.net/b

Re: [OpenJDK 2D-Dev] RFR: JDK-8218682 + JDK-8198411: [TEST_BUG] DashOffset fails in mach5 + Two java2d tests are unstable in mach5

2019-02-12 Thread Phil Race
+1 -phil. On 2/12/19 6:24 AM, Alexey Ivanov wrote: Hi Phil, On 11/02/2019 18:32, Phil Race wrote: On 2/11/19 1:44 AM, Alexey Ivanov wrote: Hi Phil, On 08/02/2019 21:02, Phil Race wrote: can you add @key headful to all these tests ? Yes, I can if you think it's required. Yes. I think

Re: [OpenJDK 2D-Dev] RFR: JDK-8218682 + JDK-8198411: [TEST_BUG] DashOffset fails in mach5 + Two java2d tests are unstable in mach5

2019-02-12 Thread Alexey Ivanov
Hi Phil, On 11/02/2019 18:32, Phil Race wrote: On 2/11/19 1:44 AM, Alexey Ivanov wrote: Hi Phil, On 08/02/2019 21:02, Phil Race wrote: can you add @key headful to all these tests ? Yes, I can if you think it's required. Yes. I think it is required. Please see the updated webrev: http:

Re: [OpenJDK 2D-Dev] RFR: JDK-8218682 + JDK-8198411: [TEST_BUG] DashOffset fails in mach5 + Two java2d tests are unstable in mach5

2019-02-12 Thread Alexey Ivanov
On 12/02/2019 02:14, Sergey Bylokhov wrote: On 11/02/2019 10:41, Alexey Ivanov wrote: Let me experiment with this. Would it be acceptable if I submit a new CR to improve these tests? Ok, fine. Submitted https://bugs.openjdk.java.net/browse/JDK-8218827 -- Regards, Alexey