Re: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print tests after JDK-8153732

2019-02-18 Thread Prasanta Sadhukhan
Hi Shashi, I think if the overhead can be fixed with a small change, we should do it as I think we need to keep the code optimized with whatever code is present now. If in future, if somebody changes the function order, like doCompare(prev..., curr..) to doCompare(curr..., prev..) [what you ar

[OpenJDK 2D-Dev] FW: RFR : 8218965: aix: support xlclang++ in the compiler detection

2019-02-18 Thread Baesken, Matthias
FYI -this change http://cr.openjdk.java.net/~mbaesken/webrevs/8218965.1/ includes a small harfbuzz fix by Martin as well ; he fixed it as well in the upstream harfbuzz project . Best regards, Matthias From: Magnus Ihse Bursie Sent: Montag, 18. Februar 2019 15:46 To: Doerr, Martin

Re: [OpenJDK 2D-Dev] FW: RFR : 8218965: aix: support xlclang++ in the compiler detection

2019-02-18 Thread Philip Race
Yes .. I see that ... https://github.com/harfbuzz/harfbuzz/commit/5c2bb1de8de31fecf0dae2ef905b896e42d39f1d .. looks ok .. although I soon need to upgrade harfbuzz in JDK and the current release of 2.3.1 doesn't have that change. If there's a hb release with it soon I can use that or I will try t