Thank you Prashanta. This bug(NPE) is already a regression for an earlier bug
and do not wish to cause one more in future for a poorly creation of the
function definition especially when it is not implied by the function
definition. That's my intent. The null check expression should not even tak
Hi, Andrey.
I found only one questionable place in the fix:
==
/**
* Returns an object created with id=key. If the object is not of
- * type type, this will throw an exception.
+ * that type, this will throw an exception.
*/
private Object lookup(Stri
Fine with me.
-phil.
On 2/19/19, 4:10 AM, Doerr, Martin wrote:
Hi Matthias,
build has passed with this version. I think you can ship it.
Best regards,
Martin
*From:*Baesken, Matthias
*Sent:* Dienstag, 19. Februar 2019 09:57
*To:* Philip Race
*Cc:* 2d-dev@openjdk.java.net; Doerr, Martin
*
Sorry .. missed it.
One more thing about the test, I am not sure why you need to use
sun.font.FontDesignMetrics directly ?
Isn't it enough to create a BufferedImage and get an appropriate
FRC and FM by setting the properties on the graphics for that ?
-phil.
On 2/19/19, 10:48 AM, Martin Balao w
Hi Phil,
Are we good to go with Webrev.01?
Thanks,
Martin.-
On 2/14/19 3:47 PM, Martin Balao wrote:
> Hi Phil,
>
> Thanks for your feedback.
>
> I proposed the font in the test case because it's licensed under GNU
> Affero General Public License, Version 3 (AGPL) with an exemption [2].
> My un
Hi Matthias,
build has passed with this version. I think you can ship it.
Best regards,
Martin
From: Baesken, Matthias
Sent: Dienstag, 19. Februar 2019 09:57
To: Philip Race
Cc: 2d-dev@openjdk.java.net; Doerr, Martin
Subject: RE: [OpenJDK 2D-Dev] FW: RFR : 8218965: aix: support xlclang++ in t
Hello.
I would like to contribute small patch to fix repeated words typos.
Andrey Turbanov
diff --git
a/src/java.desktop/macosx/classes/com/apple/laf/AquaInternalFrameManager.java
b/src/java.desktop/macosx/classes/com/apple/laf/AquaInternalFrameManager.java
index c2ce10b0e4a..ccd65105699 100644
Java can't find user installed fonts in Windows 10. Starting from Windows 10
Preview Build 17704 fonts are installed into the user's home folder by default,
and are listed in user's registry section. This is Microsoft blog post about
it:
"https://blogs.windows.com/windowsexperience/2018/06/27/a
New webrev with fixes: http://cr.openjdk.java.net/~dbatrak/8218914/webrev.02/
> On 15 Feb 2019, at 19:31, Phil Race wrote:
>
> > 8218914: Handle the case when fonts are installed into user registry key.
> > This is the default behaviour since Windows 10 1809.
>
> When you get to the point of
Hello, for some reason a “c” (__ibmxlc__) was in my last webrev that
does not belong there; the macro name is __ibmxl__:
118 #elif !defined(HB_NO_MT) && defined(_AIX) && (defined(__IBMCPP__) ||
defined(__ibmxl__))
New webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8218965.
10 matches
Mail list logo
