Re: [OpenJDK 2D-Dev] RFR 8218854: FontMetrics.getMaxAdvance may be less than the maximum FontMetrics.charWidth

2019-02-21 Thread Philip Race
Oh two other things. 1) The change should be pushed to jdk/client not jdk/jdk 2) If you are making changes anyway maybe enumerate the imports rather than wild-carding.. -phil. On 2/21/19, 5:47 PM, Philip Race wrote: I submitted a test job to see what it did on our test platforms : Solaris, W

Re: [OpenJDK 2D-Dev] RFR 8218854: FontMetrics.getMaxAdvance may be less than the maximum FontMetrics.charWidth

2019-02-21 Thread Philip Race
I submitted a test job to see what it did on our test platforms : Solaris, WIndows, Mac as well as Linux and I got lot of failures on Solaris .. 38 of them .. a sample below but not just for obscure fonts, it included Arial (in various styles), Arial Black, Arial Narrow ... They are all at char

Re: [OpenJDK 2D-Dev] RFR: JDK-8218682 + JDK-8198411: [TEST_BUG] DashOffset fails in mach5 + Two java2d tests are unstable in mach5

2019-02-21 Thread Sergey Bylokhov
On 21/02/2019 04:23, Alexey Ivanov wrote: Thank you, Sergey, for looking into this. I guess this case requires more investigation. At first sight, it does not look right, does it? Right, I am not sure that "IndexColorModel" is selected intentionally. -- Best regards, Sergey.

Re: [OpenJDK 2D-Dev] RFR 8218854: FontMetrics.getMaxAdvance may be less than the maximum FontMetrics.charWidth

2019-02-21 Thread Sergey Bylokhov
Hi, Martin. What exceptions do you expect below? I think any exception will means a bug in jdk, no? try { GraphicsEnvironment e = GraphicsEnvironment.getLocalGraphicsEnvironment(); fonts = e.getAllFonts(); } catch (Exception e) {} Even if

Re: [OpenJDK 2D-Dev] RFR 8218854: FontMetrics.getMaxAdvance may be less than the maximum FontMetrics.charWidth

2019-02-21 Thread Martin Balao
Hi Phil, On 2/19/19 10:34 PM, Philip Race wrote: > One more thing about the test, I am not sure why you need to use > sun.font.FontDesignMetrics directly ? > > Isn't it enough to create a BufferedImage and get an appropriate > FRC and FM by setting the properties on the graphics for that ? > Ye

Re: [OpenJDK 2D-Dev] RFR. Repeated words typos in java.desktop

2019-02-21 Thread Alexey Ivanov
On 20/02/2019 01:38, Sergey Bylokhov wrote: Hi, Andrey. I found only one questionable place in the fix: == /**   * Returns an object created with id=key. If the object is not of - * type type, this will throw an exception. + * that type, this will throw an except

Re: [OpenJDK 2D-Dev] RFR: JDK-8218682 + JDK-8198411: [TEST_BUG] DashOffset fails in mach5 + Two java2d tests are unstable in mach5

2019-02-21 Thread Alexey Ivanov
On 14/02/2019 22:39, Sergey Bylokhov wrote: On 14/02/2019 13:02, Alexey Ivanov wrote: BTW do we sure that the usage of IndexColorModel is not a bug? I don't think it's a bug. Likely Windows Server OS is installed in Server Code mode which has limited GUI support. I was able to get IndexColo

Re: [OpenJDK 2D-Dev] RFR. Repeated words typos in java.desktop

2019-02-21 Thread Alexey Ivanov
Hi Andrey, src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKLookAndFeel.java /*   * Used to override if system (desktop) text anti-aliasing settings should - * be used. The reasons for this are are is that currently its "off" + * be used. The reasons for this are i