Re: [OpenJDK 2D-Dev] RFR 8218854: FontMetrics.getMaxAdvance may be less than the maximum FontMetrics.charWidth

Hi, Here we have Webrev.03: * http://cr.openjdk.java.net/~mbalao/webrevs/8218854/8218854.webrev.03/ * http://cr.openjdk.java.net/~mbalao/webrevs/8218854/8218854.webrev.03.zip Changes: * Test moved to test/jdk/java/awt/FontMetrics * Test imports are now explicit * getAllFonts NPE handled

Re: [OpenJDK 2D-Dev] RFR(XS): 8219675: Disable harfbuzz warnings with gcc 8

Erik/Phil, thanks for the reviews. Change pushed! I also filed https://bugs.openjdk.java.net/browse/JDK-8219676 to cover re-enabling the warnings (effectively reverting this change) once harfbuzz has been upgraded. Cheers, Mikael > On Feb 25,

Re: [OpenJDK 2D-Dev] RFR(XS): 8219675: Disable harfbuzz warnings with gcc 8

Looks good. /Erik On 2019-02-25 13:28, Mikael Vidstedt wrote: Please review this change which (temporarily) disables two gcc warnings which are triggered by the harfbuzz code. JBS: https://bugs.openjdk.java.net/browse/JDK-8219675 webrev: htt

Re: [OpenJDK 2D-Dev] RFR(XS): 8219675: Disable harfbuzz warnings with gcc 8

Looks fine to me so long as the build is happy. -phil. On 2/25/19 1:28 PM, Mikael Vidstedt wrote: Please review this change which (temporarily) disables two gcc warnings which are triggered by the harfbuzz code. JBS: https://bugs.openjdk.java.net/browse/JDK-8219675 webrev: http://cr.openjd

[OpenJDK 2D-Dev] RFR(XS): 8219675: Disable harfbuzz warnings with gcc 8

Please review this change which (temporarily) disables two gcc warnings which are triggered by the harfbuzz code. JBS: https://bugs.openjdk.java.net/browse/JDK-8219675 webrev: http://cr.openjdk.java.net/~mikael/webrevs/8219675/webrev.00/open/w