Re: [OpenJDK 2D-Dev] RFR: 8210782: Upgrade HarfBuzz to the latest 2.3.1

2019-03-01 Thread Sergey Bylokhov
Looks fine. On 28/02/2019 17:55, Philip Race wrote: Oh yes we should :-). Good catch. The license isn't changed so its a small matter of changing what version we list in the file. http://cr.openjdk.java.net/~prr/8210782.1 -phil. On 2/28/19, 4:58 PM, Sergey Bylokhov wrote: Hi, Phil. Should we

Re: [OpenJDK 2D-Dev] RFR: JDK-8218682 + JDK-8198411: [TEST_BUG] DashOffset fails in mach5 + Two java2d tests are unstable in mach5

2019-03-01 Thread Alexey Ivanov
On 21/02/2019 22:48, Sergey Bylokhov wrote: On 21/02/2019 04:23, Alexey Ivanov wrote: Thank you, Sergey, for looking into this. I guess this case requires more investigation. At first sight, it does not look right, does it? Right, I am not sure that "IndexColorModel" is selected intentionally

Re: [OpenJDK 2D-Dev] RFR 8218854: FontMetrics.getMaxAdvance may be less than the maximum FontMetrics.charWidth

2019-03-01 Thread Martin Balao
On 2/27/19 12:20 PM, Philip Race wrote: > The webrev still appears to be against jdk/jdk not jdk/client > > I had suggested excluding small point sizes since I don't think > the failures I saw can possibly be limited to Solaris ... it just > hasn't been reproduced elsewhere yet. Apologies for the

Re: [OpenJDK 2D-Dev] RFR: 8210782: Upgrade HarfBuzz to the latest 2.3.1

2019-03-01 Thread Erik Joelsson
Build changes look good. /Erik On 2019-02-28 16:12, Philip Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8210782 Webrev: http://cr.openjdk.java.net/~prr/8210782/ This change upgrades JDK 13 from using harfbuzz v 1.8.1 to v 2.3.1 which is currently the latest release of harfbuzz

Re: [OpenJDK 2D-Dev] RFR: 8210782: Upgrade HarfBuzz to the latest 2.3.1

2019-03-01 Thread Magnus Ihse Bursie
On 2019-03-01 01:12, Philip Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8210782 Webrev: http://cr.openjdk.java.net/~prr/8210782/ Looks good from a build PoV. /Magnus This change upgrades JDK 13 from using harfbuzz v 1.8.1 to v 2.3.1 which is currently the latest release of har