Re: [OpenJDK 2D-Dev] [PATCH] 8218914: Support fonts installed per-user on Windows 10

2019-03-12 Thread Mikhail Filippov
I looking for the second reviewer and sponsor for my font patch: http://cr.openjdk.java.net/~dbatrak/8218914/webrev.03/ -- Mikhail Filippov Software Developer JetBrains http://jetbrains.com “The Drive To Develop" > On 4 Mar 2019,

Re: [OpenJDK 2D-Dev] [PATCH] 8220231: Cache HarfBuzz face object for same font's text layout calls

2019-03-12 Thread Eirik Bakke
Thanks for running the benchmark! I suspect your patch removed some of the "startup" portion of the cost that was previously associated with a call to layoutGlyphVector or LineBreakMeasurer--that's a very good step in the right direction. -- Eirik From: Dmitry Batrak Sent: Tuesday, March 12,

Re: [OpenJDK 2D-Dev] Fonts with embedded bitmaps are not always rotated

2019-03-12 Thread Philip Race
Hi, 1) Issues are NOT re-opened to be backported. That is not how JBS works 2) The issue is not in Oracle JDK 8, it is only in OpenJDK 8. So long as you use Oracle JDK 8 you should not be seeing this. 3) This is not a bug report or support alias. Problems with a binary product should be sent to w

Re: [OpenJDK 2D-Dev] RFR 8218854: FontMetrics.getMaxAdvance may be less than the maximum FontMetrics.charWidth

2019-03-12 Thread Martin Balao
On 3/10/19 4:07 AM, Philip Race wrote: > +1 (approved) > > -phil. > Pushed to client [1]. Thanks! -- [1] - http://hg.openjdk.java.net/jdk/client/rev/0804f29e8be7

[OpenJDK 2D-Dev] Fonts with embedded bitmaps are not always rotated

2019-03-12 Thread Mitsuhiro Yamamoto
Hi there, I found the bug "Fonts with embedded bitmaps are not always rotated" in Java8. It seems that this bug is fixed for Java11. ( https://bugs.openjdk.java.net/browse/JDK-8204929) There was the issue on this bug in Java8. But it is closed as duplicated. ( https://bugs.openjdk.java.net/browse/J

Re: [OpenJDK 2D-Dev] RFR(S): 8214343: Handle the absence of Xrandr more generically

2019-03-12 Thread Volker Simonis
On Tue, Mar 12, 2019 at 5:38 AM Sergey Bylokhov wrote: > > Hi, Volker. > > On 27/11/2018 05:52, Volker Simonis wrote: > > Change JDK-8213944 fixed the build on AIX (which has no Xrandr) by > > conditionally excluding the relevant parts on AIX with the help of > > preprocessor defines. On the maili

Re: [OpenJDK 2D-Dev] [PATCH] 8220231: Cache HarfBuzz face object for same font's text layout calls

2019-03-12 Thread Dmitry Batrak
> I wonder if this patch might also fix or improve https://bugs.openjdk.java.net/browse/JDK-8202131 ? In case it's of any use, I have a ready-made performance test for this at https://gist.github.com/eirikbakke/81eec72221c9d7d8fc0b4afa9c54a163 . The proposed change improves the result of your perfo

Re: [OpenJDK 2D-Dev] [PATCH] 8220231: Cache HarfBuzz face object for same font's text layout calls

2019-03-12 Thread Dmitry Batrak
> This looks good to me, if I understand correctly that we now create > the face on first use and cache it fin Java or as long as the Font2D is > alive. > And the JNIEnv is always found on That's correct. The assumption is that HarfBuzz doesn't create its own threads, so HarfBuzz-related native co