Hi,
(Ignore the previous mail received with less info)
Observations:
I went through different FontConfiguration & FontManager implementations and I
see that in case of fontConfig(linux) only we are encoding/decoding
CompositeFonts in a unique way(In case of font config we override
get2DComposi
Thank you, Sergey and Phil, for your review!
--
Alexey
On 08/04/2019 22:21, Phil Race wrote:
+1
-phil.
On 4/8/2019 12:14 PM, Sergey Bylokhov wrote:
On 08/04/2019 03:14, Alexey Ivanov wrote:
Exactly! I would've done it if it had been possible.
Changing the minRefreshTime requires changes to
+1
-phil.
On 4/8/2019 12:14 PM, Sergey Bylokhov wrote:
On 08/04/2019 03:14, Alexey Ivanov wrote:
Exactly! I would've done it if it had been possible.
Changing the minRefreshTime requires changes to both the
implementation and the test, so it's better to do it under separate
CR, I've submitt
Looks fine.
On 24/03/2019 12:18, Alexey Ivanov wrote:
Hi,
Please review the fix for jdk 13.
bug: https://bugs.openjdk.java.net/browse/JDK-8217707
webrev: http://cr.openjdk.java.net/~aivanov/8217707/webrev.0/
Description:
Splash screen functionality is broken in 32 bit Windows. It's because th
+1
On 01/04/2019 02:12, Alexey Ushakov wrote:
Looks good for me.
Best Regards,
Alexey
On Mon, Apr 1, 2019 at 10:46 AM Dmitry Batrak mailto:dmitry.bat...@jetbrains.com>> wrote:
> Sorry for the delay. I've now finished verifying this and it is a +1
from me.
Thanks!
Anyone else, p
On 08/04/2019 03:14, Alexey Ivanov wrote:
Exactly! I would've done it if it had been possible.
Changing the minRefreshTime requires changes to both the implementation and the
test, so it's better to do it under separate CR, I've submitted one:
https://bugs.openjdk.java.net/browse/JDK-8222108
y
On 05/04/2019 23:32, Sergey Bylokhov wrote:
On 05/04/2019 15:30, Sergey Bylokhov wrote:
On 03/04/2019 09:35, Alexey Ivanov wrote:
We can make minRefreshTime equal to 2 minutes but leave the default
refresh time of 4 minutes. Does it sound good? This way the time of
waiting for two refresh cycl
A second reviewer is still required.
Best regards,
Dmitry Batrak.
On Mon, Apr 1, 2019 at 10:44 AM Dmitry Batrak
wrote:
> > Sorry for the delay. I've now finished verifying this and it is a +1
> from me.
> Thanks!
>
> Anyone else, please? A second reviewer is required.
>
> On Mon, Mar 25, 2019 a
