Re: [OpenJDK 2D-Dev] [13] RFR JDK-8225368:broken links in java.desktop files

2019-06-07 Thread Sergey Bylokhov
Looks fine. On 07/06/2019 01:08, Prasanta Sadhukhan wrote: Modified webrev http://cr.openjdk.java.net/~psadhukhan/8225368/webrev.1/ to use @link for cases where it points to public class/API.  For Font/FontMetrics/DocFlavor, the link was pointing to some heading and not to any API, where @lin

Re: [OpenJDK 2D-Dev] [13] Review Request: 8224171 The cleanup multi-font related code in the XFontPeer

2019-06-07 Thread Semyon Sadetsky
I don't know how timely it is to cleanup this code. Anyway, you've removed global awtJNI_GetFontData() function but left its external declaration in open/src/java.desktop/unix/native/common/awt/awt_p.h: http://hg.openjdk.java.net/jdk/client/file/f680bedc0dcb/src/java.desktop/unix/native/common/

Re: [OpenJDK 2D-Dev] [13] Review Request: 8224171 The cleanup multi-font related code in the XFontPeer

2019-06-07 Thread Phil Race
Looks OK. I checked https://docs.oracle.com/en/java/javase/12/intl/font-configuration-files.html and I don't think it invalidates anything in there. We already removed references to the motif support which used to be there : https://docs.oracle.com/javase/8/docs/technotes/guides/intl/fontconfi

Re: [OpenJDK 2D-Dev] [13] RFR JDK-8225368:broken links in java.desktop files

2019-06-07 Thread Prasanta Sadhukhan
Modified webrev http://cr.openjdk.java.net/~psadhukhan/8225368/webrev.1/ to use @link for cases where it points to public class/API.  For Font/FontMetrics/DocFlavor, the link was pointing to some heading and not to any API, where @link was not working so kept for those cases. Regards Prasan