Re: [OpenJDK 2D-Dev] [14] Review Request: 8229810 NullPointerException getting bounds of GraphicsConfiguration

2019-10-03 Thread Sergey Bylokhov
Hi, Jay. I think we should drive device update through GraphicsEnvironment.displayChanged() and DisplayChangeListener instead of force updating bounds in GraphicsDevice.displayChanged in the constructor. We can synchronise the GraphicsEnvironment.displayChanged() by calling it under

Re: [OpenJDK 2D-Dev] [14] RFR JDK-8223558: Java apps do not support Myanmar fonts

2019-10-03 Thread Alexey Ivanov
Hi Phil, Thank you for your review. Please see my answers inline: On 03/10/2019 17:31, Philip Race wrote: 1) This is an RFE, not a bug. I have updated the CR type to RFE. 2) Does this font exist on Windows 7 ? No, it does not. This font was added in Windows 8.

Re: [OpenJDK 2D-Dev] [14] RFR JDK-8223558: Java apps do not support Myanmar fonts

2019-10-03 Thread Philip Race
1) This is an RFE, not a bug. 2) Does this font exist on Windows 7 ? 3) This cannot be backported since the older JDK releases will not support it. -phil. On 10/3/19, 8:57 AM, Alexey Ivanov wrote: Any volunteers to review? On 25/09/2019 20:38, Alexey Ivanov wrote: Hello, Please review

Re: [OpenJDK 2D-Dev] [14] RFR JDK-8223558: Java apps do not support Myanmar fonts

2019-10-03 Thread Alexey Ivanov
Any volunteers to review? On 25/09/2019 20:38, Alexey Ivanov wrote: Hello, Please review the fix for JDK 14: bug: https://bugs.openjdk.java.net/browse/JDK-8223558 webrev: http://cr.openjdk.java.net/~aivanov/8223558/webrev.00/ Problem description: Java renders Myanmar script incorrectly. Some

Re: [OpenJDK 2D-Dev] [14] Review Request: 8228676 Cleanup the native code related to fonts on Unix

2019-10-03 Thread Jayathirth Rao
Changes are fine. Thanks, Jay > On 03-Oct-2019, at 11:10 AM, Sergey Bylokhov > wrote: > > Anyone? > > On 9/14/19 12:44 pm, Sergey Bylokhov wrote: >> Any volunteers to review=)? >> On 7/26/19 2:48 pm, Sergey Bylokhov wrote: >>> Hello. >>> Please review the fix for JDK 14. >>> >>> Bug:

Re: [OpenJDK 2D-Dev] [14] Review Request: 8229810 NullPointerException getting bounds of GraphicsConfiguration

2019-10-03 Thread Jayathirth Rao
Hi Sergey, I think we should drive device update through GraphicsEnvironment.displayChanged() and DisplayChangeListener instead of force updating bounds in GraphicsDevice.displayChanged in the constructor. We can synchronise the GraphicsEnvironment.displayChanged() by calling it under