Re: [OpenJDK 2D-Dev] RFR: 8233097: Fontmetrics for large Fonts has zero width

2019-11-03 Thread Jayathirth Rao
Changes are fine. Thanks, Jay > On 01-Nov-2019, at 1:29 AM, Sergey Bylokhov > wrote: > > Looks fine. > > On 10/30/19 11:37 am, Phil Race wrote: >> PS .. a positive from this is that with this fix the regression test >> runs about 10X faster than it did with say JDK 13 GA .. due to >> skipping

Re: [OpenJDK 2D-Dev] RFR: 8233097: Fontmetrics for large Fonts has zero width

2019-11-03 Thread Prasanta Sadhukhan
I believe 668 /* See the comments in getGlyphMetricsNative. They apply here too. */ should be getGlyphAdvanceNative Other than that, looks good to me. Regards Prasanta On 03-Nov-19 7:31 PM, Jayathirth Rao wrote: Changes are fine. Thanks, Jay On 01-Nov-2019, at 1:29 AM, Sergey Bylokhov wr