Re: [OpenJDK 2D-Dev] PING: RFR: 8220074: Clean up GCC 8.3 errors in LittleCMS

Thanks Phil! Yasumasa On 2019/11/19 11:43, Philip Race wrote: OK -phil. On 11/18/19, 5:34 PM, Yasumasa Suenaga wrote: PING: Could you review it?   JBS: https://bugs.openjdk.java.net/browse/JDK-8220074   webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8220074/webrev.01/ I think it is a t

Re: [OpenJDK 2D-Dev] PING: RFR: 8220074: Clean up GCC 8.3 errors in LittleCMS

OK -phil. On 11/18/19, 5:34 PM, Yasumasa Suenaga wrote: PING: Could you review it? JBS: https://bugs.openjdk.java.net/browse/JDK-8220074 webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8220074/webrev.01/ I think it is a trivial change. Yasumasa On 2019/11/13 11:42, Yasumasa Suenaga

[OpenJDK 2D-Dev] PING: RFR: 8220074: Clean up GCC 8.3 errors in LittleCMS

PING: Could you review it? JBS: https://bugs.openjdk.java.net/browse/JDK-8220074 webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8220074/webrev.01/ I think it is a trivial change. Yasumasa On 2019/11/13 11:42, Yasumasa Suenaga wrote: Thanks Erik! I uploaded new webrev, and it passed a

[OpenJDK 2D-Dev] PING: RFR (trivial): 8233707: systemScale.cpp could not compile with VS2019

PING: Could you review it? JBS: https://bugs.openjdk.java.net/browse/JDK-8233707 webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8233707/webrev.00/ I think it is a trivial change. Yasumasa On 2019/11/13 10:15, Yasumasa Suenaga wrote: Hi Alexey, Thank you for forwarding this RFR to 2

Re: [OpenJDK 2D-Dev] [PATCH] 8210058: Algorithmic Italic font leans opposite angle in Printing

Hi Dmitry, Thanks for the patch. I can sponsor this. I went through the change and it looks okay. But I have a concern about using specific values for matrix based on Freetype version for Oblique type. I have less idea about that maybe Phil or others can clarify the same. Regarding adding regr

[OpenJDK 2D-Dev] [14] Review Request: 8234325 Delete unused vsync related code from the OGL pipeline on macOS

Hello. Please review the fix for JDK 14. Bug: https://bugs.openjdk.java.net/browse/JDK-8234325 Fix: http://cr.openjdk.java.net/~serb/8234325/webrev.00 During developments of the early version of java FX, some code was added to the OGL and D3D pipelines to support vsync drawing. It is not accessi

Re: [OpenJDK 2D-Dev] [PATCH] 8210058: Algorithmic Italic font leans opposite angle in Printing

Hello, Still trying. Any volunteers to sponsor/review? Best regards, Dmitry Batrak On Tue, Nov 5, 2019 at 11:27 AM Dmitry Batrak wrote: > Hello, > > Let me repeat the request. > Any volunteers to sponsor/review? > > Best regards, > Dmitry Batrak > > -- Forwarded message - > Fro

[OpenJDK 2D-Dev] RFR: [XS] 8234323: NULL-check return value of SurfaceData_InitOps on macosx

Hello, please review this small macos related fix . In the java.desktop coding, at most usages of SurfaceData_InitOps the return value of the function is NULL-checked to avoid crashes in seldom cases where the function SurfaceData_InitOps returns NULL. However in the macos related coding t