Re: [OpenJDK 2D-Dev] Fix for 8235904 "Infinite loop when rendering huge lines"

2020-01-14 Thread Mario Torre
Thanks! Cheers, Mario On Tue 14. Jan 2020 at 22:58, Alexander Zuev wrote: > Hi Phil, Clemens, > >both code change and test looks fine to me. > > /Alex > > On 1/14/20 12:33, Phil Race wrote: > > Here's your webrev with a jtreg compliant test added : > > http://cr.openjdk.java.net/~prr/823590

Re: [OpenJDK 2D-Dev] Fix for 8235904 "Infinite loop when rendering huge lines"

2020-01-14 Thread Alexander Zuev
Hi Phil, Clemens,   both code change and test looks fine to me. /Alex On 1/14/20 12:33, Phil Race wrote: Here's your webrev with a jtreg compliant test added : http://cr.openjdk.java.net/~prr/8235904/ I verified the test behaves properly under jtreg -  before the fix jtreg kills it on time ou

Re: [OpenJDK 2D-Dev] Fix for 8235904 "Infinite loop when rendering huge lines"

2020-01-14 Thread Phil Race
Here's your webrev with a jtreg compliant test added : http://cr.openjdk.java.net/~prr/8235904/ I verified the test behaves properly under jtreg -  before the fix jtreg kills it on time out  after the fix it finishes quickly and successfully Outside of jtreg it also exits properly although jtreg

Re: [OpenJDK 2D-Dev] [PATCH] 8236996: Incorrect Roboto font rendering on Windows with subpixel antialiasing

2020-01-14 Thread Phil Race
Ok approved. Seems it is making a few things better if not ideal, but nothing worse. -phil. On 1/14/20 8:14 AM, Dmitry Batrak wrote: > So this is a workaround for a buggy font that doesn't play well with GDI ? This is a workaround for all cases (or the vast majority of them) of broken rende

Re: [OpenJDK 2D-Dev] [PATCH] 8236996: Incorrect Roboto font rendering on Windows with subpixel antialiasing

2020-01-14 Thread Dmitry Batrak
> So this is a workaround for a buggy font that doesn't play well with GDI ? This is a workaround for all cases (or the vast majority of them) of broken rendering reported by our customers. The case with Roboto is just the one we have steps to reproduce for. There can be other cases where GDI's lo