I hereby nominate Dmitry Batrak to JDK Committer.
Dmitry Batrak has contributed 8 significant fixes to Java 2D subsystem,
related to font rendering [3].
Votes are due by March 2, 2020.
Only current JDK Committers [1] are eligible to vote
on this nomination. Votes must be cast in the open by repl
Hi,
I did some cleanups in
src/java.desktop/share/classes/sun/font/SunFontManager.java and
src/java.desktop/share/classes/sun/font/TrueTypeFont.java which I’d like to
contribute.
Most is about indentation, generics initialization and better usage of
AccessController::doPrivileged and friends.
Vote: yes
On 17/02/2020 08:49, Anton Tarasov wrote:
I hereby nominate Dmitry Batrak to JDK Committer.
Dmitry Batrak has contributed 8 significant fixes to Java 2D subsystem,
related to font rendering [3].
--
Regards,
Alexey
Hi Mario,
thanks for looking into the patch (which has already reached jdk/jdk mainline,
btw).
> > I propose to fix this by adding a "NULL FONT HANDLE" to use in
> initialisedFonts for fonts that can’t be loaded. This will remove the
> recursion
> during loading of fonts. And afterwards a defau
On Mon, Feb 17, 2020 at 11:44 AM Langer, Christoph
wrote:
>
> Hi Mario,
>
> thanks for looking into the patch (which has already reached jdk/jdk
> mainline, btw).
>
> > > I propose to fix this by adding a "NULL FONT HANDLE" to use in
> > initialisedFonts for fonts that can’t be loaded. This will
Thank you, Sergey, for your review!
Any other volunteers?
On 06/02/2020 23:10, Sergey Bylokhov wrote:
Looks fine.
On 2/6/20 1:39 pm, Alexey Ivanov wrote:
Hello once again,
After trying a few things suggested by Sergey, I found serious issues
in the new approaches although the code looked a
Hi Mario,
> > I think that's better and more explicit compared to having a strange
> ClassCastException.
>
> Oh, yes, I agree it's a better message.
>
> Would they get this error during the font initialisation or at runtime
> during use? I think this is one could be an interesting change from
>
Thank you, Marc, for your contribution.
And thank you to Sergey for creating the review.
*Font2DTest.java*
674 if ( selectedText == fp.USER_TEXT )
675 userTextDialog.setVisible(true);
676 else
677 userTextDialog.setVisible(false);
I'd put the braces around and
Thanks Alexey for the detailed review! I attached a updated version.
The examples have many cleanup opportunities. I wanted to focus on compiler
warnings for now and keep the changeset minimal.
> *Font2DTest.java*
> 674 if ( selectedText == fp.USER_TEXT )
> 675 userTextDialog.
