[OpenJDK 2D-Dev] 8214481 is actually a regression?

2020-04-07 Thread Mario Torre
Hi Phil and all, I was working on backporting this to 11: https://bugs.openjdk.java.net/browse/JDK-8214481 When I realised this is actually a regression in that it makes rendering on OpenJDK worse in some cases. I've been testing with 8, 11, 13 and 15 and 11 patched and comparing those the font

Re: [OpenJDK 2D-Dev] RFR: 8241829 Cleanup the code for PrinterJob on windows

2020-04-07 Thread Alexey Ivanov
Hi Sergey, Looks good to me. Yet I don't quite understand the test. Does the test confirm, no print services are returned if a SecurityManager is installed? Regards, Alexey On 05/04/2020 02:40, Sergey Bylokhov wrote: Hello, Here is an updated patch: http://cr.openjdk.java.net/~serb/824182

Re: [OpenJDK 2D-Dev] RFR: 8241829 Cleanup the code for PrinterJob on windows

2020-04-07 Thread Sergey Bylokhov
On 4/7/20 1:40 pm, Alexey Ivanov wrote: Hi Sergey, Looks good to me. Yet I don't quite understand the test. Does the test confirm, no print services are returned if a SecurityManager is installed? Yes, I added it just to confirm my assumptions. Regards, Alexey On 05/04/2020 02:40, Serge

Re: [OpenJDK 2D-Dev] RFR: 8241829 Cleanup the code for PrinterJob on windows

2020-04-07 Thread Philip Race
Looks good. No way to test this now. Fingers crossed. phil. On 4/7/20, 2:49 PM, Sergey Bylokhov wrote: On 4/7/20 1:40 pm, Alexey Ivanov wrote: Hi Sergey, Looks good to me. Yet I don't quite understand the test. Does the test confirm, no print services are returned if a SecurityManager is in

Re: [OpenJDK 2D-Dev] RFR: 8223090: Clean up obsolete logic & reference to Amble fonts.

2020-04-07 Thread Prasanta Sadhukhan
Looks fine to me. Regards Prasanta On 05-Apr-20 11:08 PM, Philip Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8223090 Webrev : http://cr.openjdk.java.net/~prr/8223090/ Removing obsolete dead code - it no longer has relevance. The disableHinting flag was discarded by the callees any