Re: [OpenJDK 2D-Dev] RFR: 8242004: TextLayout throws Exception with a non-invertible transform

2020-04-09 Thread Jayathirth D v
Hi Phil, I went through all use cases captured in test case (TextLayout, draw). With updated change there is difference in behaviour between how we interpret non-invertible transform between TextLayout.draw() and draw() API’s. In case of TextLayout.draw() we are overriding non-invertible

Re: [OpenJDK 2D-Dev] RFR: 8242004: TextLayout throws Exception with a non-invertible transform

2020-04-09 Thread Philip Race
D**n copy/paste, yes you correctly inferred the webrev is at // ie : http://cr.openjdk.java.net/~prr/8242004/ -phil. On 4/9/20, 7:00 PM, Jayathirth D v wrote: Hi Phil, Please share webrev link, you have added JBS link for webrev. I went to path

Re: [OpenJDK 2D-Dev] RFR: 8242004: TextLayout throws Exception with a non-invertible transform

2020-04-09 Thread Jayathirth D v
Hi Phil, Please share webrev link, you have added JBS link for webrev. I went to path where you usually share webrev's and found http://cr.openjdk.java.net/~prr/8242004/ Thanks, Jay > On 10-Apr-2020, at 12:49 AM, Philip Race wrote: > > Any takers

Re: [OpenJDK 2D-Dev] RFR: 8242004: TextLayout throws Exception with a non-invertible transform

2020-04-09 Thread Philip Race
Any takers ? -phil On 4/3/20, 1:29 PM, Philip Race wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8242004 webrev: https://bugs.openjdk.java.net/browse/JDK-8242004 Several code paths can end up in the method shown in the bug report with a non-invertible transform. As much as possible, we

[OpenJDK 2D-Dev] RFR: 8241493 [macos] Swing PrintDialog attributes issues

2020-04-09 Thread Ichiroh Takiguchi
Hello. Could you review the fix ? Bug:https://bugs.openjdk.java.net/browse/JDK-8241493 Change: https://cr.openjdk.java.net/~itakiguchi/8241493/webrev.00/ JDK-8241493 [1] is related to Swing's print dialog, mainly macOS's CUPS. It may improve user interoperability. I appreciate your feedbac