[OpenJDK 2D-Dev] RFR: 8196181 sun/java2d/GdiRendering/InsetClipping.java fails

2020-04-13 Thread Sergey Bylokhov
Hello. Please review the fix for jdk/client. Bug: https://bugs.openjdk.java.net/browse/JDK-8196181 Fix: http://cr.openjdk.java.net/~serb/8196181/webrev.01 The test tries to take a color of the pixel near the frame's insets, exactly after the frame's decoration. The problem is that we cannot

[OpenJDK 2D-Dev] [15] RFR JDK-8195841: PNGImageReader.readNullTerminatedString() doesnt check for non-null terminated strings with length equal to maxLen

2020-04-13 Thread Jayathirth D v
Hello All, Please review the following fix for JDK 15: Bug : https://bugs.openjdk.java.net/browse/JDK-8195841 Webrev : http://cr.openjdk.java.net/~jdv/8195841/ Issue : PNGImageReader doesn’t check

Re: [OpenJDK 2D-Dev] RFR: 8242004: TextLayout throws Exception with a non-invertible transform

2020-04-13 Thread Jayathirth D v
Typo : It's good that we have removed *unused* inverseTx code. > On 13-Apr-2020, at 11:33 AM, Jayathirth D v wrote: > > Hi Phil, > > Thanks for the clarification. > It's good that we have removed used inverseTx code. > > Since we don’t have inverseTx check now, do we need to explicitly return

Re: [OpenJDK 2D-Dev] RFR: 8242004: TextLayout throws Exception with a non-invertible transform

2020-04-13 Thread Jayathirth D v
Hi Phil, Thanks for the clarification. It's good that we have removed used inverseTx code. Since we don’t have inverseTx check now, do we need to explicitly return from draw() when we have non invertible transform. I think we are making this somewhat specified in case of draw() API’s by