Re: [OpenJDK 2D-Dev] [15] RFR JDK-8242557: Add length limit for strings in PNGImageWriter

Update: “no limit on language tag” ---> “80 character limit on language tag”. > On 27-Apr-2020, at 11:15 PM, Jayathirth D v wrote: > > Hi Phil, > > Thanks for your approval. > I also noticed no limit on language tag in reader for iTXt and raised > JDK-8243674

Re: [OpenJDK 2D-Dev] [15] RFR JDK-8242557: Add length limit for strings in PNGImageWriter

Hi Phil, Thanks for your approval. I also noticed no limit on language tag in reader for iTXt and raised JDK-8243674 before sending this review. It's on my todo list but not on high priority. Regards, Jay > On 27-Apr-2020, at 10:51 PM,

Re: [OpenJDK 2D-Dev] [15] RFR JDK-8242557: Add length limit for strings in PNGImageWriter

I reviewed http://www.libpng.org/pub/png/spec/1.2/PNG-Chunks.html and I think you covered all the cases. I also reviewed the reader and it seems we already check only up to 80 chars there. I note we assume the same max length of 80 for the language tag for iTxt. The spec. doesn't specify a

[OpenJDK 2D-Dev] [15] RFR JDK-8242557: Add length limit for strings in PNGImageWriter

Hello All, Please review the following fix for JDK 15: Bug : https://bugs.openjdk.java.net/browse/JDK-8242557 Webrev : http://cr.openjdk.java.net/~jdv/8242557/webrev.00/ Issue : PNG

Re: [OpenJDK 2D-Dev] RFR: 8197797: Test java/awt/Graphics2D/DrawString/RotTransText.java fails

Thanks for the archaeology. It means that on Windows this probably was caused by freetype being used and in b17 there was a specific fix for rotation https://bugs.openjdk.java.net/browse/JDK-8203485 -phil. On 4/26/20, 9:23 PM, Prasanta Sadhukhan wrote: It seems in my windows 10 system, the test