Re: [OpenJDK 2D-Dev] RFR: 8171303 sun/java2d/pipe/InterpolationQualityTest.java fails on Windows & Linux

2020-08-25 Thread Sergey Bylokhov
On 25.08.2020 14:59, Philip Race wrote: This is fine but 1) I like to see the bug under which you fixed it in the @bug list. It is not a product bug and the test isn't reworked, so it is not necessary to have this test fix in the list of bugs 2) I am not sure I see how all the various reason

Re: [OpenJDK 2D-Dev] RFR: 8251854 [macosx] Java forces the use of discrete GPU

2020-08-25 Thread Sergey Bylokhov
On 25.08.2020 16:25, Philip Race wrote: On 8/25/20, 4:01 PM, Sergey Bylokhov wrote: It is applied if the "automatic graphics switching" is enabled, if the user disables this feature for the "power adapter" mode, then the discrete graphics will be always used. That's a bit misleading If I

Re: [OpenJDK 2D-Dev] RFR: 8251854 [macosx] Java forces the use of discrete GPU

2020-08-25 Thread Philip Race
On 8/25/20, 4:01 PM, Sergey Bylokhov wrote: It is applied if the "automatic graphics switching" is enabled, if the user disables this feature for the "power adapter" mode, then the discrete graphics will be always used. That's a bit misleading If I disable automatic graphics switching it

Re: [OpenJDK 2D-Dev] RFR: 8251854 [macosx] Java forces the use of discrete GPU

2020-08-25 Thread Kevin Rushforth
On 8/25/2020 4:17 PM, Sergey Bylokhov wrote: On 25.08.2020 16:08, Kevin Rushforth wrote: I haven't tested an FX app yet, but since this changes the plist properties, I want to see whether or not FX apps are impacted. It should be affected because the first variation of the fix was pushed t

Re: [OpenJDK 2D-Dev] RFR: 8251854 [macosx] Java forces the use of discrete GPU

2020-08-25 Thread Sergey Bylokhov
On 25.08.2020 16:08, Kevin Rushforth wrote: I haven't tested an FX app yet, but since this changes the plist properties, I want to see whether or not FX apps are impacted. It should be affected because the first variation of the fix was pushed to the FX(if nothing changed since then): https:/

Re: [OpenJDK 2D-Dev] RFR: 8251854 [macosx] Java forces the use of discrete GPU

2020-08-25 Thread Kevin Rushforth
This is how other applications work...  Also results are similar to other macbooks without discrete graphics. That's sort of what I was getting at with my earlier question: why have a discrete graphics card that never / seldom gets used? This may be more of a question for Apple, but it seem

Re: [OpenJDK 2D-Dev] RFR: 8251854 [macosx] Java forces the use of discrete GPU

2020-08-25 Thread Sergey Bylokhov
On 25.08.2020 15:40, Philip Race wrote: On 8/25/20, 12:27 PM, Sergey Bylokhov wrote: On 25.08.2020 05:43, Kevin Rushforth wrote: Does this only apply when the MacBook is running on battery, or will this affect performance even when the laptop is plugged in? If the latter, I wonder what Apple'

Re: [OpenJDK 2D-Dev] RFR: 8251854 [macosx] Java forces the use of discrete GPU

2020-08-25 Thread Philip Race
On 8/25/20, 12:27 PM, Sergey Bylokhov wrote: On 25.08.2020 05:43, Kevin Rushforth wrote: Does this only apply when the MacBook is running on battery, or will this affect performance even when the laptop is plugged in? If the latter, I wonder what Apple's rationale is for including a discrete

Re: [OpenJDK 2D-Dev] RFR: 8171303 sun/java2d/pipe/InterpolationQualityTest.java fails on Windows & Linux

2020-08-25 Thread Philip Race
This is fine but 1) I like to see the bug under which you fixed it in the @bug list. 2) I am not sure I see how all the various reasons for this test failing can be explained by this. -phil. On 8/25/20, 1:37 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk/client. Bug: https:/

[OpenJDK 2D-Dev] RFR: 8171303 sun/java2d/pipe/InterpolationQualityTest.java fails on Windows & Linux

2020-08-25 Thread Sergey Bylokhov
Hello. Please review the fix for jdk/client. Bug: https://bugs.openjdk.java.net/browse/JDK-8171303 Fix: http://cr.openjdk.java.net/~serb/8171303/webrev.00 This the only test which was created to check different types of interpolation. It checks the rendering to the VolatileImage and uses Buffere

Re: [OpenJDK 2D-Dev] RFR: 8251854 [macosx] Java forces the use of discrete GPU

2020-08-25 Thread Sergey Bylokhov
On 25.08.2020 05:43, Kevin Rushforth wrote: Does this only apply when the MacBook is running on battery, or will this affect performance even when the laptop is plugged in? If the latter, I wonder what Apple's rationale is for including a discrete graphics card that isn't used most of the time

Re: [OpenJDK 2D-Dev] RFR: 8251854 [macosx] Java forces the use of discrete GPU

2020-08-25 Thread Kevin Rushforth
Does this only apply when the MacBook is running on battery, or will this affect performance even when the laptop is plugged in? If the latter, I wonder what Apple's rationale is for including a discrete graphics card that isn't used most of the time. -- Kevin On 8/24/2020 11:27 PM, Sergey B