Re: [OpenJDK 2D-Dev] RFR: 8074844 : Resolve disabled warnings for libfontmanager

2020-08-27 Thread Erik Joelsson
Build change looks good. /Erik On 2020-08-27 12:39, Philip Race wrote: Bug : https://bugs.openjdk.java.net/browse/JDK-8074844 Webrev : http://cr.openjdk.java.net/~prr/8074844/index.html This resolves the disabled compiler warnings in what is now quite a small fontmanager library. I've

Re: [OpenJDK 2D-Dev] RFR: 8074844 : Resolve disabled warnings for libfontmanager

2020-08-27 Thread Philip Race
I left that alone on purpose. I have no way of testing it and whereas for the 32 bit linux case I had an idea of what to fix, for xlc all I could find was it came in with https://bugs.openjdk.java.net/browse/JDK-8154087 and I've no idea what the problems were. SAP or IBM can look at it if

Re: [OpenJDK 2D-Dev] RFR: 8074844 : Resolve disabled warnings for libfontmanager

2020-08-27 Thread Sergey Bylokhov
Hi, Phil. Probably we could enable WARNINGS_AS_ERRORS_xlc as well? I guess we will need a confirmation from the SAP gurus. On 27.08.2020 12:39, Philip Race wrote: Bug : https://bugs.openjdk.java.net/browse/JDK-8074844 Webrev : http://cr.openjdk.java.net/~prr/8074844/index.html This resolves

[OpenJDK 2D-Dev] RFR: 8074844 : Resolve disabled warnings for libfontmanager

2020-08-27 Thread Philip Race
Bug : https://bugs.openjdk.java.net/browse/JDK-8074844 Webrev : http://cr.openjdk.java.net/~prr/8074844/index.html This resolves the disabled compiler warnings in what is now quite a small fontmanager library. I've built windows, mac and linux in our build system and run our full battery of

Re: [OpenJDK 2D-Dev] RFR: 8234393 [macos] printing ignores printer tray

2020-08-27 Thread Philip Race
This looks reasonable but we need to test it first before approving it. -phil. On 8/27/20, 6:16 AM, Vipin Mv1 wrote: Hi, Please find below a patch for the following issue. https://bugs.openjdk.java.net/browse/JDK-8234393 http://cr.openjdk.java.net/~aleonard/8234393/webrev.00 Thanks&

Re: [OpenJDK 2D-Dev] RFR: 7183828 Invalid Image Variant when using anything other than BufferedImage

2020-08-27 Thread Sergey Bylokhov
Hi, Phil. Also now we have more checks for specific known image types. VolatileImage is an abstract class and I'm surprised that this is something this fix considers OK for subclasses to extend. Does that really work ? This is a good question I'll double-check that. You are right, we do not

[OpenJDK 2D-Dev] RFR: 8234393 [macos] printing ignores printer tray

2020-08-27 Thread Vipin Mv1
Hi, Please find below a patch for the following issue. https://bugs.openjdk.java.net/browse/JDK-8234393 http://cr.openjdk.java.net/~aleonard/8234393/webrev.00 Thanks & Regards Vipin MV