On 29.08.2020 17:39, Phil Race wrote:
Sergey,
The priority now is to flush outstanding review requests ahead of the skara
transition. I should have made that clearer in my email but I think new
requests such as this will need to wait. Especially anything that requires some
deep thought by a r
Sergey,
The priority now is to flush outstanding review requests ahead of the skara
transition. I should have made that clearer in my email but I think new
requests such as this will need to wait. Especially anything that requires some
deep thought by a reviewer as we have just one working day
Looks fine.
On 28.08.2020 07:42, Philip Race wrote:
Bug : https://bugs.openjdk.java.net/browse/JDK-8245400
Webrev : http://cr.openjdk.java.net/~prr/8245400/
A rotuine 3rd party library upgrade.
All platforms build + all tests pass.
-phil.
--
Best regards, Sergey.
Hello.
Please review the fix for jdk/client.
Bug: https://bugs.openjdk.java.net/browse/JDK-8252133
Fix: http://cr.openjdk.java.net/~serb/8252133/webrev.00
This bug easily reproduced by the test in question on the dual video card
systems
when the metal pipeline is active. But it is possible to r
On 29.08.2020 12:01, Philip Race wrote
I'm not sure I get the comment about the intersection operation causing
performance problems.
Are you referring to the cost of that intersection operation itself, or some
downstream consequence ?
Yes, I am talking about the cost of intersection itself.
I note that you change the signature of blitSurfaceData to private.
I think this is fine. Since it is only used in this class I imagine
whatever reason
it was supposed it might need to be over-ridden has never arisen ..
But I still had to first go check that it isn't actually used elsewhere !
PS, there's a test case in the bug. Seems like it could be used as the
basis for a manual regression test.
Make sure you use @requires printer as well as adding the manual and
headful keywords
and next you'll have to check for an installed printer with multiple trays
-phil
On 8/27/20, 11:36
