Re: [OpenJDK 2D-Dev] RFR: 8252817: Cleanup the classes in the java.awt.color package

2020-09-08 Thread Jayathirth D V
On Sat, 5 Sep 2020 21:32:42 GMT, Sergey Bylokhov wrote: > - Class declarations reformat > - Docs cleanup Looks good to me. - Marked as reviewed by jdv (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/22

Re: [OpenJDK 2D-Dev] RFR: 8171303: sun/java2d/pipe/InterpolationQualityTest.java fails on Windows & Linux

2020-09-08 Thread Phil Race
On Tue, 8 Sep 2020 21:54:43 GMT, Sergey Bylokhov wrote: > This the only test which was created to check different types of > interpolation. > It checks the rendering to the VolatileImage and uses BufferedImage as a gold > image. > But it does not take into account that rendering to the

[OpenJDK 2D-Dev] RFR: 8171303: sun/java2d/pipe/InterpolationQualityTest.java fails on Windows & Linux

2020-09-08 Thread Sergey Bylokhov
This the only test which was created to check different types of interpolation. It checks the rendering to the VolatileImage and uses BufferedImage as a gold image. But it does not take into account that rendering to the VolatileImage might be affected by the HiDPI support. Old review request:

[OpenJDK 2D-Dev] RFR: 7183828: Invalid Image Variant when using anything other than BufferedImage

2020-09-08 Thread Sergey Bylokhov
It is intended that our draw machinery works only on specific image formats that we know we support. But the user still able to create some image subclasses for their purpose and according to our spec of Graphics2D.drawImage() we should not throw any exceptions. I suggest handling this

Re: [OpenJDK 2D-Dev] RFR[8250855]: 'Address reliance on default constructors in the Java 2D APIs'

2020-09-08 Thread Conor Cleary
Hi everyone. Thanks for the feedback! Firstly, I changed the wording from 'Creates' to 'Constructs' as per Philip's suggestion (and corrected a spelling mistake). Secondly, for the protected constructors (in the abstract classes) I used the wording "Constructor for subclasses to call." as