> On Sep 25, 2020, at 1:49 AM, Kim Barrett wrote:
>
> On Thu, 24 Sep 2020 21:28:01 GMT, Paul Hohensee wrote:
>
>> Please review this small patch to enable the OSX build using Xcode 12.0.
>>
>> Thanks,
>> Paul
[I tried submitting this comment through the github UI and somehow managed to
lose
On Thu, 24 Sep 2020 21:28:01 GMT, Paul Hohensee wrote:
> Please review this small patch to enable the OSX build using Xcode 12.0.
>
> Thanks,
> Paul
src/java.desktop/macosx/native/libawt_lwawt/awt/CSystemColors.m line 129:
> 127: NSColor* result = nil;
> 128:
> 129: if (colorIndex < ((
On Thu, 24 Sep 2020 21:28:01 GMT, Paul Hohensee wrote:
> Please review this small patch to enable the OSX build using Xcode 12.0.
>
> Thanks,
> Paul
No, don't do this. In the original, double is used to obtain the desired
alignmnent. Changing the element type to short reduces the alignment
re
On Thu, 24 Sep 2020 16:38:50 GMT, Phil Race wrote:
> A long-standing bug on macOS: https://bugs.openjdk.java.net/browse/JDK-7179006
>
> The fix is to propagate whatever is set as the Destination down to native and
> set it on the native printing object.
>
> Also if using the native dialog, but
On Thu, 24 Sep 2020 16:38:50 GMT, Phil Race wrote:
> A long-standing bug on macOS: https://bugs.openjdk.java.net/browse/JDK-7179006
>
> The fix is to propagate whatever is set as the Destination down to native and
> set it on the native printing object.
>
> Also if using the native dialog, but
On Thu, 24 Sep 2020 21:28:01 GMT, Paul Hohensee wrote:
> Please review this small patch to enable the OSX build using Xcode 12.0.
>
> Thanks,
> Paul
Changes requested by dholmes (Reviewer).
src/hotspot/share/runtime/sharedRuntime.cpp line 2851:
> 2849: if (buf != NULL) {
> 2850: Cod
On Thu, 24 Sep 2020 16:38:50 GMT, Phil Race wrote:
> A long-standing bug on macOS: https://bugs.openjdk.java.net/browse/JDK-7179006
>
> The fix is to propagate whatever is set as the Destination down to native and
> set it on the native printing object.
>
> Also if using the native dialog, but
On Wed, 23 Sep 2020 07:03:59 GMT, Sergey Bylokhov wrote:
> Looks like different people use a different style for the new constructors,
> it will be good to unify them.
>
> The text "Constructor for subclasses to call." should be used in the
> protected constructors in the abstract classes
> In
On Thu, 24 Sep 2020 21:28:01 GMT, Paul Hohensee wrote:
> Please review this small patch to enable the OSX build using Xcode 12.0.
>
> Thanks,
> Paul
The awt change looks fine although it would be nice if you could paste the
compiler
error message into the bug report, since I'd like to see the
Please review this small patch to enable the OSX build using Xcode 12.0.
Thanks,
Paul
-
Commit messages:
- JDK-8253375
Changes: https://git.openjdk.java.net/jdk/pull/348/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=348&range=00
Issue: https://bugs.openjdk.java.net
The javadoc for this class was added, but the constructor itsef is missed..
-
Commit messages:
- Update SwingEventMonitor.java
Changes: https://git.openjdk.java.net/jdk/pull/340/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=340&range=00
Issue: https://bugs.openj
On Thu, 24 Sep 2020 16:38:50 GMT, Phil Race wrote:
> A long-standing bug on macOS: https://bugs.openjdk.java.net/browse/JDK-7179006
>
> The fix is to propagate whatever is set as the Destination down to native and
> set it on the native printing object.
>
> Also if using the native dialog, but
A long-standing bug on macOS: https://bugs.openjdk.java.net/browse/JDK-7179006
The fix is to propagate whatever is set as the Destination down to native and
set it on the native printing object.
Also if using the native dialog, but with attributes, copy back the destination
from native to the J
On Tue, 15 Sep 2020 10:04:49 GMT, Conor Cleary wrote:
> This issue relates to JDK-8250639 '☂ Address reliance on default constructors
> in the java.desktop module'. The
> following classes have had an explicit no-arg constructor added, with a
> protected access modifier and accompanying API
> d
On Mon, 14 Sep 2020 14:32:18 GMT, Conor Cleary wrote:
> This issue relates to JDK-8250639 '☂ Address reliance on default constructors
> in the java.desktop module'. The changes
> address the reliance on default constructors by adding in basic constructors
> in the following classes:
> - java.aw
Hi Philip,
Thanks for your time in getting back. I will pursue it further through github.
Thanks & regards
Vipin MV
16 matches
Mail list logo
