[OpenJDK 2D-Dev] Integrated: 7179006: [macosx] Print-to-file doesn't work: printing to the default printer instead.

2020-09-25 Thread Phil Race
On Thu, 24 Sep 2020 16:38:50 GMT, Phil Race wrote: > A long-standing bug on macOS: https://bugs.openjdk.java.net/browse/JDK-7179006 > > The fix is to propagate whatever is set as the Destination down to native and > set it on the native printing object. > > Also if using the native dialog, but

Re: [OpenJDK 2D-Dev] RFR: 7179006: [macosx] Print-to-file doesn't work: printing to the default printer instead. [v3]

2020-09-25 Thread Sergey Bylokhov
On Fri, 25 Sep 2020 23:44:27 GMT, Phil Race wrote: >> A long-standing bug on macOS: >> https://bugs.openjdk.java.net/browse/JDK-7179006 >> >> The fix is to propagate whatever is set as the Destination down to native >> and set it on the native printing object. >> >> Also if using the native d

Re: [OpenJDK 2D-Dev] RFR: 7179006: [macosx] Print-to-file doesn't work: printing to the default printer instead.

2020-09-25 Thread Phil Race
On Thu, 24 Sep 2020 16:43:48 GMT, Phil Race wrote: >> A long-standing bug on macOS: >> https://bugs.openjdk.java.net/browse/JDK-7179006 >> >> The fix is to propagate whatever is set as the Destination down to native >> and set it on the native printing object. >> >> Also if using the native d

Re: [OpenJDK 2D-Dev] RFR: 7179006: [macosx] Print-to-file doesn't work: printing to the default printer instead. [v3]

2020-09-25 Thread Phil Race
> A long-standing bug on macOS: https://bugs.openjdk.java.net/browse/JDK-7179006 > > The fix is to propagate whatever is set as the Destination down to native and > set it on the native printing object. > > Also if using the native dialog, but with attributes, copy back the > destination from n

Re: [OpenJDK 2D-Dev] RFR: 7179006: [macosx] Print-to-file doesn't work: printing to the default printer instead. [v2]

2020-09-25 Thread Phil Race
On Fri, 25 Sep 2020 21:31:01 GMT, Sergey Bylokhov wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 7179006: [macosx] Print-to-file doesn't work: printing to the default >> printer instead. > > src/java.desktop/macosx/

[OpenJDK 2D-Dev] RFR: 8251123: doclint warnings about missing javadoc tags and comments

2020-09-25 Thread Sergey Bylokhov
We have a number of missing javadoc tags and comments in the desktop module. Most of the missing comments are related to the serialized form. The fix: - Adds missing comments to the non-static/non-transient fields(even private) of the "serializable" classes - Adds comments to the "serializabl

Re: [OpenJDK 2D-Dev] RFR: 7179006: [macosx] Print-to-file doesn't work: printing to the default printer instead. [v2]

2020-09-25 Thread Sergey Bylokhov
On Fri, 25 Sep 2020 18:47:40 GMT, Phil Race wrote: >> A long-standing bug on macOS: >> https://bugs.openjdk.java.net/browse/JDK-7179006 >> >> The fix is to propagate whatever is set as the Destination down to native >> and set it on the native printing object. >> >> Also if using the native d

Re: [OpenJDK 2D-Dev] RFR: 7179006: [macosx] Print-to-file doesn't work: printing to the default printer instead. [v2]

2020-09-25 Thread Phil Race
> A long-standing bug on macOS: https://bugs.openjdk.java.net/browse/JDK-7179006 > > The fix is to propagate whatever is set as the Destination down to native and > set it on the native printing object. > > Also if using the native dialog, but with attributes, copy back the > destination from n

Re: [OpenJDK 2D-Dev] RFR: 7179006: [macosx] Print-to-file doesn't work: printing to the default printer instead.

2020-09-25 Thread Phil Race
On Fri, 25 Sep 2020 04:57:48 GMT, Prasanta Sadhukhan wrote: >> A long-standing bug on macOS: >> https://bugs.openjdk.java.net/browse/JDK-7179006 >> >> The fix is to propagate whatever is set as the Destination down to native >> and set it on the native printing object. >> >> Also if using th

Re: [OpenJDK 2D-Dev] RFR: 7179006: [macosx] Print-to-file doesn't work: printing to the default printer instead.

2020-09-25 Thread Phil Race
On Fri, 25 Sep 2020 01:32:49 GMT, Sergey Bylokhov wrote: >> A long-standing bug on macOS: >> https://bugs.openjdk.java.net/browse/JDK-7179006 >> >> The fix is to propagate whatever is set as the Destination down to native >> and set it on the native printing object. >> >> Also if using the na

Re: [OpenJDK 2D-Dev] RFR: 8253375: OSX build fails with Xcode 12.0 (12A7209)

2020-09-25 Thread Kim Barrett
> On Sep 25, 2020, at 6:22 AM, Lutz Schmidt wrote: > > On Fri, 25 Sep 2020 05:46:08 GMT, Kim Barrett wrote: > > Another note, actually, it's more like a question: > Has anyone had an eye on what happens in initialize_shared_locs(relocInfo* > buf, int length)? To my understanding, > "buf", whic

Re: [OpenJDK 2D-Dev] RFR: 8253375: OSX build fails with Xcode 12.0 (12A7209)

2020-09-25 Thread Lutz Schmidt
On Fri, 25 Sep 2020 05:46:08 GMT, Kim Barrett wrote: >> Please review this small patch to enable the OSX build using Xcode 12.0. >> >> Thanks, >> Paul > > No, don't do this. In the original, double is used to obtain the desired > alignmnent. Changing the element type to short reduces the align

Re: [OpenJDK 2D-Dev] RFR: 8253375: OSX build fails with Xcode 12.0 (12A7209)

2020-09-25 Thread Kim Barrett
> On Sep 25, 2020, at 1:49 AM, Kim Barrett wrote: > > On Thu, 24 Sep 2020 21:28:01 GMT, Paul Hohensee wrote: > >> Please review this small patch to enable the OSX build using Xcode 12.0. >> >> Thanks, >> Paul > > […] > > I think changing the declaration for locs_buf to any of the following g