On Thu, 4 Feb 2021 01:56:57 GMT, Sergey Bylokhov wrote:
> Some broken data in the InputStream may cause the wrong exception to be
> thrown - ArrayIndexOutOfBoundsException instead of IllegalArgumentException,
> if the data is too small and we try to validate it.
This pull request has now been
On Thu, 4 Feb 2021 01:56:57 GMT, Sergey Bylokhov wrote:
> Some broken data in the InputStream may cause the wrong exception to be
> thrown - ArrayIndexOutOfBoundsException instead of IllegalArgumentException,
> if the data is too small and we try to validate it.
Marked as reviewed by psadhukha
On Wed, 3 Feb 2021 07:04:22 GMT, Prasanta Sadhukhan
wrote:
> Document setting null setColor similar to way setFont(null) is documented.
This pull request has now been integrated.
Changeset: 60f440de
Author:Prasanta Sadhukhan
URL: https://git.openjdk.java.net/jdk/commit/60f440de
Stat
> Method createStrokedShape(Shape) for java.awt.BasicStroke class throws
> NullPointerException when passed a null object reference for a input
> parameter but it's not specified in the spec.
> Updated spec to illustrate this.
Prasanta Sadhukhan has updated the pull request incrementally with on
On Thu, 4 Feb 2021 01:56:57 GMT, Sergey Bylokhov wrote:
> Some broken data in the InputStream may cause the wrong exception to be
> thrown - ArrayIndexOutOfBoundsException instead of IllegalArgumentException,
> if the data is too small and we try to validate it.
Marked as reviewed by azvegint
Some broken data in the InputStream may cause the wrong exception to be thrown
- ArrayIndexOutOfBoundsException instead of IllegalArgumentException, if the
data is too small and we try to validate it.
-
Commit messages:
- Initial fix
Changes: https://git.openjdk.java.net/jdk/pull/
On Fri, 29 Jan 2021 00:30:21 GMT, Phil Race wrote:
> This completes the desktop module JNF removal
>
> * remove -framework JavaNativeFoundation from make files
>
> * remove #import from all
> source files. If needed add import of JNIUtilities.h to get jni.h definitions
> - better anyway si
> This completes the desktop module JNF removal
>
> * remove -framework JavaNativeFoundation from make files
>
> * remove #import from all
> source files. If needed add import of JNIUtilities.h to get jni.h definitions
> - better anyway since then it gets the current JDK ones not the ones fr
On Tue, 2 Feb 2021 23:22:12 GMT, Phil Race wrote:
>> This completes the desktop module JNF removal
>>
>> * remove -framework JavaNativeFoundation from make files
>>
>> * remove #import from all
>> source files. If needed add import of JNIUtilities.h to get jni.h
>> definitions - better any
On Wed, 3 Feb 2021 23:50:16 GMT, Sergey Bylokhov wrote:
>> 8216358: [accessibility] [macos] The focus is invisible when tab to "Image
>> Radio Buttons" and "Image CheckBoxes"
>
> test/jdk/javax/swing/JCheckBox/ImageCheckboxFocus/ImageCheckboxTest.java line
> 68:
>
>> 66: public void perfor
On Wed, 3 Feb 2021 22:48:33 GMT, Gerard Ziemski wrote:
>> I don't like the idea of using masks on architectures that do not require
>> them. How about something like this?
>>
>> `#if defined(__APPLE__)`
>> ` // lldb (gdb) installs both standard BSD signal handlers, and mach
>> exception`
>> `
On Wed, 3 Feb 2021 22:44:18 GMT, Gerard Ziemski wrote:
>> Thanks for your questions Gerard.
>>
>>> Part of the comment said This work-around is not necessary for 10.5+, as
>>> CrashReporter no longer intercedes on caught fatal signals.
>>
>> That comment can probably be deleted since minversio
On Wed, 3 Feb 2021 18:50:34 GMT, Alexander Zuev wrote:
> 8216358: [accessibility] [macos] The focus is invisible when tab to "Image
> Radio Buttons" and "Image CheckBoxes"
test/jdk/javax/swing/JCheckBox/ImageCheckboxFocus/ImageCheckboxTest.java line
68:
> 66: public void performTest() thr
On Wed, 3 Feb 2021 23:13:12 GMT, Bernhard Urban-Forster
wrote:
>> No idea how to insert spaces and make text align :-(
>
> using ` ```c `
> https://docs.github.com/en/github/writing-on-github/creating-and-highlighting-code-blocks
>
> I was wrong about `SIGFPE` / `EXC_MASK_ARITHMETIC`, it's use
On Wed, 3 Feb 2021 22:17:02 GMT, Bernhard Urban-Forster
wrote:
>> To answer my own question, it seems that code is still needed on `x86_64`
>> for `lldb` with `EXC_MASK_BAD_ACCESS` or we keep tripping over
>> `EXC_BAD_ACCESS`
>>
>> Remaining questions:
>>
>> a) why we need `EXC_MASK_ARITHMET
On Wed, 3 Feb 2021 04:01:51 GMT, Sergey Bylokhov wrote:
> Trivial cleanup, the "default" license header is removed in a few components.
This pull request has now been integrated.
Changeset: f279ff9d
Author:Sergey Bylokhov
URL: https://git.openjdk.java.net/jdk/commit/f279ff9d
Stats:
On Wed, 3 Feb 2021 12:11:40 GMT, Prasanta Sadhukhan
wrote:
> Method createStrokedShape(Shape) for java.awt.BasicStroke class throws
> NullPointerException when passed a null object reference for a input
> parameter but it's not specified in the spec.
> Updated spec to illustrate this.
src/jav
On Wed, 3 Feb 2021 20:29:48 GMT, Gerard Ziemski wrote:
>> Part of the comment said `This work-around is not necessary for 10.5+, as
>> CrashReporter no longer intercedes on caught fatal signals.` so I thought it
>> was no longer needed, but it sounds like the part about `gdb` still applies
>>
On Wed, 3 Feb 2021 20:04:18 GMT, Gerard Ziemski wrote:
>> See comment above about `gdb`, the same applies to `lldb` today. The AArch64
>> backend uses `SIGILL` (~= `EXC_MASK_BAD_INSTRUCTION`) to initiate a
>> deoptimization. Without this change you cannot continue debugging once you
>> the deb
On Wed, 3 Feb 2021 09:14:24 GMT, Andrew Haley wrote:
>> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 5271:
>>
>>> 5269: //
>>> 5270: void MacroAssembler::get_thread(Register dst) {
>>> 5271: RegSet saved_regs = RegSet::range(r0, r1) +
>>> BSD_ONLY(RegSet::range(r2, r17)) + lr - dst
On Tue, 2 Feb 2021 23:03:45 GMT, Daniel D. Daugherty wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/share/runtime/thread.cpp line 3991:
>
>> 3989: JavaThread*
On Tue, 2 Feb 2021 18:00:06 GMT, Gerard Ziemski wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/cpu/aarch64/interpreterRT_aarch64.cpp line 390:
>
>> 388: store_
On Tue, 26 Jan 2021 12:50:22 GMT, Anton Kozlov wrote:
>> Yes, that's why I thought it should be added to the classes
>> ThreadInVMfromNative, etc like:
>> class ThreadInVMfromNative : public ThreadStateTransition {
>> ResetNoHandleMark __rnhm;
>>
>> We can look at it with cleaning up the thre
On Tue, 2 Feb 2021 19:23:16 GMT, Bernhard Urban-Forster
wrote:
>> src/hotspot/os/posix/signals_posix.cpp line 1297:
>>
>>> 1295: kern_return_t kr;
>>> 1296: kr = task_set_exception_ports(mach_task_self(),
>>> 1297: EXC_MASK_BAD_ACCESS |
>>> EXC_MASK_BAD_INST
On Tue, 26 Jan 2021 12:01:30 GMT, Coleen Phillimore wrote:
>> I assume a WXVerifier class that tracks W^X mode in debug mode and does
>> nothing in release mode. I've considered to do this, it's relates to small
>> inefficiencies, while this patch brings zero overhead (in release) for a
>> pla
On Wed, 3 Feb 2021 20:05:29 GMT, Anton Kozlov wrote:
>> Thank you all for your comments regarding W^X implementation. I've made a
>> change that reduces the footprint of the implementation, also addressing
>> most of the comments. I'll revisit them individually to make sure nothing is
>> forgo
On Wed, 3 Feb 2021 19:57:24 GMT, Anton Kozlov wrote:
>> For platform files that were copied from other ports to this port, if the
>> file wasn't
>> changed I presume the copyright years are left alone. If the file required
>> changes
>> for this port, I expect the year to be updated to 2021. Ho
On Tue, 2 Feb 2021 23:10:17 GMT, Daniel D. Daugherty wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> For platform files that were copied from other ports to this port, if the
> f
> Please review the implementation of JEP 391: macOS/AArch64 Port.
>
> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
> windows/aarch64.
>
> Major changes are in:
> * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks
> JDK-8253817, JDK-8253818)
On Wed, 3 Feb 2021 18:50:34 GMT, Alexander Zuev wrote:
> 8216358: [accessibility] [macos] The focus is invisible when tab to "Image
> Radio Buttons" and "Image CheckBoxes"
This is how radio button group with custom icons looks without the fix. The
focus is on the middle radio button.
https://u
8216358: [accessibility] [macos] The focus is invisible when tab to "Image
Radio Buttons" and "Image CheckBoxes"
-
Commit messages:
- 8216358: [accessibility] [macos] The focus is invisible when tab to "Image
Radio Buttons" and "Image CheckBoxes"
Changes: https://git.openjdk.java.
Method createStrokedShape(Shape) for java.awt.BasicStroke class throws
NullPointerException when passed a null object reference for a input parameter
but it's not specified in the spec.
Updated spec to illustrate this.
-
Commit messages:
- 6211257: BasicStroke.createStrokedShape(Sh
On Wed, 3 Feb 2021 08:28:05 GMT, Prasanta Sadhukhan
wrote:
>> Document setting null setColor similar to way setFont(null) is documented.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Add test
Marked as reviewed by
On Tue, 2 Feb 2021 18:03:50 GMT, Gerard Ziemski wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 5271:
>
>> 5269: //
>> 527
On Tue, 2 Feb 2021 21:49:36 GMT, Daniel D. Daugherty wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 323:
>
>> 321: str(
Sergey,
I tested clemens patch and sometimes, jvm hangs if I close the xwindow
where the opengl surface is still rendering...
Could you explain us or do you have design documents (html, pdf, wiki...)
describing the awt locking scheme and its relations with x11 / opengl and
other native backends ?
> Document setting null setColor similar to way setFont(null) is documented.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
Add test
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2371/files
- new: ht
On Wed, 3 Feb 2021 07:59:15 GMT, Prasanta Sadhukhan
wrote:
>> While CSR is under review, maybe we can add a small test?
>
> What will be the objective of the test...It's just documentation change..no
> code is changed...setting null will be ignored before this and after this
> change...
This
On Wed, 3 Feb 2021 07:57:17 GMT, Sergey Bylokhov wrote:
>>>
>>>
>>> @mrserb has indicated that a [compatibility and
>>> specification](https://wiki.openjdk.java.net/display/csr/Main) (CSR)
>>> request is needed for this pull request.
>>> @prsadhuk please create a CSR request and add link to i
On Wed, 3 Feb 2021 07:39:54 GMT, Prasanta Sadhukhan
wrote:
>> Marked as reviewed by pbansal (Reviewer).
>
>>
>>
>> @mrserb has indicated that a [compatibility and
>> specification](https://wiki.openjdk.java.net/display/csr/Main) (CSR) request
>> is needed for this pull request.
>> @prsadhuk
40 matches
Mail list logo
