Re: [OpenJDK 2D-Dev] RFR: 8260695: The java.awt.color.ICC_Profile#getData/getData(int) are not thread safe [v2]

2021-02-05 Thread Sergey Bylokhov
> Both methods are implemented in a similar way. > 1. Requests the size of the profile/tag data > 2. Creates an array of the correct size > 3. Requests the data and copy it to the array > > If the data will be changed concurrently between steps 2. and 3. then we will > get a mismatch between t

Re: [OpenJDK 2D-Dev] RFR: 6211198: ICC_Profile.getInstance(byte[]): IAE is not specified [v2]

2021-02-05 Thread Sergey Bylokhov
> The specification of the java.awt.color.ICC_Profile.getInstance(byte[]) is > updated. > Its implementation changed over time, and different exceptions were thrown, > but since JDK-8013430 always throws an IllegalArgumentException on null and > invalid data. Sergey Bylokhov has updated the pul

[OpenJDK 2D-Dev] Integrated: 8261200: Some code in the ICC_Profile may not close file streams properly

2021-02-05 Thread Sergey Bylokhov
On Fri, 5 Feb 2021 04:05:12 GMT, Sergey Bylokhov wrote: > In a few places where we use streams the try/with/res blocks are added. This pull request has now been integrated. Changeset: 74d40ab7 Author:Sergey Bylokhov URL: https://git.openjdk.java.net/jdk/commit/74d40ab7 Stats: 105

Re: [OpenJDK 2D-Dev] RFR: 8261200: Some code in the ICC_Profile may not close file streams properly [v2]

2021-02-05 Thread Alexander Zvegintsev
On Sat, 6 Feb 2021 02:11:16 GMT, Sergey Bylokhov wrote: >> In a few places where we use streams the try/with/res blocks are added. > > Sergey Bylokhov has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brough

Re: [OpenJDK 2D-Dev] RFR: 8261200: Some code in the ICC_Profile may not close file streams properly [v2]

2021-02-05 Thread Sergey Bylokhov
> In a few places where we use streams the try/with/res blocks are added. Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additiona

Re: [OpenJDK 2D-Dev] RFR: 8261200: Some code in the ICC_Profile may not close file streams properly [v2]

2021-02-05 Thread Sergey Bylokhov
On Sat, 6 Feb 2021 01:23:54 GMT, Alexander Zvegintsev wrote: >> Sergey Bylokhov has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional

Re: [OpenJDK 2D-Dev] RFR: 8261200: Some code in the ICC_Profile may not close file streams properly

2021-02-05 Thread Alexander Zvegintsev
On Fri, 5 Feb 2021 04:05:12 GMT, Sergey Bylokhov wrote: > In a few places where we use streams the try/with/res blocks are added. test/jdk/java/awt/color/ICC_Profile/WriteProfileToFile.java line 43: > 41: testViaDataArray(gold); > 42: testViaFile(gold); > 43: testViaStre

Re: [OpenJDK 2D-Dev] RFR: 8261200: Some code in the ICC_Profile may not close file streams properly

2021-02-05 Thread Alexander Zvegintsev
On Fri, 5 Feb 2021 04:05:12 GMT, Sergey Bylokhov wrote: > In a few places where we use streams the try/with/res blocks are added. test/jdk/java/awt/color/ICC_Profile/WriteProfileToFile.java line 83: > 81: } > 82: } > 83: } Just a matter of taste, but if you OK with not

Re: [OpenJDK 2D-Dev] RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline

2021-02-05 Thread Kevin Rushforth
On Thu, 4 Feb 2021 10:35:02 GMT, Ajit Ghaisas wrote: > **Description :** > This is the implementation of [JEP 382 : New macOS Rendering > Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361) > It implements a Java 2D internal rendering pipeline for macOS using the Apple > Metal API. > Th

Re: [OpenJDK 2D-Dev] RFR: 6211257: BasicStroke.createStrokedShape(Shape): NPE is not specified [v2]

2021-02-05 Thread Sergey Bylokhov
On Thu, 4 Feb 2021 04:15:03 GMT, Prasanta Sadhukhan wrote: >> Method createStrokedShape(Shape) for java.awt.BasicStroke class throws >> NullPointerException when passed a null object reference for a input >> parameter but it's not specified in the spec. >> Updated spec to illustrate this. > >

[OpenJDK 2D-Dev] RFR: 8261200: Some code in the ICC_Profile may not close file streams properly

2021-02-05 Thread Sergey Bylokhov
In a few places where we use streams the try/with/res blocks are added. - Commit messages: - Update ICC_Profile.java - Update ICC_Profile.java - Initial fix Changes: https://git.openjdk.java.net/jdk/pull/2421/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2421&range=

Re: [OpenJDK 2D-Dev] RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline

2021-02-05 Thread Kevin Rushforth
On Thu, 4 Feb 2021 10:35:02 GMT, Ajit Ghaisas wrote: > **Description :** > This is the implementation of [JEP 382 : New macOS Rendering > Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361) > It implements a Java 2D internal rendering pipeline for macOS using the Apple > Metal API. > Th

[OpenJDK 2D-Dev] Integrated: 8216358: [accessibility] [macos] The focus is invisible when tab to "Image Radio Buttons" and "Image CheckBoxes"

2021-02-05 Thread Alexander Zuev
On Wed, 3 Feb 2021 18:50:34 GMT, Alexander Zuev wrote: > 8216358: [accessibility] [macos] The focus is invisible when tab to "Image > Radio Buttons" and "Image CheckBoxes" This pull request has now been integrated. Changeset: 440db35e Author:Alexander Zuev URL: https://git.openjdk.j

Re: [OpenJDK 2D-Dev] RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline

2021-02-05 Thread Kevin Rushforth
On Thu, 4 Feb 2021 10:35:02 GMT, Ajit Ghaisas wrote: > **Description :** > This is the implementation of [JEP 382 : New macOS Rendering > Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361) > It implements a Java 2D internal rendering pipeline for macOS using the Apple > Metal API. > Th

Re: [OpenJDK 2D-Dev] RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline

2021-02-05 Thread Alexey Ushakov
On Thu, 4 Feb 2021 10:35:02 GMT, Ajit Ghaisas wrote: > **Description :** > This is the implementation of [JEP 382 : New macOS Rendering > Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361) > It implements a Java 2D internal rendering pipeline for macOS using the Apple > Metal API. > Th

Re: [OpenJDK 2D-Dev] RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-02-05 Thread Anton Kozlov
On Tue, 2 Feb 2021 18:35:51 GMT, Gerard Ziemski wrote: >> Anton Kozlov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> support macos_aarch64 in hsdis > > src/hotspot/cpu/aarch64/vm_version_aarch64.hpp line 93: > >> 91: CPU_MARVELL

Re: [OpenJDK 2D-Dev] RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-02-05 Thread Anton Kozlov
On Wed, 3 Feb 2021 23:29:30 GMT, Gerard Ziemski wrote: >> using ` ```c ` >> https://docs.github.com/en/github/writing-on-github/creating-and-highlighting-code-blocks >> >> I was wrong about `SIGFPE` / `EXC_MASK_ARITHMETIC`, it's used on i386, >> x86_64: >> https://github.com/openjdk/jdk/blob/2

Re: [OpenJDK 2D-Dev] RFR: 6211257: BasicStroke.createStrokedShape(Shape): NPE is not specified [v2]

2021-02-05 Thread Alexey Ivanov
On Thu, 4 Feb 2021 04:15:03 GMT, Prasanta Sadhukhan wrote: >> Method createStrokedShape(Shape) for java.awt.BasicStroke class throws >> NullPointerException when passed a null object reference for a input >> parameter but it's not specified in the spec. >> Updated spec to illustrate this. > >

Re: [OpenJDK 2D-Dev] RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v12]

2021-02-05 Thread Anton Kozlov
> Please review the implementation of JEP 391: macOS/AArch64 Port. > > It's heavily based on existing ports to linux/aarch64, macos/x86_64, and > windows/aarch64. > > Major changes are in: > * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks > JDK-8253817, JDK-8253818)

Re: [OpenJDK 2D-Dev] RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v10]

2021-02-05 Thread Gerard Ziemski
On Fri, 5 Feb 2021 12:26:27 GMT, Anton Kozlov wrote: >> Marked as reviewed by ihse (Reviewer). > >> I haven't got a MacOS AArch64 system right now. Is it possible to >> enable W^X in Linux in order to kick the tyres? > > I've just got rid of asserts that fired on Linux sometime :) As for W^X lik

Re: [OpenJDK 2D-Dev] RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-02-05 Thread daniel . daugherty
On 2/5/21 4:51 AM, Magnus Ihse Bursie wrote: On Tue, 2 Feb 2021 21:20:52 GMT, Daniel D. Daugherty wrote: Anton Kozlov has updated the pull request incrementally with one additional commit since the last revision: support macos_aarch64 in hsdis make/autoconf/flags.m4 line 140: 138:

Re: [OpenJDK 2D-Dev] EA8 build of Project Lanai (Java 2D Metal rendering pipeline for macOS) is now posted

2021-02-05 Thread Alan Snyder
> On Dec 16, 2020, at 11:57 PM, Philip Race wrote: > > To anyone who has a mac still running 10.12 - we don't expect Metal to run > (it requires at least 10.13 > and maybe even later by the time it is final) but we would like confirmation > that nothing in Metal > prevents OpenGL running on o

[OpenJDK 2D-Dev] [11u] Backport of 8247872: Upgrade HarfBuzz to the latest 2.7.2

2021-02-05 Thread Doerr, Martin
Hi, I've created a jdk11u backport of JDK-8247872: Upgrade HarfBuzz to the latest 2.7.2 http://cr.openjdk.java.net/~mdoerr/8247872_harfbuzz_11u/webrev.00/ I had to resolve it a bit manually [1]. However, the main problem is that it heavily uses C++11, so easiest solution is to add HARFBUZZ_CFLA

Re: [OpenJDK 2D-Dev] RFR: 8252999: Cleanup: replace .equals("") with .isEmpty() within all codebase

2021-02-05 Thread David Holmes
On 10/09/2020 10:07 pm, Dmitriy Dumanskiy wrote: On Thu, 10 Sep 2020 11:21:28 GMT, David Holmes wrote: The code in java.base was updated to use String::isEmpty in JDK 12 (JDK-8215281). There was follow-up in JDK 13 to do the same in the java.desktop module (JDK-8223237). Changing the remainin

Re: [OpenJDK 2D-Dev] [11u] Backport of 8247872: Upgrade HarfBuzz to the latest 2.7.2

2021-02-05 Thread Doerr, Martin
Hi Christoph, > is there any other reason why harfbuzz 2.7.2 needs to be backported to > OpenJDK 11 beyond the fact that Oracle did it? I don't have other reasons at the moment. I'd be fine with deferring it until anyone has a demand. I'm just evaluating options in order to be prepared. > I thin

Re: [OpenJDK 2D-Dev] RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v11]

2021-02-05 Thread Anton Kozlov
> Please review the implementation of JEP 391: macOS/AArch64 Port. > > It's heavily based on existing ports to linux/aarch64, macos/x86_64, and > windows/aarch64. > > Major changes are in: > * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks > JDK-8253817, JDK-8253818)

Re: [OpenJDK 2D-Dev] RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v3]

2021-02-05 Thread Anton Kozlov
On Mon, 25 Jan 2021 22:48:50 GMT, Chris Plummer wrote: >> Anton Kozlov has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Refactor CDS disabling >> - Redo builsys support for aarch64-darwin > > src/jdk.hotspot.agent/macosx/native/libsapr

Re: [OpenJDK 2D-Dev] RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v10]

2021-02-05 Thread Anton Kozlov
On Fri, 5 Feb 2021 09:57:54 GMT, Magnus Ihse Bursie wrote: >> Anton Kozlov has updated the pull request incrementally with six additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'origin/jdk/jdk-macos' into jdk-macos >> - Add comments to WX transitions >> >

Re: [OpenJDK 2D-Dev] RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v10]

2021-02-05 Thread Magnus Ihse Bursie
On Fri, 5 Feb 2021 09:49:11 GMT, Andrew Haley wrote: >> I reviewed bsd_aarch64.cpp digging bit deeper and left some comments. > >> > Umm, so how does patching work? We don't even know if other threads are >> > executing the code we need to patch. >> >> I thought java can handle that scenario in

Re: [OpenJDK 2D-Dev] RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v10]

2021-02-05 Thread Magnus Ihse Bursie
On Wed, 3 Feb 2021 20:01:15 GMT, Anton Kozlov wrote: >> Please review the implementation of JEP 391: macOS/AArch64 Port. >> >> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and >> windows/aarch64. >> >> Major changes are in: >> * src/hotspot/cpu/aarch64: support of the

Re: [OpenJDK 2D-Dev] RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v9]

2021-02-05 Thread Magnus Ihse Bursie
On Tue, 2 Feb 2021 21:20:52 GMT, Daniel D. Daugherty wrote: >> Anton Kozlov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> support macos_aarch64 in hsdis > > make/autoconf/flags.m4 line 140: > >> 138: else >> 139: MACOSX_VERS

Re: [OpenJDK 2D-Dev] RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v10]

2021-02-05 Thread Andrew Haley
On Thu, 4 Feb 2021 23:05:56 GMT, Gerard Ziemski wrote: >> Anton Kozlov has updated the pull request incrementally with six additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'origin/jdk/jdk-macos' into jdk-macos >> - Add comments to WX transitions >> >>