On Thu, 11 Feb 2021 18:42:30 GMT, Phil Race wrote:
> The various CF*Copy* functions called here need a matching CFRelease
This pull request has now been integrated.
Changeset: f0d9829b
Author:Phil Race
URL: https://git.openjdk.java.net/jdk/commit/f0d9829b
Stats: 9 lines in 1 file
On Fri, 12 Feb 2021 04:48:27 GMT, Prasanta Sadhukhan
wrote:
>> The various CF*Copy* functions called here need a matching CFRelease
>
> src/java.desktop/macosx/native/libawt_lwawt/font/AWTFont.m line 578:
>
>> 576: (*env)->CallBooleanMethod(env, arrayListOfString, addMID,
>> jFontName)
On Thu, 4 Feb 2021 22:49:23 GMT, Gerard Ziemski wrote:
>> Anton Kozlov has updated the pull request incrementally with six additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'origin/jdk/jdk-macos' into jdk-macos
>> - Add comments to WX transitions
>>
>>
On Thu, 11 Feb 2021 15:44:57 GMT, Prasanta Sadhukhan
wrote:
>> The API doc for Graphics2D.clip(shape s) claims that passing a null argument
>> would actually clear the existing clipping area, which is incorrect.
>> This statement is applicable only to G2D.setClip() and not for the clip()
>> me
On Tue, 2 Feb 2021 22:08:14 GMT, Daniel D. Daugherty wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp line 221:
>
>> 219: ass
On Thu, 11 Feb 2021 20:00:01 GMT, Sergey Bylokhov wrote:
>> Both methods are implemented in a similar way.
>> 1. Requests the size of the profile/tag data
>> 2. Creates an array of the correct size
>> 3. Requests the data and copy it to the array
>>
>> If the data will be changed concurrently
On Wed, 3 Feb 2021 09:11:50 GMT, Andrew Haley wrote:
>> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 323:
>>
>>> 321: str(zr, Address(rthread, JavaThread::last_Java_pc_offset()));
>>> 322:
>>> 323: str(zr, Address(rthread,
>>> JavaFrameAnchor::saved_fp_address_offset()));
>>
>>
> Please review the implementation of JEP 391: macOS/AArch64 Port.
>
> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
> windows/aarch64.
>
> Major changes are in:
> * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks
> JDK-8253817, JDK-8253818)
On Tue, 2 Feb 2021 22:14:42 GMT, Daniel D. Daugherty wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp line 486:
>
>> 484:
On Fri, 12 Feb 2021 12:22:44 GMT, Vladimir Kempik wrote:
>> src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp line 435:
>>
>>> 433: //||\ Java thread created by VM does not
>>> have glibc
>>> 434: //|glibc guard page| - guard, attached Java thread usuall
On Tue, 2 Feb 2021 22:12:07 GMT, Daniel D. Daugherty wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp line 435:
>
>> 433: //|
On Thu, 4 Feb 2021 22:54:42 GMT, Gerard Ziemski wrote:
>> src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp line 363:
>>
>>> 361: address pc = os::Posix::ucontext_get_pc(uc);
>>> 362:
>>> 363: if (pc != addr && uc->context_esr == 0x924F) { //TODO: figure
>>> out what this value mea
On Tue, 2 Feb 2021 22:07:15 GMT, Daniel D. Daugherty wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp line 195:
>
>> 193: frame o
On Thu, 4 Feb 2021 21:59:02 GMT, Gerard Ziemski wrote:
>> Anton Kozlov has updated the pull request incrementally with six additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'origin/jdk/jdk-macos' into jdk-macos
>> - Add comments to WX transitions
>>
>>
On Thu, 11 Feb 2021 21:04:16 GMT, Gerard Ziemski wrote:
>> I guess you will only see this if `Metal API Validation Enabled`
>
> Which actually begs a question of whether we tested with `Metal API
> Validation Enabled` ?
Thanks @gerard-ziemski for bringing out this important observation. It clea
15 matches
Mail list logo