Re: [OpenJDK 2D-Dev] RFR: 8263622: The java.awt.color.ICC_Profile#setData invert the order of bytes for the "head" tag

2021-03-16 Thread Sergey Bylokhov
On Tue, 16 Mar 2021 20:08:59 GMT, Sergey Bylokhov wrote: > The root cause is using the wrong endian, the ICC profile uses big-endian > notation. We even have special methods to convert the data, but for some > reason, their usage was dropped in the JDK-6523398. src/java.desktop/share/native/li

[OpenJDK 2D-Dev] RFR: 8263622: The java.awt.color.ICC_Profile#setData invert the order of bytes for the "head" tag

2021-03-16 Thread Sergey Bylokhov
The root cause is using the wrong endian, the ICC profile uses big-endian notation. We even have special methods to convert the data, but for some reason, their usage was dropped in the JDK-6523398. - Commit messages: - test update - reformat - use built-in AdjustEndiannessXX -

Re: [OpenJDK 2D-Dev] RFR: 8263583: Emoji rendering on macOS

2021-03-16 Thread Sergey Bylokhov
On Tue, 16 Mar 2021 08:50:27 GMT, Dmitry Batrak wrote: > What kind of test are you having in mind? I can extend the added > MacEmoji.java test, that will check that 'something' is painted to different > types of BufferedImage-s and/or with transforms applied. Or you want me to > add a manual t

[OpenJDK 2D-Dev] Integrated: 8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux

2021-03-16 Thread Phil Race
On Sat, 13 Mar 2021 00:15:16 GMT, Phil Race wrote: > From a build perspective this partially reverts > https://bugs.openjdk.java.net/browse/JDK-8249821 except that it keeps > the harfbuzz sources separate and still supports building and running against > a system harfbuzz which is only of inte

Re: [OpenJDK 2D-Dev] RFR: 8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux [v3]

2021-03-16 Thread Alexander Zvegintsev
On Tue, 16 Mar 2021 16:56:22 GMT, Phil Race wrote: >> From a build perspective this partially reverts >> https://bugs.openjdk.java.net/browse/JDK-8249821 except that it keeps >> the harfbuzz sources separate and still supports building and running >> against a system harfbuzz which is only of

Re: [OpenJDK 2D-Dev] RFR: 8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux [v3]

2021-03-16 Thread Magnus Ihse Bursie
On Tue, 16 Mar 2021 16:56:22 GMT, Phil Race wrote: >> From a build perspective this partially reverts >> https://bugs.openjdk.java.net/browse/JDK-8249821 except that it keeps >> the harfbuzz sources separate and still supports building and running >> against a system harfbuzz which is only of

Re: [OpenJDK 2D-Dev] RFR: 8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux [v3]

2021-03-16 Thread Phil Race
> From a build perspective this partially reverts > https://bugs.openjdk.java.net/browse/JDK-8249821 except that it keeps > the harfbuzz sources separate and still supports building and running against > a system harfbuzz which is only of interest or relevance on Linux. > > I ended up having to

Re: [OpenJDK 2D-Dev] RFR: 8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux [v2]

2021-03-16 Thread Phil Race
On Tue, 16 Mar 2021 10:38:19 GMT, Alexander Zvegintsev wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux > > make/modules/java.desktop/lib/Awt2dL

Re: [OpenJDK 2D-Dev] RFR: 8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux [v2]

2021-03-16 Thread Alexander Zvegintsev
On Mon, 15 Mar 2021 18:57:28 GMT, Phil Race wrote: >> From a build perspective this partially reverts >> https://bugs.openjdk.java.net/browse/JDK-8249821 except that it keeps >> the harfbuzz sources separate and still supports building and running >> against a system harfbuzz which is only of

Re: [OpenJDK 2D-Dev] RFR: 8263583: Emoji rendering on macOS

2021-03-16 Thread Dmitry Batrak
On Tue, 16 Mar 2021 05:10:05 GMT, Dmitry Batrak wrote: >> Initial testing it looks OK with OpenGL but it renders as garbage with the >> metal pipeline. >> I'd guess metal isn't expecting 4bpp and the stride is wrong. >> I see updates in OGLTextRenderer so something similar likely needed for >>