Re: [OpenJDK 2D-Dev] RFR: 8182043: Access to Windows Large Icons [v2]

2021-04-29 Thread Alexander Zuev
> Fix updated after first round of review. Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Small fixes Remived size parameter from makeIcon Removed useVGAColors usage as irrelevant since it is ignored on all supported

Re: [OpenJDK 2D-Dev] RFR: 8266171: -Warray-bounds happens in imageioJPEG.c

2021-04-29 Thread Yasumasa Suenaga
On Thu, 29 Apr 2021 20:54:47 GMT, Phil Race wrote: >> We can see following compiler warnings in imageioJPEG.c on GCC 11. > > src/java.desktop/share/native/libjavajpeg/imageioJPEG.c line 673: > >> 671: if (info->is_decompressor) { >> 672: j_decompress_ptr dinfo =

Re: [OpenJDK 2D-Dev] RFR: 8266171: -Warray-bounds happens in imageioJPEG.c

2021-04-29 Thread Phil Race
On Thu, 29 Apr 2021 07:10:33 GMT, Yasumasa Suenaga wrote: > We can see following compiler warnings in imageioJPEG.c on GCC 11. src/java.desktop/share/native/libjavajpeg/imageioJPEG.c line 673: > 671: if (info->is_decompressor) { > 672: j_decompress_ptr dinfo =

Re: [OpenJDK 2D-Dev] RFR: 8182043: Access to Windows Large Icons

2021-04-29 Thread Alexander Zuev
On Wed, 10 Mar 2021 20:17:05 GMT, Alexey Ivanov wrote: >> Fix updated after first round of review. > > src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolder2.java line > 1044: > >> 1042: new BufferedImage(iconSize, iconSize, >> BufferedImage.TYPE_INT_ARGB);

Re: [OpenJDK 2D-Dev] RFR: 8266284: ProblemList java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java

2021-04-29 Thread Phil Race
On Thu, 29 Apr 2021 07:57:17 GMT, Prasanta Sadhukhan wrote: > It seems the newly deproblemlisted test > DrawRotatedStringUsingRotatedFont.java which is paasing in windows,linux-x64 > and macos-x64 is failing in newly added linux-aarch64 systems. > Problemlisting the test for now as it is font

Re: [OpenJDK 2D-Dev] RFR: 8182043: Access to Windows Large Icons

2021-04-29 Thread Alexander Zuev
On Wed, 10 Mar 2021 20:27:44 GMT, Alexey Ivanov wrote: >> Fix updated after first round of review. > > src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolder2.java line > 1114: > >> 1112: bothIcons.put(getLargeIcon? >> SMALL_ICON_SIZE :

Re: [OpenJDK 2D-Dev] RFR: 8182043: Access to Windows Large Icons

2021-04-29 Thread Alexander Zuev
On Wed, 10 Mar 2021 20:32:12 GMT, Alexey Ivanov wrote: >> Fix updated after first round of review. > > src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolder2.java line > 1195: > >> 1193: */ >> 1194: static Image getShell32Icon(int iconID, int size) { >> 1195: boolean

Re: [OpenJDK 2D-Dev] RFR: 8182043: Access to Windows Large Icons

2021-04-29 Thread Alexander Zuev
On Fri, 2 Apr 2021 21:20:49 GMT, Alexey Ivanov wrote: >> Fix updated after first round of review. > > src/java.desktop/share/classes/javax/swing/filechooser/FileSystemView.java > line 276: > >> 274: * >> 275: * @param f a File object >> 276: * @param size width and height of the

[OpenJDK 2D-Dev] RFR: 8266171: -Warray-bounds happens in imageioJPEG.c

2021-04-29 Thread Yasumasa Suenaga
We can see following compiler warnings in imageioJPEG.c on GCC 11. - Commit messages: - 8266171: -Warray-bounds happens in imageioJPEG.c Changes: https://git.openjdk.java.net/jdk/pull/3788/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=3788=00 Issue:

[OpenJDK 2D-Dev] Integrated: 8266284: ProblemList java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java

2021-04-29 Thread Prasanta Sadhukhan
On Thu, 29 Apr 2021 07:57:17 GMT, Prasanta Sadhukhan wrote: > It seems the newly deproblemlisted test > DrawRotatedStringUsingRotatedFont.java which is paasing in windows,linux-x64 > and macos-x64 is failing in newly added linux-aarch64 systems. > Problemlisting the test for now as it is font

Re: [OpenJDK 2D-Dev] RFR: 8266284: ProblemList java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java

2021-04-29 Thread Jayathirth D V
On Thu, 29 Apr 2021 07:57:17 GMT, Prasanta Sadhukhan wrote: > It seems the newly deproblemlisted test > DrawRotatedStringUsingRotatedFont.java which is paasing in windows,linux-x64 > and macos-x64 is failing in newly added linux-aarch64 systems. > Problemlisting the test for now as it is font

[OpenJDK 2D-Dev] RFR: 8266284: ProblemList java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java

2021-04-29 Thread Prasanta Sadhukhan
It seems the newly deproblemlisted test DrawRotatedStringUsingRotatedFont.java which is paasing in windows,linux-x64 and macos-x64 is failing in newly added linux-aarch64 systems. Problemlisting the test for now as it is font layout issue which might need some upgrade in harfbuzz library in