Re: [OpenJDK 2D-Dev] RFR: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8

2021-05-05 Thread Thomas Stuefe
On Wed, 5 May 2021 07:54:20 GMT, Thomas Stuefe wrote: > Harfbuzz upgrade broke Linux x64 build on older gccs. For details see JBS > issue. > > I fixed the issue in the harfbuzz sources, but I am not sure of the policy > here. Do we modify the harfbuzz sources or leave them untouched? Advice

Re: [OpenJDK 2D-Dev] RFR: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8

2021-05-05 Thread Thomas Stuefe
On Wed, 5 May 2021 07:54:20 GMT, Thomas Stuefe wrote: > Harfbuzz upgrade broke Linux x64 build on older gccs. For details see JBS > issue. > > I fixed the issue in the harfbuzz sources, but I am not sure of the policy > here. Do we modify the harfbuzz sources or leave them untouched? Advice

Re: [OpenJDK 2D-Dev] RFR: 8264666: Reuse Math.multiplyExact/addExact in the LCMSImageLayout class

2021-05-05 Thread Sergey Bylokhov
On Wed, 7 Apr 2021 23:23:28 GMT, Sergey Bylokhov wrote: >> I don't understand the exception handling here. multiplyExact and addExact >> will throw a runtime exception - ArithmeticException. And I don't see where >> it is caught. The change for ImageLayoutException to extend >>

[OpenJDK 2D-Dev] Integrated: 8262392: Update Mesa 3-D Headers to version 21.0.3

2021-05-05 Thread Phil Race
On Tue, 4 May 2021 14:24:22 GMT, Phil Race wrote: > Upgrades OpenGL header files to the latest Mesa project ones. > Build+test looks fine. This pull request has now been integrated. Changeset: 138d573c Author:Phil Race URL:

Re: [OpenJDK 2D-Dev] RFR: JDK-8263362: Avoid division by 0 in java/awt/font/TextJustifier.java justify [v2]

2021-05-05 Thread Matthias Baesken
> In java/awt/font/TextJustifier.java justify-method there is a potential code > path where divison by zero might happen , see also the Sonar finding > https://sonarcloud.io/project/issues?id=shipilev_jdk=AXcqMwpm8sPJZZzONu1k=false=CRITICAL=BUG > > > boolean hitLimit = (weight ==

Re: [OpenJDK 2D-Dev] RFR: JDK-8263362: Avoid division by 0 in java/awt/font/TextJustifier.java justify

2021-05-05 Thread Prasanta Sadhukhan
On Tue, 4 May 2021 15:00:29 GMT, Matthias Baesken wrote: >> I meant that since we are dividing by weight and absorbweight >> ` weightedDelta = delta / weight;` >> and >> weightedAbsorb = (delta - gslimit) / absorbweight; >> where both weight and absorbweight uses += gi.weight values so if one

Re: [OpenJDK 2D-Dev] RFR: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8

2021-05-05 Thread Matthias Baesken
On Wed, 5 May 2021 07:54:20 GMT, Thomas Stuefe wrote: > Harfbuzz upgrade broke Linux x64 build on older gccs. For details see JBS > issue. > > I fixed the issue in the harfbuzz sources, but I am not sure of the policy > here. Do we modify the harfbuzz sources or leave them untouched? Advice

[OpenJDK 2D-Dev] RFR: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8

2021-05-05 Thread Thomas Stuefe
Harfbuzz upgrade broke Linux x64 build on older gccs. For details see JBS issue. I fixed the issue in the harfbuzz sources, but I am not sure of the policy here. Do we modify the harfbuzz sources or leave them untouched? Advice is welcome. The patch fixes linux x64 fastdebug and opt build for

Re: [OpenJDK 2D-Dev] RFR: 8261169: Upgrade HarfBuzz to the latest 2.8.0

2021-05-05 Thread Thomas Stuefe
On Fri, 30 Apr 2021 20:07:53 GMT, Phil Race wrote: > Upgrade to harfbuzz 2.8 Same here. In my case it breaks with gcc 7.5.0, which I believe is still supported. I opened https://bugs.openjdk.java.net/browse/JDK-8266545. - PR: https://git.openjdk.java.net/jdk/pull/3826

Re: [OpenJDK 2D-Dev] RFR: 8226384: Implement a better logic to switch between OpenGL and Metal pipeline [v2]

2021-05-05 Thread Jayathirth D V
On Wed, 5 May 2021 02:34:52 GMT, Sergey Bylokhov wrote: >> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Move peer and getters to CFLayer > > src/java.desktop/macosx/classes/sun/java2d/opengl/CGLLayer.java line 60: >

Re: [OpenJDK 2D-Dev] RFR: 8262392: Update Mesa 3-D Headers to version 21.0.3

2021-05-05 Thread Jayathirth D V
On Tue, 4 May 2021 14:24:22 GMT, Phil Race wrote: > Upgrades OpenGL header files to the latest Mesa project ones. > Build+test looks fine. Marked as reviewed by jdv (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3854

Re: [OpenJDK 2D-Dev] RFR: 8226384: Implement a better logic to switch between OpenGL and Metal pipeline

2021-05-05 Thread Jayathirth D V
On Tue, 4 May 2021 17:51:24 GMT, Phil Race wrote: > LGTM. Is there anything not covered by this fix ? Hi Phil, We still have some if else checks in initialization paths like CPlatformView.initialize(), CPlatformEmbeddedFrame and static access of RenderQueue methods like LWCToolkit.sync().