On Thu, 12 Aug 2021 21:57:58 GMT, Sergey Bylokhov wrote:
>> Yes, the `ExceptionCheck()` call will silence the warnings from
>> `-Xcheck:jni`.
>
> Does it actually suppress the "Xcheck:jni" or it clears a raised exception?
> If an exception is still "raised" after this call we should do some
>
On Fri, 13 Aug 2021 06:18:49 GMT, Alexander Zuev wrote:
>> Initial implementation and a test case.
>>
>> The problem is that Aqua LaF shows the focused component with the glow on
>> the border, hence when the border is not painted the foxus is not displayed.
>> The idea is to paint the glowing
> Added an `ExceptionCheck()` followed by `ExceptionDescribe()` and
> `ExceptionClear()` immediately after the Java calls made from the callback
> function `ReadTTFontFileFunc()` in `freetypeScaler.c`.
>
> The exception(s) need to be cleared because we're not returning immediately
> to Java th
On Thu, 12 Aug 2021 21:57:37 GMT, Phil Race wrote:
>> Maxim Kartashev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Addressed PR comments
>>
>> 1. Added CHECK_NULL() to awt_Component.cpp
>
> test/jdk/java/awt/font/JNICheck/FreeTyp
On Fri, 13 Aug 2021 00:07:56 GMT, Phil Race wrote:
>> test/jdk/java/awt/font/JNICheck/FreeTypeScalerJNICheck.java line 29:
>>
>>> 27: * @summary Verifies that -Xcheck:jni issues no warnings from
>>> freetypeScaler.c
>>> 28: * @library /test/lib
>>> 29: * @key headful
>>
>> What about this t
On Fri, 13 Aug 2021 12:29:06 GMT, Maxim Kartashev
wrote:
>> oh you are getting metrics for a JFrame ? That's not going to exercise any
>> new font code so is pointless except to make it so the test has to be
>> headful.
>
> But `getFontMetrics()` is the primary "entry point" that generated all
> Keep MTLLayer opacity in sync with window content view
> Keep layer translucent for translucent windows
Alexey Ushakov has updated the pull request incrementally with one additional
commit since the last revision:
8266079: Lanai: AlphaComposite shows differences on Metal compared to OpenGL
On Fri, 13 Aug 2021 01:46:20 GMT, Sergey Bylokhov wrote:
>> Did you mean to make MTLLayer opaque by default? Yes, I did it in the latest
>> version.
>
> Then why do you need " platformWindow.setOpaque(!isTranslucent());" above?
Ah, I see. Updated.
-
PR: https://git.openjdk.java.ne
On Fri, 13 Aug 2021 03:51:23 GMT, Jonathan Gibbons wrote:
> Please review a relatively simple update to have doclnt check for empty
> "descriptions" -- the body of a doc comment, before the block tags.
>
> It is already the case that doclint checks for missing/empty descriptions in
> block tag
On Fri, 13 Aug 2021 14:30:58 GMT, Alexey Ushakov wrote:
>> Keep MTLLayer opacity in sync with window content view
>> Keep layer translucent for translucent windows
>
> Alexey Ushakov has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8266079:
On Fri, 13 Aug 2021 12:11:15 GMT, Maxim Kartashev
wrote:
>> Does it actually suppress the "Xcheck:jni" or it clears a raised exception?
>> If an exception is still "raised" after this call we should do some
>> additional steps to log/clean it.
>
> Yes, the exception will still be "raised" afte
> Initial implementation and a test case.
>
> The problem is that Aqua LaF shows the focused component with the glow on the
> border, hence when the border is not painted the foxus is not displayed. The
> idea is to paint the glowing border on the focused component anyways.
Alexander Zuev has u
On Fri, 13 Aug 2021 12:15:38 GMT, Prasanta Sadhukhan
wrote:
> UIManager.getColor(). should suffice
Fixed.
> But I am not sure with this hardcoded values..Can't we leverage viewRect or
> textRect to get the required coordinates?
viewRect is set to be exactly (0, 0, b.width, b.height). Insets
On Mon, 19 Jul 2021 20:50:14 GMT, Phil Race wrote:
> Applet support was removed already but the .html file was left as well as
> docs on applet issues
> and a parameter only relevant to applets.
This pull request has now been integrated.
Changeset: 0af645aa
Author:Phil Race
URL:
ht
On Fri, 13 Aug 2021 12:27:51 GMT, Maxim Kartashev
wrote:
>> Added an `ExceptionCheck()` followed by `ExceptionDescribe()` and
>> `ExceptionClear()` immediately after the Java calls made from the callback
>> function `ReadTTFontFileFunc()` in `freetypeScaler.c`.
>>
>> The exception(s) need to
On Thu, 12 Aug 2021 21:13:04 GMT, Phil Race wrote:
> passes
Looks good. I tried the test as headless and headful which happens to then
exercise a broader set of distros than only one or the other the way our
systems are set up.
-
PR: https://git.openjdk.java.net/jdk/pull/4572
16 matches
Mail list logo
