Sounds OK to me. :)
Best Regards
Adam Farley
Philip Race wrote on 01/06/2018 03:04:12:
> From: Philip Race
> To: Adam Farley8
> Cc: 2d-dev <2d-dev@openjdk.java.net>, build-dev d...@openjdk.java.net>, Andrew Leonard ,
> "Stuefe, Thomas"
> Date: 01/06/201
ned.
Right now this isn't a bug, just a quirk I was mentioning.
Best Regards
Adam Farley
Phil Race wrote on 30/05/2018 18:07:39:
> From: Phil Race
> To: Adam Farley8
> Cc: 2d-dev <2d-dev@openjdk.java.net>
> Date: 30/05/2018 18:08
> Subject: Re: [OpenJDK 2D-Dev] Que
Adam Farley
P.S. I'm holding off on giving Guido the green light until after people
say if they're happy with the error-enabled version of the fix.
Adam Farley8/UK/IBM wrote on 14/05/2018 11:06:28:
> From: Adam Farley8/UK/IBM
> To: Phil Race
> Cc: 2d-dev <2d-dev@openjdk.j
essed code.
I'll leave this here as a thought for any committer bothered by this,
though I won't be pushing it.
png.h
+ #ifndef PNG_DLL_EXPORT
+ #define PNG_DLL_EXPORT
+ #endif
Best Regards
Adam Farley
Philip Race wrote on 29/05/2018 14:23:21:
> From: Philip Race
Hi All,
Does anyone know why png.c does not include png.h?
This tripped me up recently, and I don't understand why png.c would not
include png.h.
Best Regards
Adam Farley
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number
741598.
Registe
; s390 build. It is annoying but no big deal breaker.
>
> Thanks & best Regards, Thomas
>
>
> On Fri, May 18, 2018 at 5:23 PM, Adam Farley8
wrote:
> > Hi,
> >
> > I tried to use the IJG's contact page, but no joy. Seems broken; there
a
> > spinning
00052: libjavajpeg: Fix compile
warning in jchuff.cPhilip Race to: Adam Farley8 17/05/2018 03:32
> Cc: 2d-dev, Andrew Leonard, build-dev, Magnus Ihse Bursie, "Thomas
Stüfe"
> From: Philip Race
> To: Adam Farley8
> Cc: 2d-dev <2d-dev@openjdk.java.net>, Andrew Leonard
, b
ot build code so I don't have the final say.
> >
> > /Magnus
> >
> >
> > On 2018-04-25 17:43, Adam Farley8 wrote:
> >
> > Hi All,
> >
> > Does anyone have an objection to pushing this tiny change in?
> >
> > It doesn't break anythin
Hi All,
Does anyone have an objection to pushing this tiny change in?
It doesn't break anything, it fixes a build break on two supported
platforms, and it seems
like we never refresh the code from upstream.
- Adam
> I also advocate the source code fix, as Make isn't meant to use the sort
of
I also advocate the source code fix, as Make isn't meant to use the sort
of logic required
to properly analyse the toolchain version string.
e.g. An "eq" match on 4.8.5 doesn't protect the user who is using 4.8.6,
and Make doesn't
seem to do substring stuff unless you mess around with shells.
I also advocate the source code fix, as Make isn't meant to use the sort
of logic required
to properly analyse the toolchain version string.
e.g. An "eq" match on 4.8.5 doesn't protect the user who is using 4.8.6,
and Make doesn't
seem to do substring stuff unless you mess around with shells.
net/pipermail/2d-dev/2018-January/008855.html
> [2]
http://mail.openjdk.java.net/pipermail/build-dev/2018-January/020695.html
>
>
>
> On 03/21/2018 09:53 AM, Adam Farley8 wrote:
>
> :)
>
> > Hi Adam,
> >
> > no problem. I'll open a bug and if
:)
> Hi Adam,
>
> no problem. I'll open a bug and if necessary find a second reviewer.
Thanks for fixing, maybe I can stop building with warnings disabled on our
s390 machines now.
>
> ..Thomas
>
> > On Wed, Mar 21, 2018 at 5:10 PM, Andrew Leonard
wrote:
> > Hi Thomas,
> > I'm a "contribut
gt; > > Hi Adam,
> > >
> > > this patch looks good. I can sponsor this for you if noone else
steps up, but we need a second reviewer, preferably one from the 2d
project.
> > >
> > > Best Regards, Thomas
> > >
> > > On Wed, Mar 21, 201
> On Wed, Mar 21, 2018 at 12:41 PM, Adam Farley8
wrote:
> Hi All,
>
> If committers really don't want this code, we could always try fixing
the code that the warning
> is complaining about.
>
> -- Change
Hi All,
If committers really don't want this code, we could always try fixing the
code that the warning
is complaining about.
-- Change
---
diff --git a/src/java.desktop/share/native/libjavajpeg/jchuff.c
b/src/java.desktop/share/n
Hi All,
I ask for a committer to add one word to make/lib/Awt2dLibraries.gmk to
solve a build break.
We need to go to line 495 and add array-bounds into the list of disabled
warnings.
So this:
DISABLED_WARNINGS_gcc := clobbered implicit-fallthrough
shift-negative-value, \
becomes this:
DI
Hi All,
I ask for a committer to one word to make/lib/Awt2dLibraries.gmk
We need to go to line 495 and add array-bounds into the list of disabled
warnings.
So this:
DISABLED_WARNINGS_gcc := clobbered implicit-fallthrough
shift-negative-value, \
becomes this:
DISABLED_WARNINGS_gcc := clobbe
-- Summary --
I ask for a committer to go into jdk/jdk and add one word to
make/lib/Awt2dLibraries.gmk
We need to go to line 495 and add array-bounds into the list of disabled
warnings.
So this:
DISABLED_WARNINGS_gcc := clobbered implicit-fallthrough
shift-negative-value, \
becomes this:
Re: [OpenJDK 2D-Dev] RFR: Bug Pending: Build fails to compile
jchuff.cErik Joelsson to: Adam Farley8 01/02/2018 17:06
Cc: build-dev, David Holmes, John Paul Adrian Glaubitz, Magnus Ihse Bursie
From: Erik Joelsson
To: Adam Farley8
Cc: build-dev , David Holmes
, John Paul Adrian Glaubitz
>On 01/23/2018 05:25 PM, Adam Farley8 wrote:
>>> SLE-11:* doesn't even have OpenJDK-8 and is also going to be out of
support
>>> next year anyway.
>>
>> Does this mean the gcc version will change? If you have hard
information on
>> this, I'd
> On 01/23/2018 03:13 PM, Adam Farley8 wrote:
>> The URL supplied by David (Holmes) lists 4.8.5 as the gcc version for
>> building JDK9 on SLES 11.3/12.1. Whether it's in a repository or not,
>> I read that as "this is the gcc version you should be bu
> On 01/23/2018 02:44 PM, Adam Farley8 wrote:
>> John: I read your email, and I understand your position. I disagree
with it,
>> but I understand it. 4.8.5 is an old version of gcc, but right now it
is the
>> listed gcc version for SUSE sles on intel, ppc, ppcle, and zLinux
L. I agree with your position on 4.8.5 gcc needing
to compile OpenJDK without errors or special options. :)
Best Regards
Adam Farley
From: Phil Race
To: Adam Farley8 , 2d-dev@openjdk.java.net
Cc: build-dev
Date: 18/01/2018 19:16
Subject:Re: [OpenJDK 2D-Dev] [PATCH] Build f
Hi All,
Under these circumstances, jchuff.c will not compile:
Platform: zLinux (s390x)
Release: JDK9 (may affect other JDKs).
GCC Version: 4.8.5
Notes: --disable-warnings-as-errors suppresses this error.
The error is:
/home/adamfarl/hotspot/jdk9/jdk/src/java.desktop/share/native/libjavajpeg/jch
25 matches
Mail list logo
