Re: [OpenJDK 2D-Dev] RFR: JDK-8071469 Cleanup include and exclude of sound native libraries after source code restructure

2018-03-22 Thread Alex Menkov
Hi Magnus, the fix looks good to me. --alex On 03/22/2018 00:41, Magnus Ihse Bursie wrote: On 2018-03-21 19:08, Alex Menkov wrote: Hi Magnus, > I have tested the following: >   * On my linux machine, failure to load libjsound.so was not fatal. In Platform.java:   54 loadLib

Re: [OpenJDK 2D-Dev] RFR: JDK-8071469 Cleanup include and exclude of sound native libraries after source code restructure

2018-03-21 Thread Alex Menkov
ndian fails too. --alex On 03/21/2018 07:09, Magnus Ihse Bursie wrote: On 2018-03-16 17:49, Alex Menkov wrote: On 03/15/2018 13:09, Magnus Ihse Bursie wrote: 15 mars 2018 kl. 20:13 skrev Phil Race : As far as I know the split was made to dynamically load ALSA/DirectSound stuff Yes, I

Re: [OpenJDK 2D-Dev] RFR: JDK-8071469 Cleanup include and exclude of sound native libraries after source code restructure

2018-03-16 Thread Alex Menkov
g is fatal (see com.sun.media.sound.Platform.loadLibraries()), loading of extra libs is non-fatal. I believe libjsound loading failure should be made non-fatal, then all the functionality will remain the same as we have now. --alex /Magnus -phil. On 03/15/2018 12:06 PM, Alex Menkov wrote: On 03/15/2018 11:44, Magnus Ihse Bu

Re: [OpenJDK 2D-Dev] RFR: JDK-8071469 Cleanup include and exclude of sound native libraries after source code restructure

2018-03-15 Thread Alex Menkov
On 03/15/2018 11:44, Magnus Ihse Bursie wrote: On 2018-03-15 18:23, Phil Race wrote: I wondered if that might be the case since it was a "BSD" port .. using X11 .. Maybe we should be getting rid of them ? I agree, we should delete them. I just shuffled them around in the hope that they woul

Re: [OpenJDK 2D-Dev] [9] Review Request: 8179596 Update java.desktop to be HTML-5 friendly

2017-05-05 Thread Alex Menkov
Okay, Then +1 to Phil's approval --alex On 05/05/2017 12:37, Sergey Bylokhov wrote: Hi, Alexey. Yes it is possible to add to this changes, but actually tag is not used in JavaSound docs. The last one were removed a few years ago. The tag is used in assumption that it affect the text till

Re: [OpenJDK 2D-Dev] [9] Review Request: 8179596 Update java.desktop to be HTML-5 friendly

2017-05-05 Thread Alex Menkov
Overall looks good. One minor point - there are several places when you replace with without end . Usually absent doesn't cause any problem, but it would be better to have end tags for all elements. I see this in src/java.desktop/share/classes/javax/sound/midi/MidiMessage.java src/java.desk