Re: [OpenJDK 2D-Dev] New warnings in layout code

2016-01-22 Thread Andrew Hughes
- Original Message - > Hi, snip... > > > Arguably the test could be removed but I would prefer to leave it in > > and change the code it so it is actually tested. > > > > -fno-strict-overflow is just too compiler-specific and too far removed > > from the code to be something I would want

Re: [OpenJDK 2D-Dev] [rfc]Stream doesn't reset mark in finally

2015-12-02 Thread Andrew Hughes
- Original Message - > On 11/25/2015 06:53 PM, Andrew Hughes wrote: > > - Original Message - > >> On 11/18/2015 06:17 PM, Jiri Vanek wrote: > >>> On 11/12/2015 02:24 PM, Sergey Bylokhov wrote: > >>>> Hi, Jiri. > >>>>

Re: [OpenJDK 2D-Dev] [rfc]Stream doesn't reset mark in finally

2015-11-25 Thread Andrew Hughes
- Original Message - > On 11/18/2015 06:17 PM, Jiri Vanek wrote: > > On 11/12/2015 02:24 PM, Sergey Bylokhov wrote: > >> Hi, Jiri. > >> This is a valid point, did you file a new CR for this issue? > > ping? > > >> > > > > Hello! > > > > here it is: > > https://jvanek.fedorapeople.org/orac

Re: [OpenJDK 2D-Dev] RFR: 8081315: 8077982 giflib upgrade breaks system giflib builds with earlier versions

2015-06-08 Thread Andrew Hughes
- Original Message - > Sure, looks good to me. > > Thanks, > > Alexander. > > On 06/05/2015 06:34 PM, Andrew Hughes wrote: > > - Original Message - > >> Hi Andrew, > >> > >> We have removed a workaround[0] for interlaced imag

Re: [OpenJDK 2D-Dev] RFR: 8081315: 8077982 giflib upgrade breaks system giflib builds with earlier versions

2015-06-05 Thread Andrew Hughes
- Original Message - > Hi Andrew, > > We have removed a workaround[0] for interlaced images support, there is > no need in it after 5.0.0 [1]: > > DGifSlurp() and EGifSpew() now read and write interlaced images properly. > I didn't test it, but it seems to me that interlaced images will lo

Re: [OpenJDK 2D-Dev] RFR: 8077982: giflib upgrade breaks system giflib builds with earlier versions

2015-06-02 Thread Andrew Hughes
- Original Message - > I think you meant the subject to be "RFR: 8081315 ..." > Ah yes, I moved the 8077982 in front of the colon when it's actually part of the bug description i.e. RFR: 8081315: 8077982 giflib upgrade :( > if (DGifCloseFile(gif, NULL) == GIF_ERROR) >return 0

[OpenJDK 2D-Dev] RFR: 8077982: giflib upgrade breaks system giflib builds with earlier versions

2015-06-02 Thread Andrew Hughes
Bug: https://bugs.openjdk.java.net/browse/JDK-8081315 Webrev: http://cr.openjdk.java.net/~andrew/8081315/webrev.01/ In 8011278, the option was added to build OpenJDK with a system installation of giflib, something we've been doing for many years in the IcedTea project. Following 8077982, the inte

Re: [OpenJDK 2D-Dev] RFR: Allow using the system libjpeg

2014-05-22 Thread Andrew Hughes
- Original Message - > > On 2014-05-22 02:49, Omair Majid wrote: > > * Andrew Hughes [2014-05-21 20:23]: > >> - Original Message - > >>> * Andrew Hughes [2014-05-21 12:22]: > >>>> I'm not keen on the hardcoding of '-lj

Re: [OpenJDK 2D-Dev] RFR: Allow using the system libjpeg

2014-05-21 Thread Andrew Hughes
- Original Message - > * Andrew Hughes [2014-05-21 12:22]: > > I'm not keen on the hardcoding of '-ljpeg' > > > > + LIBJPEG_LIBS := -ljpeg > > There's no pkg-config files for it. Any suggestions on how to get > something generic? >

Re: [OpenJDK 2D-Dev] RFR: Allow using the system libjpeg

2014-05-21 Thread Andrew Hughes
- Original Message - > Hi, > > Updated webrevs: > http://cr.openjdk.java.net/~omajid/webrevs/system-libjpeg/01/ > http://cr.openjdk.java.net/~omajid/webrevs/system-libjpeg/01.jdk/ > > * Anthony Petrov [2014-05-19 14:42]: > > make/lib/Awt2dLibraries.gmk > > >1236 LIBJPEG_CFLAGS := > >

Re: [OpenJDK 2D-Dev] Name clash when using the system libjpeg

2014-05-13 Thread Andrew Hughes
- Original Message - > * Phil Race [2014-04-30 15:22]: > > On 4/30/2014 11:52 AM, Omair Majid wrote: > > > > > >In another thread, it was pointed out that j2 stands for "Java to". As > > >in "Java to lcms". > > Really ? That is not something that was obvious to me .. > > I don't think i

Re: [OpenJDK 2D-Dev] Name clash when using the system libjpeg

2014-04-30 Thread Andrew Hughes
- Original Message - > Hi, > > After updating OpenJDK so that system versions of the giflib, libpng and > lcms2 libraries can be used by OpenJDK, I am looking at addressing > libjpeg next. > > The trouble here is that there is an actual name clash between (the > openjdk) libjpeg.so and

Re: [OpenJDK 2D-Dev] RFR: Allow using a system-installed lcms2

2014-03-26 Thread Andrew Hughes
- Original Message - > On 2014-03-22 20:11, Omair Majid wrote: > > > Thanks. I wasn't sure how an empty value might be processed. > Make can't really see the difference between an unassigned variable and > one assigned to nothing. (Or, it can, but it's more tricky to check). In > all the

Re: [OpenJDK 2D-Dev] RFR: Allow using a system-installed lcms2

2014-03-21 Thread Andrew Hughes
- Original Message - > Hi, > > * Phil Race [2014-03-19 12:39]: > > On 3/17/2014 4:27 AM, Magnus Ihse Bursie wrote: > > >While we generally support moving files to a proper location, if > > >this move is causing trouble for Phil and the 2d team, we think it > > >can be an acceptable exce

Re: [OpenJDK 2D-Dev] RFR: Allow using a system-installed lcms2

2014-02-21 Thread Andrew Hughes
- Original Message - > On 2014-02-20 23:40, Omair Majid wrote: > > Hi, > > > > The following is a preliminary webrev that allows OpenJDK to build and > > run against a system-installed copy of lcms2 rather than the copy > > bundled with OpenJDK: > > > > root: http://cr.openjdk.java.net/~oma

Re: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] fix for bug 8011693: Remove redundant fontconfig files

2013-05-30 Thread Andrew Hughes
- Original Message - > On 05/30/2013 03:29 PM, Andrew Hughes wrote: > > - Original Message - > >>> None of these are touched any more in the current patch, as we don't > >>> build > >>> on > >>> these targets. > &g

Re: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] fix for bug 8011693: Remove redundant fontconfig files

2013-05-30 Thread Andrew Hughes
snip... > > Ok I was thinking of the 7 makefile: > > > > -FONTCONFIGS_SRC= $(PLATFORM_SRC)/classes/sun/awt/fontconfigs > > -_FONTCONFIGS = \ > > - fontconfig.properties \ > > - fontconfig.SuSE.properties \ > > - fontconfig.Ubuntu.prope

Re: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] fix for bug 8011693: Remove redundant fontconfig files

2013-05-30 Thread Andrew Hughes
s themselves and support for the files are distinct issues. > >> There should still be the ability for [say] Gentoo, to decide they want > >> a particular set of fonts used and so they will ship a file . > >> So it might be better to leave the variables there (empty) and w

Re: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] fix for bug 8011693: Remove redundant fontconfig files

2013-05-29 Thread Andrew Hughes
, not removed: http://jvanek.fedorapeople.org/oracle/jdk8/webrevs/removedFontConfigFiles-linuxOnly/jdk.patch > > -phil. > > On 5/29/2013 5:06 AM, Andrew Hughes wrote: > > - Original Message - > >> On 05/20/2013 04:37 PM, Jiri Vanek wrote: > >>&

Re: [OpenJDK 2D-Dev] Request for review [XS]: The XRender backend fails to render any glyphs on 64-bit Big-endian architectures

2013-05-29 Thread Andrew Hughes
propose it and CC you. I just didn't want to step on any one's toes if it was already in progress :) > Thank you and best regards, > Volker > > > > On Wed, May 22, 2013 at 3:03 PM, Andrew Hughes wrote: > > > - Original Message - > > > On 5/6/

Re: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] fix for bug 8011693: Remove redundant fontconfig files

2013-05-29 Thread Andrew Hughes
- Original Message - > On 05/20/2013 04:37 PM, Jiri Vanek wrote: > > On 05/10/2013 04:08 PM, Jiri Vanek wrote: > >> On 04/08/2013 05:31 PM, Jiri Vanek wrote: > >>> On 04/08/2013 04:13 PM, Vladislav Karnaukhov wrote: > Hello Jiri, > > please see inline. > > On 4/8/20

Re: [OpenJDK 2D-Dev] Request for review [XS]: The XRender backend fails to render any glyphs on 64-bit Big-endian architectures

2013-05-22 Thread Andrew Hughes
- Original Message - > On 5/6/2013 5:25 AM, Volker Simonis wrote: > > On Wed, May 1, 2013 at 9:30 PM, Phil Race wrote: > >> Volker .. thanks for the patch looks good although I ask > >> that you break the source code lines at no more than 80 chars .. > >> that's the norm/standard we have a

Re: [OpenJDK 2D-Dev] Defect 7032904(XRender: Java2Demo) remains

2013-05-21 Thread Andrew Hughes
- Original Message - > Hi Frank, > > > Recently our team discovered defect 7032904(XRender: Java2Demo : Infinite > > loop in Java_sun_java2d_loops_MaskBlit_MaskBlit on OEL 5.6 x64) still > > exists > > in latest JDK (7u21) on SLES10SP4. It can be easily reproduced by running > > SwingSe

Re: [OpenJDK 2D-Dev] Fwd: requesting bug id for removing redundant fontconfig files

2013-04-08 Thread Andrew Hughes
have had ample opportunity to object. > J. > > > > > On 2013-04-08 10:00, Jiri Vanek wrote: > >> On 04/03/2013 04:42 PM, Andrew Hughes wrote: > >>> [Forwarding to 2d-dev] > >>> > >>> - Forwarded Message - > >

[OpenJDK 2D-Dev] Fwd: requesting bug id for removing redundant fontconfig files

2013-04-03 Thread Andrew Hughes
[Forwarding to 2d-dev] - Forwarded Message - > Hi! > > FontConfig files are no longer necessary for jdk7 and 8. I have patch for > their removal > (http://jvanek.fedorapeople.org/oracle/jdk8/webrevs/removedFontConfigFiles/) > and I have built and > tested - looks ok. > This approach was

Re: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] Building ExtensionSubtables.cpp should use -fno-strict-aliasing

2012-05-30 Thread Andrew Hughes
- Original Message - > > On May 29, 2012, at 10:55 AM, Andrew Haley wrote: > > > On 05/29/2012 06:12 PM, Kelly O'Hair wrote: > >> > >> You should be able to do something like: > >> > >> # Turn off aliasing with GCC for ExtensionSubtables.cpp > >> ifeq ($(PLATFORM), linux) > >> CXXFLAGS

Re: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] Building ExtensionSubtables.cpp should use -fno-strict-aliasing

2012-05-29 Thread Andrew Hughes
- Original Message - > In anticipation of the updated fix I created > 7171223 : Building ExtensionSubtables.cpp should use > -fno-strict-aliasing > > -phil. > > > Ok for jdk8? If so, can I have a bug ID for this please? > > > > Thanks, > > Thanks for the bug ID, Phil. Here's the revi

Re: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] Building ExtensionSubtables.cpp should use -fno-strict-aliasing

2012-05-23 Thread Andrew Hughes
- Original Message - > > > > On May 23, 2012, at 9:32 AM, Andrew Hughes wrote: > > > Yes, I thought the same. But I don't see how you can direct flags to > one specific file in the Makefiles. Any ideas? > > You can add something like this t

Re: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] Building ExtensionSubtables.cpp should use -fno-strict-aliasing

2012-05-23 Thread Andrew Hughes
ags to > one specific file in the Makefiles. Any ideas? > > Alternatively, is this READ_LONG macro even necessary? I'm not > surprised > gcc balks at it to be honest. > > > -phil. > > > > On 5/23/2012 5:59 AM, Andrew Hughes wrote: > > > At pres

Re: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] Building ExtensionSubtables.cpp should use -fno-strict-aliasing

2012-05-23 Thread Andrew Hughes
e a more targeted fix ? > Yes, I thought the same. But I don't see how you can direct flags to one specific file in the Makefiles. Any ideas? Alternatively, is this READ_LONG macro even necessary? I'm not surprised gcc balks at it to be honest. > -phil. >

[OpenJDK 2D-Dev] [PATCH FOR REVIEW] Building ExtensionSubtables.cpp should use -fno-strict-aliasing

2012-05-23 Thread Andrew Hughes
At present, the building of ExtensionSubtables.cpp produces a warning: ../../../src/share/native/sun/font/layout/ExtensionSubtables.cpp:57:31: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] due to this code: // read a 32-bit value that might only