Re: [OpenJDK 2D-Dev] RFR: 8209113 : Use WeakReference for lastFontStrike for created Fonts

+1. Thanks, Jay On 05/12/19, 10:14 AM, "2d-dev on behalf of Philip Race" <2d-dev-boun...@openjdk.java.net on behalf of philip.r...@oracle.com> wrote: That is equivalent, just syntactic, so no issue there. Any other reviewers ? This needs two. -phil. On 12/4/19, 2

Re: [OpenJDK 2D-Dev] [14] Review Request: 8234325 Delete unused vsync related code from the OGL pipeline on macOS

Changes are fine. Thanks, Jay > On 18-Nov-2019, at 3:18 PM, Sergey Bylokhov > wrote: > > Hello. > Please review the fix for JDK 14. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8234325 > Fix: http://cr.openjdk.java.net/~serb/8234325/webrev.00 > > During developments of the early version

Re: [OpenJDK 2D-Dev] [PATCH] 8210058: Algorithmic Italic font leans opposite angle in Printing

t is the copyright of the ttf file. If it is >> not self-generated or GPL licensed or we are not sure of of its origin(most >> of will be copyrighted to Adobe or such, which are not ok to be checked in), >> It's better to reuse the A.ttf file already present in the repo >&

Re: [OpenJDK 2D-Dev] [PATCH] 8210058: Algorithmic Italic font leans opposite angle in Printing

n >> mailto:prasanta.sadhuk...@oracle.com>> wrote: >> Only thing to be concerned about is the copyright of the ttf file. If it is >> not self-generated or GPL licensed or we are not sure of of its origin(most >> of will be copyrighted to Adobe or such, which are no

Re: [OpenJDK 2D-Dev] RFR: 8227324 : Upgrade to freetype 2.10.1

+1. Changes are fine. Thanks, Jay > On 23-Nov-2019, at 5:19 AM, Sergey Bylokhov > wrote: > > Looks fine. > > On 11/22/19 10:21 am, Phil Race wrote: >> bug: https://bugs.openjdk.java.net/browse/JDK-8227324 >> webrev : http://cr.openjdk.java.net/~prr/8227324/ >> This is just a small (as these t

Re: [OpenJDK 2D-Dev] [PATCH] 8210058: Algorithmic Italic font leans opposite angle in Printing

s can be reused? If the latter is acceptable, should it > be copied to the location near the test's source code, or it can be loaded by > a relative reference? > > Best regards, > Dmitry Batrak > > On Mon, Nov 18, 2019 at 1:29 PM Jayathirth Rao <mailto:jayathirth...

Re: [OpenJDK 2D-Dev] [PATCH] 8210058: Algorithmic Italic font leans opposite angle in Printing

Hi Dmitry, Thanks for the patch. I can sponsor this. I went through the change and it looks okay. But I have a concern about using specific values for matrix based on Freetype version for Oblique type. I have less idea about that maybe Phil or others can clarify the same. Regarding adding regr

Re: [OpenJDK 2D-Dev] RFR: 8233097: Fontmetrics for large Fonts has zero width

Changes are fine. Thanks, Jay > On 01-Nov-2019, at 1:29 AM, Sergey Bylokhov > wrote: > > Looks fine. > > On 10/30/19 11:37 am, Phil Race wrote: >> PS .. a positive from this is that with this fix the regression test >> runs about 10X faster than it did with say JDK 13 GA .. due to >> skipping

Re: [OpenJDK 2D-Dev] RFR: 8175984 : ICC_Profile has un-needed, not-empty finalize method

Changes are fine. Thanks, Jay > On 11-Oct-2019, at 2:01 PM, Philip Race wrote: > > Bug: ICC_Profile has un-needed, not-empty finalize method > Webrev: http://cr.openjdk.java.net/~prr/8175984/ > > This is a native memory utilisation problem due to delay in collecting and > freeing ICC_Profiles

Re: [OpenJDK 2D-Dev] [14] Review Request: 8229810 NullPointerException getting bounds of GraphicsConfiguration

Thanks for the clarification. Changes are fine. Thanks, Jay > On 04-Oct-2019, at 3:19 AM, Sergey Bylokhov > wrote: > > Hi, Jay. >> I think we should drive device update through >> GraphicsEnvironment.displayChanged() and DisplayChangeListener instead of >> force updating bounds in GraphicsDe

Re: [OpenJDK 2D-Dev] [14] Review Request: 8228676 Cleanup the native code related to fonts on Unix

Changes are fine. Thanks, Jay > On 03-Oct-2019, at 11:10 AM, Sergey Bylokhov > wrote: > > Anyone? > > On 9/14/19 12:44 pm, Sergey Bylokhov wrote: >> Any volunteers to review=)? >> On 7/26/19 2:48 pm, Sergey Bylokhov wrote: >>> Hello. >>> Please review the fix for JDK 14. >>> >>> Bug: https:/

Re: [OpenJDK 2D-Dev] [14] Review Request: 8229810 NullPointerException getting bounds of GraphicsConfiguration

Hi Sergey, I think we should drive device update through GraphicsEnvironment.displayChanged() and DisplayChangeListener instead of force updating bounds in GraphicsDevice.displayChanged in the constructor. We can synchronise the GraphicsEnvironment.displayChanged() by calling it under CGraphics

Re: [OpenJDK 2D-Dev] [14] Review Request: 8231335 [macos] Delete unused and partly implemented JOGL/Java2D bridge

Changes are fine. Thanks, Jay > On 30-Sep-2019, at 7:11 AM, Sergey Bylokhov > wrote: > > Hello. > Please review the small cleanup for JDK 14. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8231335 > Fix: http://cr.openjdk.java.net/~serb/8231335/webrev.00 > > Some unused code was removed.

Re: [OpenJDK 2D-Dev] [14] Review Request: 8229896 Delete an unused code in the BufferedContext

Looks good to me. Thanks, Jay > On 09-Sep-2019, at 3:12 AM, Sergey Bylokhov > wrote: > > Hello. > Please review the fix for JDK 14. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8229896 > Fix: http://cr.openjdk.java.net/~serb/8229896/webrev.01 > > During developments of the early version

Re: [OpenJDK 2D-Dev] RFR[14]: JDK-8230728 : Thin stroked shapes are not rendered if affine transform has flip bit

+1. Thanks, Jay > On 10-Sep-2019, at 3:18 AM, Phil Race wrote: > > Approved. > > -phil. > > On 9/6/19 2:15 PM, Laurent Bourgès wrote: >> Hi, >> >> Please review this bug fix for the Marlin renderer (present in Pisces code >> since JDK 6?): >> JBS: https://bugs.openjdk.java.net/browse/JDK-82

Re: [OpenJDK 2D-Dev] RFR: 8229800 : WindowsServerCore 1809 does not provide d2d1.dll library required by awt.dll

Hi Phil, I went through the changes and I see that we are doing similar dynamic loading of d2d1.dll as we are doing for shcore.dll and loading code looks good. Also I confirmed that among the overloaded functions of D2D1CreateFactory, the one with 4 arguments is the generic one. I have not veri

Re: [OpenJDK 2D-Dev] RFR 8225160: Merge JDK-8220154 initial metal implementation patch to the jdk sandbox branch

x27;ve addressed all Phil's concerns, it looks OK to me. >> >> -- Kevin >> >> On 6/20/2019 5:57 AM, Jayathirth Rao wrote: >>> Hi Alexey, >>> >>> Thanks for the review. >>> >>> Removed new trace definitions and there refer

Re: [OpenJDK 2D-Dev] RFR 8225160: Merge JDK-8220154 initial metal implementation patch to the jdk sandbox branch

Concerning the logging we can remove it. The junit microbenchmarks are enough > for now to measure and compare performance of drawing. > > Best Regards, > Alexey > >> On 19 Jun 2019, at 12:08, Jayathirth Rao > <mailto:jayathirth@oracle.com>> wrote: >> >

Re: [OpenJDK 2D-Dev] RFR 8225160: Merge JDK-8220154 initial metal implementation patch to the jdk sandbox branch

; so this is something we can discuss but it may need to be measured > to see if it corrupts the very data you want. > { > +if ((traceflags & TRACEPTIME) == 0) { > tracePrimitive(target); > +} > +long time = System

[OpenJDK 2D-Dev] RFR 8225160: Merge JDK-8220154 initial metal implementation patch to the jdk sandbox branch

Hello All, Please review the below code changes: JBS : https://bugs.openjdk.java.net/browse/JDK-8225160 We have merged most of the code provided for review by JetBrains for JDK-8220154 to th

Re: [OpenJDK 2D-Dev] JDK-8220154 Improve java2d rendering performance on macOS by using Metal framework

rawXXX call in MTLRenderer.m > > Why is MetalContext.createRenderEncoderForDest is being created for each > draw call? I think, it is an overhead. > Have you considered managing a VertexBuffer and encoding ’N’ set of draw > calls in a render pass? > > Regards, > Ajit > > >> On 17-

Re: [OpenJDK 2D-Dev] RFR: 8217731: Font rendering and glyph spacing changed from jdk-8 to jdk-11

Changes are fine. Thanks, Jay > On 11-Jun-2019, at 6:09 PM, Philip Race wrote: > > Hi, > > I am still looking for a code review on this - needed today ! > > -phil. > > On 6/5/19, 11:43 AM, Phil Race wrote: >> bug: https://bugs.openjdk.java.net/browse/JDK-8217731 >> webrev: http://cr.openjdk.

Re: [OpenJDK 2D-Dev] JDK-8220154 Improve java2d rendering performance on macOS by using Metal framework

Users/avu/tools/junit-4.10.jar -Dtestdata=/Users/avu/ws/openjdk/test/jdk/jbu/testdata -Djb.java2d.metal=true org.junit.runner.JUnitCore  perf.metal.MetalPerfTestHere is the list of supported methods from Graphics2D: setColorfillOvaltranslatesetTransformrotatesetPaint(new LinearGradientPaint())drawImagefillRectdra

Re: [OpenJDK 2D-Dev] JDK-8220154 Improve java2d rendering performance on macOS by using Metal framework

Hi Alexey, We are trying to test basic calls of Graphics2D as mentioned in https://docs.oracle.com/javase/tutorial/2d/TOC.html I see that Graphics2D.drawImage() with BufferedImage as input works. Also I tried other operations like fillRect

Re: [OpenJDK 2D-Dev] RFR: 8208179: Devanagari not shown with logical fonts on Windows after removal of Lucida Sans from JDK

Hi Phil, Changes are fine. I think script name of Telugu should be “telugu” and not “telegu”. Thanks, Jay > On 25-Apr-2019, at 9:23 PM, Phil Race wrote: > > Any takers ? Jay ? Also adding i18n-dev. > > -phil. > > On 4/20/19 4:29 PM, Philip Race wrote: >> >> Bug: https://bugs.openjdk.java.ne

Re: [OpenJDK 2D-Dev] [13] JDK-8219901: Noto fonts for East Asian countries cannot belong to CompositeFont

and FontManager looks fine. Thanks, Jay > On 04-Apr-2019, at 6:14 PM, Toshio 5 Nakamura wrote: > > Hi phil, Jay, > > Thank you for taking your time to review this patch. > > Thanks, > Toshio Nakamura > - Original message - > From: Jayathirth Rao > To:

Re: [OpenJDK 2D-Dev] [13] JDK-8219901: Noto fonts for East Asian countries cannot belong to CompositeFont

Hi, I am also taking a look at this. I will update my observations soon. Thanks, Jay > On 04-Apr-2019, at 8:23 AM, Philip Race wrote: > > I will get back to this soon but you will still need a 2nd reviewer. > > -phil. > > On 3/25/19, 12:29 AM, Toshio 5 Nakamura wrote: >> >> Hi Phil, >> >>

Re: [OpenJDK 2D-Dev] Request for Sponsor: 8217735: awt_image_GifImageDecoder_parseImage() "interlace" param has the wrong type

Hi Andrew, Thanks for your contribution. I would be happy to sponsor this change. May be J9 by default has tighter checks for JNI parameter types or -XCheck:jni option(https://www.eclipse.org/openj9/docs/xcheck/ ) is enabled while running Swingset d

Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8212875: ftp: links for tiff/TTN2.draft.txt do not respond

Hi Sergey, Please share your inputs. Thanks, Jay > On 22-Nov-2018, at 12:30 PM, Jayathirth D V wrote: > > Hi Sergey, > > Thanks for the review. > > I was following ZLib like content in the table, but as you mentioned we can > keep at least text mentioning that we need to look up stuff rela

[OpenJDK 2D-Dev] [12] RFR JDK-8212865: Broken external link to TIFF6.pdf in ImageIO package-info.java

Hello All, Please review the following fix in JDK 12: Bug : https://bugs.openjdk.java.net/browse/JDK-8212865 Webrev : http://cr.openjdk.java.net/~jdv/8212865/webrev.00/ Thanks, Jay

[OpenJDK 2D-Dev] [12] RFR JDK-8211422: Reading PNG with corrupt CRC for IEND chunk throws IIOException

Hello All, Please review the following fix in JDK12: Bug : https://bugs.openjdk.java.net/browse/JDK-8211422 Webrev: http://cr.openjdk.java.net/~jdv/8211422/webrev.00/ Issue : When we