On Fri, 13 Aug 2021 03:51:23 GMT, Jonathan Gibbons wrote:
> Please review a relatively simple update to have doclnt check for empty
> "descriptions" -- the body of a doc comment, before the block tags.
>
> It is already the case that doclint checks for missing/empty de
their
> over-simplistic minimal comments. It was not possible, in general, to avoid
> updating the source code while preserving line numbers, so in many cases, the
> golden `*.out` files had to be updated as well.
>
> A new test is added, focussing on the different forms of empty/
On Mon, 16 Aug 2021 17:08:13 GMT, Jonathan Gibbons wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/Checker.java line
>> 203:
>>
>>> 201: // Don't report an empty description if the
>>>
On Fri, 13 Aug 2021 09:21:40 GMT, Hannes Wallnöfer wrote:
>> Please review a relatively simple update to have doclnt check for empty
>> "descriptions" -- the body of a doc comment, before the block tags.
>>
>> It is already the case that doclint checks for missing/empty descriptions in
>> bloc
On Fri, 13 Aug 2021 09:20:19 GMT, Hannes Wallnöfer wrote:
>> Please review a relatively simple update to have doclnt check for empty
>> "descriptions" -- the body of a doc comment, before the block tags.
>>
>> It is already the case that doclint checks for missing/empty descriptions in
>> bloc
Please review a relatively simple update to have doclnt check for empty
"descriptions" -- the body of a doc comment, before the block tags.
It is already the case that doclint checks for missing/empty descriptions in
block tags, like @param, @return, etc.
There are three cases to consider:
* T
On Tue, 26 Jan 2021 18:33:48 GMT, Alexey Ivanov wrote:
>>> Probably we can import the CSS used by the javadoc itself?
>>
>> We do. For example, [AWT Modality in JDK
>> 15](https://docs.oracle.com/en/java/javase/15/docs/api/java.desktop/java/awt/doc-files/Modality.html)
>> has borders because o
On Mon, 7 Dec 2020 14:27:45 GMT, Magnus Ihse Bursie wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module.
>> For instance, the publicsuffixlist is used by java.base, and fontconfig by
>> java.desktop. (A few directories, like mainmanifest, is *actually* used by
>
On Thu, 10 Sep 2020 12:04:48 GMT, Dmitriy Dumanskiy
wrote:
> I have in mind dozens of improvements all over the code like this one.
That sounds scary. Broad updates like these cause unnecessary churn in the
codebase, and can make merging and back
porting harder. Changes should be discussed ah
06/06/2019 12:50, Jonathan Gibbons wrote:
You should be able to use {@link} to refer to other Java elements;
It is possible even across the different modules?(I remember there was
some related issue)
-- Jon
On 06/06/2019 12:46 PM, Sergey Bylokhov wrote:
Hi, Prasanta.
Can you please d
Sergey, Prasanta,
You should be able to use {@link} to refer to other Java elements; you
cannot (yet) use {@link} to link to user-defined anchors in other files
(but it's on the list)
-- Jon
On 06/06/2019 12:46 PM, Sergey Bylokhov wrote:
Hi, Prasanta.
Can you please double check is it po
op: 129px;
margin-top: -129px;
}
so nothing specific comes from browser or "
I think the next link may help you
http://nicolasgallagher.com/jump-links-and-viewport-positioning/demo/
--Semyon
On 11/22/2017 02:53 PM, Jonathan Gibbons wrote:
Semyon,
I have reconstructed a very simple, very a
Semyon,
Using the files I previously posted, I confirm that I see the same
display problem on a Mac, using the latest OS (High Sierra) and Safari.
I also see the problem on the same Mac, with Firefox 55.0.2
-- Jon
On 11/22/2017 02:53 PM, Jonathan Gibbons wrote:
Semyon,
I have
fix as well. This bug is about following to the HTML5
standards, so let's follow them in full and not to return to this once
again. We have a good chance to provide documentation in clean HTML5
after the fix without any workarounds.
--Semyon
On 11/14/2017 09:16 AM, Jonathan Gibbons wrote:
10/25/17 6:31 PM, Semyon Sadetsky wrote:
Hi Jonathan,
On 10/24/2017 03:20 PM, Jonathan Gibbons wrote:
Semyon,
Although id is a global attribute and can be used to identify any
node, some browsers do better navigation/scrolling when the id is in
an tag. We have seen poor autoscrolling beh
Semyon,
Although id is a global attribute and can be used to identify any node,
some browsers do better navigation/scrolling when the id is in an
tag. We have seen poor autoscrolling behavior when the id is an a
header tag, such that the header ends up obscured under the navigation
bar at
se ..
-phil.
On 05/17/2017 11:52 AM, Jonathan Gibbons wrote:
Phil,
The bottom line is that in the JDK docs, tables should not have a
summary attribute and should have a caption. This comes down to
accessibility requirements, where we are slowly raising the bar on
our docs, to be in accordance
;d want it to be
visible when we were fine without.
But being there and invisible may be pointless unless screen readers
look for it even if invisible.
But if its not doing any harm I guess we can leave it as proposed
I still need to look at the rest of the changes.
-phil.
On 05/12/2017 05
Sergey,
FWIW, the invisible caption should be regarded as a temporary solution,
until content authors can review/update the text of the caption and make
it visible.
The general guideline in this conversion work has been to avoid changing
the visible text of the specification, and captions fa
Phil,
1. javadoc now provides support for 3 named styles in the default
stylesheet:
borderless: no borders
plain: simple 1px borders around tables and cells
striped: reduced borders; rows have alternating white and light
grey backgrounds
2. summary attributes are n
On 05/12/2017 05:03 PM, Philip Race wrote:
On 5/12/17, 4:58 PM, Jonathan Gibbons wrote:
Phil,
1. javadoc now provides support for 3 named styles in the default
stylesheet:
borderless: no borders
plain: simple 1px borders around tables and cells
striped: reduced
Sergey,
This is not a comment on the content of the review; it is a minor
comment on your interpretation of .
is a block-level tag that is implicitly terminated by any of many
block-level tags. For the full list, see the W3C definition of the p
element in HTML 5:
https://www.w3.org/TR/html
22 matches
Mail list logo
