Re: [OpenJDK 2D-Dev] Fwd: Need reviewers: more predictable binaries

2012-09-06 Thread Kelly O';Hair
intent of the change, since a >> number of .m files in the AWT were changed to use THIS_FILE. >> >> -- Scott K. >> >> On Sep 6, 2012, at 9:30 AM, Kelly O'Hair wrote: >> >>> >>> Just FYI... >>> >>> these build changes

[OpenJDK 2D-Dev] Fwd: Need reviewers: more predictable binaries

2012-09-06 Thread Kelly O';Hair
Just FYI... these build changes do touch sources in various teams, please let me know if you have issues with these changes. -kto Begin forwarded message: > From: "Kelly O'Hair" > Subject: Need reviewers: more predictable binaries > Date: September 5, 2012 9:0

Re: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] Building ExtensionSubtables.cpp should use -fno-strict-aliasing

2012-05-29 Thread Kelly O';Hair
On May 29, 2012, at 10:55 AM, Andrew Haley wrote: > On 05/29/2012 06:12 PM, Kelly O'Hair wrote: >> >> You should be able to do something like: >> >> # Turn off aliasing with GCC for ExtensionSubtables.cpp >> ifeq ($(PLATFORM), linux) >> CXXFLA

Re: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] Building ExtensionSubtables.cpp should use -fno-strict-aliasing

2012-05-29 Thread Kelly O';Hair
You should be able to do something like: # Turn off aliasing with GCC for ExtensionSubtables.cpp ifeq ($(PLATFORM), linux) CXXFLAGS += $(CXXFLAGS_$(@F)) CC_NEWER_THAN_43 := \ $(shell $(EXPR) $(CC_MAJORVER) \> 4 \| \ \( $(CC_MAJORVER) = 4 \& $(CC_MINORVER) \> 3 \) ) ifeq

Re: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] Building ExtensionSubtables.cpp should use -fno-strict-aliasing

2012-05-23 Thread Kelly O';Hair
On May 23, 2012, at 9:32 AM, Andrew Hughes wrote: > Yes, I thought the same. But I don't see how you can direct flags to > one specific file in the Makefiles. Any ideas? You can add something like this to CFLAGS: CFLAGS += $(CFLAGS_$(@F)) Then: CFLAGS_foobar.o = -someoptions -kto

Re: [OpenJDK 2D-Dev] Request for Review: Remove import of empty JNI header files

2012-05-22 Thread Kelly O';Hair
On May 14, 2012, at 1:18 AM, Magnus Ihse Bursie wrote: > On 2012-05-02 00:19, Kelly Ohair wrote: >> Magnus, >> >> Do you still need this integrated? >> I can integrate the exact same changset to awt, 2d, and build forests if >> you want. > > Yes, I still like to have this integrated. (Sorry f

Re: [OpenJDK 2D-Dev] code review request: 7087428: move client tests out of jdk_misc

2011-09-07 Thread Kelly O';Hair
On Sep 7, 2011, at 4:07 AM, Alan Bateman wrote: > Weijun Wang wrote: >> Updated: >> >> root: http://cr.openjdk.java.net/~weijun/7087428/control/webrev.00/ >> jdk: http://cr.openjdk.java.net/~weijun/7087428/webrev.01/ >> >> I also update Makefile to put jdk_sound to its correct alphabetical posi

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6795908: Refactor FontManager

2009-10-26 Thread Kelly O';Hair
Is someone fixing this bootstrap build problem with FontManager.getFontPath(true) and the fontchecker? Not sure I care much how it gets fixed, I just need it fixed. -kto

Re: [OpenJDK 2D-Dev] _LITTLE_ENDIAN

2009-06-23 Thread Kelly O';Hair
Someone would need to make darn sure that ALL uses of the old name have been changed. I counted 362 references to this variable in the openjdk7 repositories, I assume a similar number in openjdk6. The closed jdk sources have an additional 13 references to this _LITTLE_ENDIAN name Sun would need to

Re: [OpenJDK 2D-Dev] _LITTLE_ENDIAN

2009-06-23 Thread Kelly O';Hair
Mario Torre wrote: Hello all! I have a problem with a block of code that checks if _LITTLE_ENDIAN is defined, the code is in little cms and looks like: #ifndef _LITTLE_ENDIAN #define USE_BIG_ENDIAN 1 #endif The issue that I have is that on VxWorks, the target I'm working on, there is al