Hi Goetz,
On 5/13/19 1:38 PM, Lindenmaier, Goetz wrote:
>
> Can I somehow verify that it's the font that has the problem?
> Can I fix the font so that the test passes?
>
I cannot say whether or not the static max advance value in each font is
right or not, but let's assume it is. The underlying
Hi Goetz,
Thanks for raising this issue.
I'm not surprised by MaxAdvanceIsMax test failing on some OS. The reason
is that this test is very OS specific.
All installed fonts are tested and a static value from each font is used
for the assertion, after scale calculations. If there is a difference
On 3/10/19 4:07 AM, Philip Race wrote:
> +1 (approved)
>
> -phil.
>
Pushed to client [1].
Thanks!
--
[1] - http://hg.openjdk.java.net/jdk/client/rev/0804f29e8be7
On 2/27/19 12:20 PM, Philip Race wrote:
> The webrev still appears to be against jdk/jdk not jdk/client
>
> I had suggested excluding small point sizes since I don't think
> the failures I saw can possibly be limited to Solaris ... it just
> hasn't been reproduced elsewhere yet.
Apologies for the
Hi,
Here we have Webrev.03:
* http://cr.openjdk.java.net/~mbalao/webrevs/8218854/8218854.webrev.03/
* http://cr.openjdk.java.net/~mbalao/webrevs/8218854/8218854.webrev.03.zip
Changes:
* Test moved to test/jdk/java/awt/FontMetrics
* Test imports are now explicit
* getAllFonts NPE handled
;
>>
>>
>> On 2/21/19, 2:19 PM, Sergey Bylokhov wrote:
>>> Hi, Martin.
>>>
>>> What exceptions do you expect below? I think any exception will means
>>> a bug in jdk, no?
>>>
>>> try {
>>> GraphicsEnvironme
Hi Phil,
On 2/19/19 10:34 PM, Philip Race wrote:
> One more thing about the test, I am not sure why you need to use
> sun.font.FontDesignMetrics directly ?
>
> Isn't it enough to create a BufferedImage and get an appropriate
> FRC and FM by setting the properties on the graphics for that ?
>
Ye
Hi Phil,
Are we good to go with Webrev.01?
Thanks,
Martin.-
On 2/14/19 3:47 PM, Martin Balao wrote:
> Hi Phil,
>
> Thanks for your feedback.
>
> I proposed the font in the test case because it's licensed under GNU
> Affero General Public License, Version 3 (AGPL) with
Hi Phil,
Thanks for your feedback.
I proposed the font in the test case because it's licensed under GNU
Affero General Public License, Version 3 (AGPL) with an exemption [2].
My understanding was that we were able to ship it. Anyways, I removed
the font and use system installed fonts. On newer Li
Hi,
I'd like to propose the following fix for "JDK-8218854:
FontMetrics.getMaxAdvance may be less than the maximum
FontMetrics.charWidth" [1]:
* http://cr.openjdk.java.net/~mbalao/webrevs/8218854/8218854.webrev.00/
Can I have a review?
Thanks,
Martin.-
--
[1] - https://bugs.openjdk.java.net/b
10 matches
Mail list logo
