Re: [OpenJDK 2D-Dev] [PATCH] support Mongolian and FVS(Mongolian Free Variation Selector)

2018-06-26 Thread Steven R. Loomis
; > > https://drive.google.com/open?id=1aha8xamB44f5XY6RrKYrI9t9czQuuoU2 > > > > https://drive.google.com/open?id=1e_oxCcoHNJQPgbEFEq9tiCEapwbWqm8j > > > Thanks. > Akira Nakajima > > > On 2018/06/22 1:14, Steven R. Loomis wrote: > > There is much discussion about the encoding of Mongolian- see > > https://www.unicode.org/L2/topical/mongolian/ > > > > Is this discussion taken into account? >

Re: [OpenJDK 2D-Dev] Fw: RFR: JDK-8187100: support VariationSelectors(Resend)

2018-06-25 Thread Steven R. Loomis
path code. > > Toshio Nakamura > - Forwarded by Toshio 5 Nakamura/Japan/IBM on 2018/06/26 02:09 - > > From: "Toshio 5 Nakamura" > To: Phil Race > Cc: 2d-dev <2d-dev@openjdk.java.net> <2d-dev@openjdk.java.net>, "Steven > R. Loomis" >

Re: [OpenJDK 2D-Dev] RFR: JDK-8187100: support Variation Selectors(Resend)

2018-06-22 Thread Steven R. Loomis
ersion ? > In particular I mean where are the changes associated with > "Use TextLayout (Harfbuzz) if VS appears." ? > > -phil. > > On 06/22/2018 12:59 PM, Steven R. Loomis wrote: > > Updated webrev: > > http://cr.openjdk.java.net/~srl/8187100/webrev.03

Re: [OpenJDK 2D-Dev] RFR: JDK-8187100: support Variation Selectors(Resend)

2018-06-22 Thread Steven R. Loomis
ppears." ? > > > -phil. > > > On 06/22/2018 12:59 PM, Steven R. Loomis wrote: > > Updated webrev: > > http://cr.openjdk.java.net/~srl/8187100/webrev.03 > > - Use TextLayout (Harfbuzz) if VS appears. > - Composite font's behavior was changed to not chang

Re: [OpenJDK 2D-Dev] RFR: JDK-8187100: support Variation Selectors(Resend)

2018-06-22 Thread Steven R. Loomis
at 3:19 PM Steven R. Loomis wrote: > Updated webrev: > > http://cr.openjdk.java.net/~srl/8187100/webrev.01/ > > On Fri, May 18, 2018 at 9:16 AM, Toshio 5 Nakamura > wrote: > >> Thank you for your review, Phil. >> I'm working to handle your points. >&g

Re: [OpenJDK 2D-Dev] [PATCH] support Mongolian and FVS(Mongolian Free Variation Selector)

2018-06-21 Thread Steven R. Loomis
There is much discussion about the encoding of Mongolian- see https://www.unicode.org/L2/topical/mongolian/ Is this discussion taken into account? On Wed, Jun 20, 2018 at 10:28 AM Phil Race wrote: > It is not clear to me how this supports Free Variation Selectors for > Mongolian as claimed. >

Re: [OpenJDK 2D-Dev] RFR: JDK-8187100: support Variation Selectors(Resend)

2018-06-18 Thread Steven R. Loomis
1FF. > The latter is represented by Surrogate pair in a char array. > My previous code named the same for them, and it may cause a confusion. > I updated the names to isVariationSelectorBMP and isVariationSelectorExt. > > > Steven, > Thank you for your kind support. > > B

Re: [OpenJDK 2D-Dev] RFR: JDK-8187100: support Variation Selectors(Resend)

2018-06-18 Thread Steven R. Loomis
Updated webrev 02 http://cr.openjdk.java.net/~srl/8187100/webrev.02/ On Thu, May 31, 2018 at 3:19 PM, Steven R. Loomis wrote: > Updated webrev: > > http://cr.openjdk.java.net/~srl/8187100/webrev.01/ > > On Fri, May 18, 2018 at 9:16 AM, Toshio 5 Nakamura > wrote: > >>

Re: [OpenJDK 2D-Dev] RFR: JDK-8187100: support Variation Selectors(Resend)

2018-05-31 Thread Steven R. Loomis
since it could affect all text rendering in a way that is measurable > > in at least some way. > > > > I idly wonder if > > > > > > public static boolean isBaseChar(int charCode){ ... > > > > might be more cleanly or efficiently implemented with

Re: [OpenJDK 2D-Dev] RFR: 8204122: Update harfbuzz.md

2018-05-30 Thread Steven R. Loomis
LGTM On Wed, May 30, 2018 at 3:04 PM, Phil Race wrote: > Bug: https://bugs.openjdk.java.net/browse/JDK-8204122 > > I pushed harfbuzz 1.7.6 without updating the version in the legal file. > The diff is trivial so I am including inline here : > > --- a/src/java.desktop/share/legal/harfbuzz.md > ++

Re: [OpenJDK 2D-Dev] RFR: 8199530 : Upgrade to harfbuzz 1.7.6

2018-05-30 Thread Steven R. Loomis
+1 On Wed, May 30, 2018 at 11:08 AM, Sergey Bylokhov < sergey.bylok...@oracle.com> wrote: > Looks fine. > > > On 30/05/2018 10:44, Phil Race wrote: > >> Bug: https://bugs.openjdk.java.net/browse/JDK-8199530 >> Webrev: http://cr.openjdk.java.net/~prr/8199530/ >> >> We are currently using harfbuzz

Re: [OpenJDK 2D-Dev] RFR: JDK-8187100: support Variation Selectors (Resend)

2018-05-02 Thread Steven R. Loomis
I added a screenshot to https://bugs.openjdk.java.net/browse/JDK-8187100 if anyone wants to see what the impact of this fix is On Wed, Apr 25, 2018 at 8:39 AM, Steven R. Loomis wrote: > (Retrying as actual text) > > Support Unicode Variation Selectors. > > Code by my colleague

[OpenJDK 2D-Dev] RFR: JDK-8187100: support Variation Selectors (Resend)

2018-04-25 Thread Steven R. Loomis
(Retrying as actual text) Support Unicode Variation Selectors. Code by my colleague Toshio Nakamura, I added a simple test, and include a test that was part of JDK 8187100. (Both tests are run manually.) Bug: https://bugs.openjdk.java.net/browse/JDK-8187100 Webrev: http://cr.openjdk.java.net/~s

[OpenJDK 2D-Dev] RFR: JDK-8187100: support Variation Selectors

2018-04-25 Thread Steven R Loomis
ces> 3) Swing text component's DEL and BS key operations change>>> How would I go about obtaining a sponsor?>> [1] _http://www.unicode.org/versions/Unicode10.0.0/ch23.pdf_>      Chapter 23.4 Variation Selectors>> Best regards,>> Toshio Nakamura> IBM Japan    Steven R. Loomis IBM Global Foundations Technology Team https://ibm.biz/srloomis 

Re: [OpenJDK 2D-Dev] Proposal: Unicode Variation Selector

2018-04-12 Thread Steven R Loomis
the webrev also looks OK to me, I did not check the math yet. Steven R. Loomis IBM Global Foundations Technology Team Technical Lead, ICU for C/C++ Phone: 1-720-342-4930  https://ibm.biz/srloomis  E-mail: srloo...@us.ibm.com     - Original message -From: Phil Race To: Toshio 5 Nakamura

Re: [OpenJDK 2D-Dev] Proposal: Unicode Variation Selector

2018-04-12 Thread Steven R Loomis
I can sponsor this. Steven R. Loomis IBM Global Foundations Technology Team Technical Lead, ICU for C/C++ Phone: 1-720-342-4930  https://ibm.biz/srloomis  E-mail: srloo...@us.ibm.com     - Original message -From: Phil Race To: Toshio 5 Nakamura , 2d-dev@openjdk.java.net, Steven R

Re: [OpenJDK 2D-Dev] RFR: 8183978 : Remove ICU layout code from OpenJDK

2017-10-13 Thread Steven R. Loomis
t; classpath without > test modifications ??? > > -phil. > > > On 10/12/2017 02:22 PM, Sergey Bylokhov wrote: > >> Looks fine. >> I guess we should update TestLayoutVsICU.java test which was added as >> part of harfbuzz integration. I assumed that it should c

Re: [OpenJDK 2D-Dev] RFR: 8183978 : Remove ICU layout code from OpenJDK

2017-10-12 Thread Steven R. Loomis
approve On Wed, Oct 11, 2017 at 9:59 AM, Phil Race wrote: > Bug: https://bugs.openjdk.java.net/browse/JDK-8183978 > Webrev: http://cr.openjdk.java.net/~prr/8183978/ > > This fix removes the obsolete ICU opentype layout code from JDK 10. > > I've built this on all platforms (including open+closed

Re: [OpenJDK 2D-Dev] Question regarding the integration of harfbuzz (JEP 258)

2015-12-11 Thread Steven R. Loomis
t;>> Does AIX use pthread for threading? I can definitely add a threading >>> stress-test to HarfBuzz. I definitely should. Filed here: >>> >>> https://github.com/behdad/harfbuzz/issues/195 >>> >>> Thanks, >>> behdad >>>

Re: [OpenJDK 2D-Dev] Question regarding the integration of harfbuzz (JEP 258)

2015-12-11 Thread Steven R. Loomis
ding? I can definitely add a threading >> stress-test to HarfBuzz. I definitely should. Filed here: >> >> https://github.com/behdad/harfbuzz/issues/195 >> >> Thanks, >> behdad >> >>> On Thu, Dec 10, 2015 at 2:27 PM, Volker Simonis >>>

Re: [OpenJDK 2D-Dev] Question regarding the integration of harfbuzz (JEP 258)

2015-12-09 Thread Steven R. Loomis
Volker, 0. I’d like to see what the crashing stack frame is when NOT on harfbuzz, because there should be no change. 1. Phil addressed this one 2. I will take a look on AIX. I’ll see if I can build Harfbuzz itself on AIX at first. 3. Yes, I’ll work on putting some docs together for that te

Re: [OpenJDK 2D-Dev] CFV and Project Proposal: HarfBuzz Integration Project (#2)

2013-09-18 Thread Steven R. Loomis
) PROPOSAL I hereby propose the creation of the HarfBuzz Integration Project with Steven R. Loomis as the Lead and 2d-dev at openjdk.java.net as the sponsoring Group(s). I am the maintainer of the ICU Layout Engine, which is used for complex text rendering since Java 1.2 ([1]). This package has not

[OpenJDK 2D-Dev] FYI CFV and Project Proposal: HarfBuzz Integration Project

2013-07-25 Thread Steven R. Loomis
-0700 From: Steven R. Loomis To: disc...@openjdk.java.net CC: Behdad Esfahbod , Omair Majid I hereby propose the creation of the HarfBuzz Integration Project with Steven R. Loomis as the Lead and 2d-dev@openjdk.java.net as the sponsoring Group(s). I am the maintainer of the ICU

Re: [OpenJDK 2D-Dev] Add optional support for using the system libicu

2013-07-03 Thread Steven R. Loomis
6a329,330 > virtual void getKerningAdjustment(LEPoint &adjustment) const = 0; On 6/24/13 5:24 p.m., Steven R. Loomis wrote: Omair, I'm sorry I did not see this before. I probably would not have noticed it except I happened to notice this reply. I'm responsible for m

Re: [OpenJDK 2D-Dev] Add optional support for using the system libicu

2013-06-24 Thread Steven R. Loomis
Omair, I'm sorry I did not see this before. I probably would not have noticed it except I happened to notice this reply. I'm responsible for maintaining the version of ICU in JDK, and also (read: main day job) IBM's lead for ICU for C/C++. ( But I speak for myself here, of course. ) I t

Re: [OpenJDK 2D-Dev] pls review jdk 7 fix for 8015334

2013-06-19 Thread Steven R. Loomis
Looks good to me. On 6/19/13 10:42 a.m., Phil Race wrote: I revamped the test to scrap the unnecessary swing stuff. No invokeLater needed anymore. http://cr.openjdk.java.net/~prr/8015334.jdk7.1/ Nothing else has changed. -phil. On 6/19/2013 5:28 AM, Andrew Brygin wrote: Hello Phil, The fix

Re: [OpenJDK 2D-Dev] CFV: Doug Felt to Membership in the 2D group

2008-06-25 Thread Steven R. Loomis
Vote: yes Phil Race wrote: I hereby nominate Doug Felt as a member of the OpenJDK 2D group. Doug has made significant contributions to the Java 2D text APIs and their implementation starting in 1997 and in every release from JDK 1.2 up to and including JDK 6. As part of the Taligent (later I