Re: [OpenJDK 2D-Dev] RFR: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8 [v2]

2021-05-06 Thread Thomas Stuefe
On Thu, 6 May 2021 16:38:52 GMT, Phil Race wrote: >> Thomas Stuefe has updated the pull request incrementally with one additional >> commit since the last revision: >> >> switch off warning in build instead of fixing it > > The policy is to do what you end

[OpenJDK 2D-Dev] Integrated: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8

2021-05-06 Thread Thomas Stuefe
On Wed, 5 May 2021 07:54:20 GMT, Thomas Stuefe wrote: > Harfbuzz upgrade broke Linux x64 build on older gccs. For details see JBS > issue. > > I fixed the issue in the harfbuzz sources, but I am not sure of the policy > here. Do we modify the harfbuzz sources or leave them un

Re: [OpenJDK 2D-Dev] RFR: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8 [v2]

2021-05-06 Thread Thomas Stuefe
On Thu, 6 May 2021 07:53:52 GMT, Richard Reingruber wrote: > Looks good to me, thanks! > Personally I'm building with gcc 9. I've test your fix successfully with gcc > 7.5. > > Cheers, Richard. Thanks Richard! I tested the build on Debian with gcc 7 and gcc 9, it worked. Since I now have enou

Re: [OpenJDK 2D-Dev] RFR: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8 [v2]

2021-05-06 Thread Thomas Stuefe
On Thu, 6 May 2021 06:16:36 GMT, Aleksey Shipilev wrote: >> Thomas Stuefe has updated the pull request incrementally with one additional >> commit since the last revision: >> >> switch off warning in build instead of fixing it > > FWIW, current jdk master builds

Re: [OpenJDK 2D-Dev] RFR: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8

2021-05-05 Thread Thomas Stuefe
On Wed, 5 May 2021 07:54:20 GMT, Thomas Stuefe wrote: > Harfbuzz upgrade broke Linux x64 build on older gccs. For details see JBS > issue. > > I fixed the issue in the harfbuzz sources, but I am not sure of the policy > here. Do we modify the harfbuzz sources or leave them un

Re: [OpenJDK 2D-Dev] RFR: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8 [v2]

2021-05-05 Thread Thomas Stuefe
ixes linux x64 fastdebug and opt build for me. Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision: switch off warning in build instead of fixing it - Changes: - all: https://git.openjdk.java.net/jdk/pull/3

Re: [OpenJDK 2D-Dev] RFR: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8

2021-05-05 Thread Thomas Stuefe
On Wed, 5 May 2021 07:54:20 GMT, Thomas Stuefe wrote: > Harfbuzz upgrade broke Linux x64 build on older gccs. For details see JBS > issue. > > I fixed the issue in the harfbuzz sources, but I am not sure of the policy > here. Do we modify the harfbuzz sources or leave them un

Re: [OpenJDK 2D-Dev] RFR: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8

2021-05-05 Thread Thomas Stuefe
On Wed, 5 May 2021 07:54:20 GMT, Thomas Stuefe wrote: > Harfbuzz upgrade broke Linux x64 build on older gccs. For details see JBS > issue. > > I fixed the issue in the harfbuzz sources, but I am not sure of the policy > here. Do we modify the harfbuzz sources or leave them un

[OpenJDK 2D-Dev] RFR: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8

2021-05-05 Thread Thomas Stuefe
Harfbuzz upgrade broke Linux x64 build on older gccs. For details see JBS issue. I fixed the issue in the harfbuzz sources, but I am not sure of the policy here. Do we modify the harfbuzz sources or leave them untouched? Advice is welcome. The patch fixes linux x64 fastdebug and opt build for m

Re: [OpenJDK 2D-Dev] RFR: 8261169: Upgrade HarfBuzz to the latest 2.8.0

2021-05-05 Thread Thomas Stuefe
On Fri, 30 Apr 2021 20:07:53 GMT, Phil Race wrote: > Upgrade to harfbuzz 2.8 https://github.com/openjdk/jdk/pull/3873 - PR: https://git.openjdk.java.net/jdk/pull/3826

Re: [OpenJDK 2D-Dev] RFR: 8261169: Upgrade HarfBuzz to the latest 2.8.0

2021-05-05 Thread Thomas Stuefe
On Fri, 30 Apr 2021 20:07:53 GMT, Phil Race wrote: > Upgrade to harfbuzz 2.8 Same here. In my case it breaks with gcc 7.5.0, which I believe is still supported. I opened https://bugs.openjdk.java.net/browse/JDK-8266545. - PR: https://git.openjdk.java.net/jdk/pull/3826

Re: [OpenJDK 2D-Dev] RFR: JDK-8260432: allocateSpaceForGP in freetypeScaler.c might leak memory [v3]

2021-01-28 Thread Thomas Stuefe
On Thu, 28 Jan 2021 08:25:03 GMT, Matthias Baesken wrote: >> The function AllocateSpaceForGP in freetypeScaler.c calls potentially 2 >> times malloc ; however the memory is not always freed correctly in case of >> errors. >> See also the related sonar issue : >> https://sonarcloud.io/project/

Re: [OpenJDK 2D-Dev] RFR: JDK-8260432: allocateSpaceForGP in freetypeScaler.c might leak memory

2021-01-27 Thread Thomas Stuefe
On Wed, 27 Jan 2021 12:02:06 GMT, Aleksey Shipilev wrote: >> Then we would free as well for the realloc code path >> } else { >> /* do we have enough space? */ >> ... >> } >> Is this okay? > > Yes, I think that is better: `realloc` can fail as well, and we don't want to >