On Wed, 27 Jan 2021 19:23:48 GMT, Erik Joelsson wrote:
> To guarantee backwards compatible binaries on Macos, we use the option
> -mmacosx-version-min. This is currently set to 10.9, which is a really
> ancient version. I propose we bump this to 10.12, which is still a rather
> conservative ol
Erik:
This patch changes the values for the macosx version min and max
settings from 10.7 to 10.9. It also changes the stdlib from libstdc++ to
libc++ (explicitly for Hotspot and implicitly everywhere else). This
change is necessary to keep up with newer toolchain versions on Macosx
where using
Erik:
Webrev: http://cr.openjdk.java.net/~erikj/8196803/webrev.01/index.html
Bug: https://bugs.openjdk.java.net/browse/JDK-8196803
Looks good.
/Tim
Hi Phil
Looks good to me as well.
Tim
On 08/31/17 12:48, Sergey Bylokhov wrote:
+1
On 8/31/17 12:21, Phil Race wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8183351
Webrev: http://cr.openjdk.java.net/~prr/8183351/
This bug caused an internal test system to report a failure of this te
Erik:
The current --disable-headful option is weird. Even worse, it doesn't
work since the makefiles still uses the legacy BUILD_HEADLESS_ONLY
variable, which configure never touches.
In this patch I'm replacing the configure option with
--enable-headless-only. Default is disabled, where bot
Magnus:
Looks good to me as well.
Tim
On 03/04/15 05:31, Erik Joelsson wrote:
Hello,
Really nice to finally see this patch getting done!
Only one comment:
flags.m4:
In the grep expression, could you move the extra [] outside of the
actual command line options to grep so that the command li
Hi Erik:
Please review this small fix to the build when linking
libfontmanager.so on Solaris. Further explanation in the bug.
Bug: https://bugs.openjdk.java.net/browse/JDK-8042208
Patch inline:
Looks good to me.
Tim
diff -r 830cc367f41b make/lib/Awt2dLibraries.gmk
--- a/make/lib/Awt2dLib
Hi Erik
Looks good to me as well.
Tim
Looks good to me.
/Magnus
On 27 mar 2014, at 12:47, Erik Joelsson wrote:
Further testing revealed some more issues. New webrev:
http://cr.openjdk.java.net/~erikj/8038340/webrev.root.03/
I had to break out the devkit/sysroot parts from from BASIC_SETU
