Re: [OpenJDK 2D-Dev] JDK-8215210: [macos] Hangul text does not shape to the precomposed form on JDK8u

2019-10-15 Thread Yuri Nesterenko
> They might be interested in your regression tests. > > Paul > > On 10/7/19, 5:28 AM, "jdk8u-dev on behalf of Yuri Nesterenko" > wrote: > > Hi all, > > could you please review this downport of > https://bugs.openjdk.ja

Re: [OpenJDK 2D-Dev] Review Request JDK-8172559 [PIT][TEST_BUG] Move @test to be 1st annotation in java/awt/image/Raster/TestChildRasterOp.java

2017-01-12 Thread Yuri Nesterenko
On 01/12/2017 11:34 AM, Prem Balakrishnan wrote: Hi Phil Agree with you. As it’s a PIT bug with a simple fix – on Ajit and Prasanta’s review, I have already pushed the fix. And I'm sorry about that. There will be merge :-(. We cannot push this buggy test to master: jtreg may stop the whole

Re: [OpenJDK 2D-Dev] [9] RFR 8170352: The collate option is not checked

2016-12-22 Thread Yuri Nesterenko
The patch works; I hope there will be no side-effects. So +1 -yan On 12/16/2016 04:16 PM, Prasanta Sadhukhan wrote: I could finally manage to build on ubuntu16.04 (seems it uses gcc5.4 which is more than officially supported 4.9 causing some hotspot failure). Anyways, I am seeing the same "un

Re: [OpenJDK 2D-Dev] [9] RFR 8160882: [PIT][TEST_BUG] a trap of java/awt/print/PrinterJob/PrintTestLexmarkIQ.java

2016-07-10 Thread Yuri Nesterenko
+1 Thank you! It works. -yan On 07/08/2016 08:40 AM, Prasanta Sadhukhan wrote: Hi All, Please review a test bug fix whereby clicking on x button of testpanel does not fail the test. Bug: https://bugs.openjdk.java.net/browse/JDK-8160882 webrev: http://cr.openjdk.java.net/~psadhukhan/8160882/w

Re: [OpenJDK 2D-Dev] [9]: RFR JDK-8159134: [PIT][TEST_BUG] failed to run java/awt/print/PrinterJob/PrintDlgSelectionAttribTest.java

2016-06-10 Thread Yuri Nesterenko
+1 Thank you! -yan On 06/10/2016 07:38 AM, prasanta sadhukhan wrote: Hi All, Increased the timeout of this manual test so that user can read and verify the instructions within timelimit to avoid timeout. Bug:https://bugs.openjdk.java.net/browse/JDK-8159134 webrev: http://cr.openjdk.java.net

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8158758: [TEST_BUG] test/java/awt/print/PrinterJob/LandscapeStackOverflow.java fails on timeout

2016-06-09 Thread Yuri Nesterenko
Fine with me! -yan PS: this test will still timeout on a system with i.e. PDF printer (a default setup for Windows 10) but that's not an issue. On 06/07/2016 12:11 PM, prasanta sadhukhan wrote: Hi All, Please review a testbug fix for jdk9 where it was seen that jtreg times out if print dialog

Re: [OpenJDK 2D-Dev] [9] Review Request: 7102282 TEST_BUG: sun/java2d/OpenGL/GradientPaints.java should be modified

2016-04-13 Thread Yuri Nesterenko
+1 -yan On 04/13/2016 01:37 AM, Sergey Bylokhov wrote: Hello, Please review the fix for jdk9. This test uncover a few issues: Test bug: - Fail on HiDPI system, because the test tries to check the rendering to the BufferedImage and VolaileImage using some threshold. Fixed by the "-Dsun.java2d

Re: [OpenJDK 2D-Dev] RFR 8152183: [TEST] add test for TIFFField

2016-04-08 Thread Yuri Nesterenko
+1 -yan On 04/01/2016 08:31 PM, Alexander Stepanov wrote: Please see the updated webrev: http://cr.openjdk.java.net/~avstepan/8152183/webrev.01/ One more test (for multi-page tiffs) was added; for now to be ignored because of JDK-8148454 Thanks, Alexander On 3/28/2016 1:07 PM, Alexander Step

Re: [OpenJDK 2D-Dev] RFR 8149028: [TEST] add test for TIFFDirectory

2016-04-01 Thread Yuri Nesterenko
+1 -yan On 03/31/2016 06:52 PM, Alexander Stepanov wrote: Please see http://cr.openjdk.java.net/~avstepan/8149028/webrev.02/ (one more test covering TIFFImageReadParam was added). Thanks, Alexander On 3/29/2016 8:21 PM, Alexander Stepanov wrote: Please see the updated webrev: http://cr.openj

Re: [OpenJDK 2D-Dev] RFR 8149558: [TEST] add regression test for JDK-8150154

2016-03-24 Thread Yuri Nesterenko
Looks OK. -yan On 03/23/2016 12:46 PM, Alexander Stepanov wrote: Hello, Sergey, > Should we also test bmp and jpg? covered as well > all of them have a white color and same size for the 2nd version the images used for the 1st and 2nd checks have different sizes and colors Thanks, Alexander

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8151621, , [TEST_BUG] java/awt/print/PrinterJob/MultiMonPrintDlgTest.java doesn't work with jtreg

2016-03-11 Thread Yuri Nesterenko
Looks fine, and works well. -yan On 03/11/2016 02:34 PM, prasanta sadhukhan wrote: Hi Yuri, All, Bug: https://bugs.openjdk.java.net/browse/JDK-8151621 webrev: http://cr.openjdk.java.net/~psadhukhan/8151621/webrev.00/ It seems when the testcase is executed through jtreg, the main thread finish

Re: [OpenJDK 2D-Dev] [9]: RFR JDK-8058316, , lookupDefaultPrintService returns null on Solaris 11

2016-03-03 Thread Yuri Nesterenko
Thank you, Prasanta! Could you please add this or similar explanation to that JDK-8058316? Please use all the words/phrases a desperate tester would search. If we cannot have a regression test we should have enough search terms to find this bug in case of (apparent) regression. -yan On 03/03/20

Re: [OpenJDK 2D-Dev] RFR: 8145780: create a simple test for TIFF tag sets

2016-02-04 Thread Yuri Nesterenko
OK with me! -yan On 02/03/2016 04:46 PM, Alexander Stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8145780/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8145780 Just a single test added. Thanks, Alexander

Re: [OpenJDK 2D-Dev] [9] RFR 8138838: docs cleanup for java.desktop

2015-12-28 Thread Yuri Nesterenko
off list: I'm afraid it will be on Jan 11-th earliest. -yan On 12/28/2015 04:19 PM, Sergey Bylokhov wrote: I guess, if no objections were raised, we can push it? Otherwise we will w8 forever. Please double check the changes for some merge issues before the push. On 27/10/15 17:07, Sergey Bylok

Re: [OpenJDK 2D-Dev] [9] Review Request: 7131835 [TEST_BUG] Test does not consider that the rounded edges of the window in Mac OS 10.7

2015-09-11 Thread Yuri Nesterenko
+1 -yan On 09/04/2015 03:29 PM, Alexander Zvegintsev wrote: looks fine. Thanks, Alexander. On 09/04/2015 03:23 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. The updated test does not take into account rounded corners of decorated window, and sometimes overlap with the Do

Re: [OpenJDK 2D-Dev] RFR: JDK-8076468 Add @modules to tests in jdk_desktop test group

2015-06-22 Thread Yuri Nesterenko
Hi Alexander, the fix looks OK to me. Thanks, -yan On 06/22/2015 06:44 PM, Alexander Kulyakhtin wrote: Hi, Could you, please, review the test-only changes for the JDK-8076468 CR: JDK-8076468 "Add @modules to the tests in jdk_desktop test group" Webrev: http://cr.openjdk.java.net/~akulyakh/80

Re: [OpenJDK 2D-Dev] RFR: JDK-8076468: Add @modules to jtreg jdk_desktop tests to take into account the new modular architecture

2015-06-02 Thread Yuri Nesterenko
Hi Alexander(s), I have some problems not with this change but with the routine itself. As I understand, this change is automatically generated. The generator script is imperfect. For instance, it cannot catch dependencies in places like javax/swing/RepaintManager/6608456/bug6608456.java where t

Re: [OpenJDK 2D-Dev] [9] Review Request: 8074028 Remove API references to java.awt.peer

2015-03-04 Thread Yuri Nesterenko
On 03/04/2015 04:35 PM, Sergey Bylokhov wrote: On 04.03.2015 15:51, Alan Bateman wrote: On 04/03/2015 12:37, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. There are a number of public API whichreference the unsupported java.awt.peer interfaces. public java.awt.Component.getPee

Re: [OpenJDK 2D-Dev] [2d dev] [8] Review request for JDK-8028272 : Tidy warnings cleanup for javax.print package

2013-11-20 Thread Yuri Nesterenko
Hi Joe, there seems to be several reasons: -- in some cases this just adds an extra line between items in successive construction. Remove the , and these s will stay as close to each other as regular lines in the document. Which means too close, or did mean for original author of the doc. See

[OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 8025235: [javadoc] fix some errors in 2D

2013-11-20 Thread yuri . nesterenko
Changeset: 4592f0985e78 Author:yan Date: 2013-11-20 12:23 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/4592f0985e78 8025235: [javadoc] fix some errors in 2D Reviewed-by: prr, yan Contributed-by: Dmitry Ginzburg ! src/share/classes/java/awt/Font.java ! src/share/classes/ja

Re: [OpenJDK 2D-Dev] <2D Dev> [8] Review Request: JDK-8025235 [javadoc] fix some errors in 2D

2013-11-19 Thread Yuri Nesterenko
Formally, I can approve this fix, I think, and I do, taking (not so huge) responsibility for it. Essentially, Phil has it approved and other properly 2d people have the previous versions scanned. So, I'm pushing it. Thanks, -yan On 11/19/2013 07:23 PM, Dmitry Ginzburg wrote: Hi guys, Сould you

Re: [OpenJDK 2D-Dev] Review Request for 6879044

2009-09-14 Thread Yuri Nesterenko
Artem Ananiev wrote: Mandy Chung wrote: 6879044: Eliminate the dependency of logging from the JRE core/awt/swing classes ... I have quickly looked through AWT/2D changes and haven't found anything suspicious. A funny typo is noticed in X11 key logging (see XToolkit or XWindow for examples

[OpenJDK 2D-Dev] hg: jdk7/2d/langtools: 26 new changesets

2009-07-13 Thread yuri . nesterenko
Changeset: 5c2c81120555 Author:xdono Date: 2009-06-25 12:10 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/5c2c81120555 Added tag jdk7-b62 for changeset 6855e5aa3348 ! .hgtags Changeset: 619c768ad104 Author:xdono Date: 2009-07-02 11:11 -0700 URL: http:/

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 81 new changesets

2009-07-13 Thread yuri . nesterenko
Changeset: 8905d218cd0d Author:xdono Date: 2009-06-25 12:10 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/8905d218cd0d Added tag jdk7-b62 for changeset 12e11fab9a83 ! .hgtags Changeset: 2ed6ed6b5bfc Author:jgodinez Date: 2009-06-29 14:42 -0700 URL: http://hg

[OpenJDK 2D-Dev] hg: jdk7/2d/jaxws: 2 new changesets

2009-07-13 Thread yuri . nesterenko
Changeset: b8a6e883c0a6 Author:xdono Date: 2009-06-25 12:09 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jaxws/rev/b8a6e883c0a6 Added tag jdk7-b62 for changeset 75c801c13ea1 ! .hgtags Changeset: aaa25dfd3de6 Author:xdono Date: 2009-07-02 11:10 -0700 URL: http://hg.

[OpenJDK 2D-Dev] hg: jdk7/2d/jaxp: 2 new changesets

2009-07-13 Thread yuri . nesterenko
Changeset: ae449e9c04c1 Author:xdono Date: 2009-06-25 12:09 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jaxp/rev/ae449e9c04c1 Added tag jdk7-b62 for changeset a97dd57a6260 ! .hgtags Changeset: a10eec7a1edf Author:xdono Date: 2009-07-02 11:10 -0700 URL: http://hg.o

[OpenJDK 2D-Dev] hg: jdk7/2d/hotspot: 11 new changesets

2009-07-13 Thread yuri . nesterenko
Changeset: 8754a3c37762 Author:xdono Date: 2009-06-25 12:09 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/8754a3c37762 Added tag jdk7-b62 for changeset a88386380bda ! .hgtags Changeset: 821269eca479 Author:ysr Date: 2009-06-11 12:40 -0700 URL: http://hg.

[OpenJDK 2D-Dev] hg: jdk7/2d: 12 new changesets

2009-07-13 Thread yuri . nesterenko
Changeset: 57f7e028c7ad Author:xdono Date: 2009-06-25 12:09 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/rev/57f7e028c7ad Added tag jdk7-b62 for changeset c7ed15ab92ce ! .hgtags Changeset: 9849536536d2 Author:xdono Date: 2009-07-02 11:10 -0700 URL: http://hg.openjd

[OpenJDK 2D-Dev] hg: jdk7/2d/corba: 9 new changesets

2009-07-13 Thread yuri . nesterenko
Changeset: d20e45cd539f Author:xdono Date: 2009-06-25 12:09 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/corba/rev/d20e45cd539f Added tag jdk7-b62 for changeset 65b66117dbd7 ! .hgtags Changeset: b3ad991d9534 Author:xdono Date: 2009-07-02 11:10 -0700 URL: http://hg.

Re: [OpenJDK 2D-Dev] Java Fullscreen Mode with Xorg server 1.3.0+ (I'm ready to work on a patch)

2007-12-04 Thread Yuri Nesterenko
Hi Dan, this new bug, 6599351, seems to be about the same issue, isn't it? It should be fixed in several releases, as I understand. Now let's decide: if you will create a patch for your bug then I'll not work on my, otherwise I'll start but not very fast, either. Anyway, after your patch is re