Re: [OpenJDK 2D-Dev] [9] Review request for 8047066: Test test/sun/awt/image/bug8038000.java fails with ClassCastException

2014-07-02 Thread anton nashatyrev
Andrew, thanks for review! Could please anyone else review the fix? Thanks! Anton. On 18.06.2014 20:07, Andrew Brygin wrote: Hello Anton, the fix looks fine. Thanks, Andrew On 6/18/2014 6:54 PM, anton nashatyrev wrote: Hello, could you please review the following fix: fix: http

[OpenJDK 2D-Dev] [9] Review request for 8047066: Test test/sun/awt/image/bug8038000.java fails with ClassCastException

2014-06-18 Thread anton nashatyrev
Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8047066/9/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8047066 we just need to check whether the Raser sample model is t

Re: [OpenJDK 2D-Dev] [9] Review request for 8038000: java.awt.image.RasterFormatException: Incorrect scanline stride

2014-04-16 Thread anton nashatyrev
? Otherwise, we are not taking into account the case when minY is greater than 0, and too big scanstride may be potentially dangerous. Thanks, Andrew On 4/10/2014 11:26 PM, anton nashatyrev wrote: Hello, could you please review a slightly update fix version (the regression t

Re: [OpenJDK 2D-Dev] [9] Review request for 8038000: java.awt.image.RasterFormatException: Incorrect scanline stride

2014-04-10 Thread anton nashatyrev
look ideal. However my fix addresses the concrete regression which was introduced by these validations, so I'm leaving the fix as is. Thank you! Anton. On 01.04.2014 19:39, anton nashatyrev wrote: Hello Jim, On 28.03.2014 3:25, Jim Graham wrote: Hi Anton, A lot of those tests seem out o

Re: [OpenJDK 2D-Dev] [9] Review request for 8038000: java.awt.image.RasterFormatException: Incorrect scanline stride

2014-04-01 Thread anton nashatyrev
e ago when some of those validations have been added and I'm not sure we would like to perform some major refactorings here unless any incompatibilities are found. Thank you! Anton. ...jim On 3/26/14 10:35 AM, anton nashatyrev wrote: Hello, could you please revi

[OpenJDK 2D-Dev] [9] Review request for 8038000: java.awt.image.RasterFormatException: Incorrect scanline stride

2014-03-26 Thread anton nashatyrev
Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8038000/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8038000 The last row in the Raster shouldn't be necessary of the scanline

Re: [OpenJDK 2D-Dev] [9] Review request for 8023990: regression : postscript file size increase from 6u17

2014-01-29 Thread anton nashatyrev
Hello, Andrew, thanks for review in offline! Here is the corrected fix: http://cr.openjdk.java.net/~anashaty/8023990/webrev.01/ <http://cr.openjdk.java.net/%7Eanashaty/8023990/webrev.01/> Thanks! Anton. On 28.01.2014 22:52, anton nashatyrev wrote: Hello, please revi

[OpenJDK 2D-Dev] [9] Review request for 8023990: regression : postscript file size increase from 6u17

2014-01-28 Thread anton nashatyrev
Hello, please review the following fix for JDK-9. Phil, Andrew, the fix had been approved by you for JDK-8 (but not yet pushed), this is the 'backport' to JDK-9. The patch has been applied without any modifications. The fix for JDK-9 was tested with the bug testcase and Font2D demo.

Re: [OpenJDK 2D-Dev] [PATCH] JDK-4627340 : RFE: A way to improve text printing performance for postscript devices

2014-01-10 Thread anton nashatyrev
Hi Alex, you also might be interested in the issue I'm working on: https://bugs.openjdk.java.net/browse/JDK-8023990 If you are targeting Linux platform and working with Latin-1 charset primarily this fix may help (I hope I could push it in the nearest future). FYI the fix is here: htt

[OpenJDK 2D-Dev] [8] Review request for 8023990: regression : postscript file size increase from 6u17

2013-11-22 Thread anton nashatyrev
Hello, this is a duplicate request: could you please review the following fix: fix: http://cr.openjdk.java.net/~alitvinov/8023990/webrev.00 bug: https://bugs.openjdk.java.net/browse/JDK-8023990 When the FcFontConfigurat

[OpenJDK 2D-Dev] [8] Review request for 8023990: regression : postscript file size increase from 6u17

2013-09-12 Thread anton nashatyrev
Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~alitvinov/8023990/webrev.00 bug: https://bugs.openjdk.java.net/browse/JDK-8023990 When the FcFontConfiguration was added for using fontconfig

Re: [OpenJDK 2D-Dev] [8] Review request for 8023565: JPG causes javax.imageio.IIOException: ICC APP2 encoutered without prior JFIF!

2013-08-30 Thread anton nashatyrev
Hello, here is the updated fix (without the regression test): http://cr.openjdk.java.net/~alitvinov/8023565/webrev.01 <http://cr.openjdk.java.net/%7Ealitvinov/8023565/webrev.01> Thanks! Anton. On 22.08.2013 21:15, anton nashatyrev wrote: Hello, could you please review the fol

[OpenJDK 2D-Dev] [8] Review request for 8023565: JPG causes javax.imageio.IIOException: ICC APP2 encoutered without prior JFIF!

2013-08-22 Thread anton nashatyrev
Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~alitvinov/8023565/webrev.00 bug: http://bugs.sun.com/view_bug.do?bug_id=8023565 (the bug is not still replicated here so please use the internal jbs